fix(cli): correct --verbose / -v option syntax in acp commands#21303
Merged
gumadeiras merged 3 commits intoopenclaw:mainfrom Feb 20, 2026
Merged
fix(cli): correct --verbose / -v option syntax in acp commands#21303gumadeiras merged 3 commits intoopenclaw:mainfrom
gumadeiras merged 3 commits intoopenclaw:mainfrom
Conversation
68785a4 to
c568176
Compare
c568176 to
17026b5
Compare
Commander.js requires short flag first: "-v, --verbose". The reversed order "--verbose, -v" caused the -v alias to be silently ignored. Co-Authored-By: Claude Opus 4.6 <[email protected]>
d15fadc to
20d058d
Compare
Member
|
Merged via squash. Thanks @adhitShet! |
vignesh07
pushed a commit
to pahdo/openclaw
that referenced
this pull request
Feb 20, 2026
…law#21303) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
anisoptera
pushed a commit
to anisoptera/openclaw
that referenced
this pull request
Feb 20, 2026
…law#21303) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
rodrigogs
pushed a commit
to rodrigogs/openclaw
that referenced
this pull request
Feb 20, 2026
…law#21303) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
Hansen1018
added a commit
to Hansen1018/openclaw
that referenced
this pull request
Feb 21, 2026
…law#21303) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
mmyyfirstb
pushed a commit
to mmyyfirstb/openclaw
that referenced
this pull request
Feb 21, 2026
…law#21303) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
obviyus
pushed a commit
to guirguispierre/openclaw
that referenced
this pull request
Feb 22, 2026
…law#21303) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…law#21303) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 20d058d Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acpandacp clientdeclared their verbose flag as"--verbose, -v"(long flag first)"-v, --verbose". With reversed order, the-valias is silently dropped and the parsed option key is malformedskills-cli.ts,hooks-cli.ts,completion-cli.ts, etc.) correctly uses"-v, --verbose"Files changed:
src/cli/acp-cli.ts— lines 48 and 99Test plan
openclaw acp -vand verify it enables verbose mode (previously silently ignored)openclaw acp client -vand verify the sameopenclaw acp --verboseand verify it still works🤖 Generated with Claude Code
Greptile Summary
Fixes Commander.js option flag order for verbose flags in
acpandacp clientcommands. Previously declared as"--verbose, -v"(long first), which causes Commander.js to silently drop the-valias. Changed to"-v, --verbose"(short first) to match the pattern used throughout the rest of the codebase (skills-cli.ts,hooks-cli.ts,completion-cli.ts, etc.).src/cli/acp-cli.ts:48for the mainacpcommandsrc/cli/acp-cli.ts:99for theacp clientsubcommandopenclaw acp -vandopenclaw acp client -vto work as expectedConfidence Score: 5/5
-vwas silently ignored. Existing tests verify the verbose flag forwarding works correctly, and the fix follows the established pattern used in all other CLI files.Last reviewed commit: 68785a4