Skip to content

fix(cli): correct --verbose / -v option syntax in acp commands#21303

Merged
gumadeiras merged 3 commits intoopenclaw:mainfrom
adhitShet:fix/cli-acp-verbose-flag-order
Feb 20, 2026
Merged

fix(cli): correct --verbose / -v option syntax in acp commands#21303
gumadeiras merged 3 commits intoopenclaw:mainfrom
adhitShet:fix/cli-acp-verbose-flag-order

Conversation

@adhitShet
Copy link
Copy Markdown
Contributor

@adhitShet adhitShet commented Feb 19, 2026

Summary

  • Both acp and acp client declared their verbose flag as "--verbose, -v" (long flag first)
  • Commander.js requires short flag first: "-v, --verbose". With reversed order, the -v alias is silently dropped and the parsed option key is malformed
  • Every other short-flag option in the codebase (skills-cli.ts, hooks-cli.ts, completion-cli.ts, etc.) correctly uses "-v, --verbose"

Files changed: src/cli/acp-cli.ts — lines 48 and 99

Test plan

  • Run openclaw acp -v and verify it enables verbose mode (previously silently ignored)
  • Run openclaw acp client -v and verify the same
  • Run openclaw acp --verbose and verify it still works
  • Lint/format pass

🤖 Generated with Claude Code

Greptile Summary

Fixes Commander.js option flag order for verbose flags in acp and acp client commands. Previously declared as "--verbose, -v" (long first), which causes Commander.js to silently drop the -v alias. Changed to "-v, --verbose" (short first) to match the pattern used throughout the rest of the codebase (skills-cli.ts, hooks-cli.ts, completion-cli.ts, etc.).

  • Corrects src/cli/acp-cli.ts:48 for the main acp command
  • Corrects src/cli/acp-cli.ts:99 for the acp client subcommand
  • Enables openclaw acp -v and openclaw acp client -v to work as expected
  • No functional changes to the verbose behavior itself, only fixes the CLI parsing

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The fix is straightforward and correct - it simply reorders flag declarations to match Commander.js requirements and align with the rest of the codebase. The change is minimal (2 lines), doesn't alter any logic, and fixes a real bug where -v was silently ignored. Existing tests verify the verbose flag forwarding works correctly, and the fix follows the established pattern used in all other CLI files.
  • No files require special attention

Last reviewed commit: 68785a4

@openclaw-barnacle openclaw-barnacle bot added cli CLI command changes size: XS labels Feb 19, 2026
@gumadeiras gumadeiras self-assigned this Feb 20, 2026
@gumadeiras gumadeiras force-pushed the fix/cli-acp-verbose-flag-order branch from 68785a4 to c568176 Compare February 20, 2026 01:26
@gumadeiras gumadeiras force-pushed the fix/cli-acp-verbose-flag-order branch from c568176 to 17026b5 Compare February 20, 2026 01:28
Adi-A and others added 3 commits February 19, 2026 21:01
Commander.js requires short flag first: "-v, --verbose". The reversed
order "--verbose, -v" caused the -v alias to be silently ignored.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@gumadeiras gumadeiras force-pushed the fix/cli-acp-verbose-flag-order branch from d15fadc to 20d058d Compare February 20, 2026 02:04
@gumadeiras gumadeiras merged commit 164d478 into openclaw:main Feb 20, 2026
13 checks passed
@gumadeiras
Copy link
Copy Markdown
Member

Merged via squash.

Thanks @adhitShet!

vignesh07 pushed a commit to pahdo/openclaw that referenced this pull request Feb 20, 2026
…law#21303)

Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
anisoptera pushed a commit to anisoptera/openclaw that referenced this pull request Feb 20, 2026
…law#21303)

Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
rodrigogs pushed a commit to rodrigogs/openclaw that referenced this pull request Feb 20, 2026
…law#21303)

Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
Hansen1018 added a commit to Hansen1018/openclaw that referenced this pull request Feb 21, 2026
…law#21303)

Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
vincentkoc pushed a commit that referenced this pull request Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
vincentkoc pushed a commit that referenced this pull request Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
mmyyfirstb pushed a commit to mmyyfirstb/openclaw that referenced this pull request Feb 21, 2026
…law#21303)

Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
obviyus pushed a commit to guirguispierre/openclaw that referenced this pull request Feb 22, 2026
…law#21303)

Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
…law#21303)

Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 20d058d
Co-authored-by: adhitShet <[email protected]>
Co-authored-by: gumadeiras <[email protected]>
Reviewed-by: @gumadeiras
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli CLI command changes size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants