ci(lobster): fix flakey test windows cmd shim script resolution#20833
Merged
vincentkoc merged 1 commit intoopenclaw:mainfrom Feb 19, 2026
Merged
Conversation
kittipond2365
pushed a commit
to kittipond2365/openclaw
that referenced
this pull request
Feb 19, 2026
anschmieg
pushed a commit
to anschmieg/openclaw
that referenced
this pull request
Feb 19, 2026
yneth-ray-openclaw
pushed a commit
to yneth-ray-openclaw/openclaw
that referenced
this pull request
Feb 19, 2026
vignesh07
pushed a commit
to pahdo/openclaw
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.cmd/.batshim resolution in Lobster plugin when launching throughresolveWindowsLobsterSpawn.%dp0%/%~dp0%token variants so valid wrappers resolve to Node entrypoints without shell execution.Changes
extensions/lobster/src/windows-spawn.tsresolveLobsterScriptFromCmdShimto parse%dp0%-style arguments more flexibly and normalize candidate paths reliably.extensions/lobster/src/lobster-tool.test.ts%dp0%shim format in Windows path handling.Validation
extensions/lobster/src/lobster-tool.test.ts.Greptile Summary
Fixes Windows cmd shim resolution to handle rooted
%dp0%token variants. The updated parser now extracts all quoted strings first, then checks for%dp0%/%~dp0%tokens within them, making it robust to different formatting styles. Includes regression test for rooted token format ("%dp0%\\..\\path"). Security posture preserved - continues to reject wrappers that require shell execution.Confidence Score: 5/5
Last reviewed commit: a829c4f