Chat UI: accept canonical main session key alias#20311
Merged
Conversation
8a45e9a to
a4ed523
Compare
Contributor
Author
anschmieg
pushed a commit
to anschmieg/openclaw
that referenced
this pull request
Feb 19, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: a4ed523 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
HenryChenV
pushed a commit
to HenryChenV/openclaw
that referenced
this pull request
Feb 20, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: a4ed523 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainsession-key alias as equivalent in ChatViewModelTesting
Greptile Summary
Fixes a bug where the Chat UI's
ChatViewModelwould silently drop external-run completion events when the gateway published the canonical session key"agent:main:main"but the UI was initialized with the short alias"main". This caused the UI to miss history refreshes from runs completed by other clients or agent surfaces.matchesCurrentSessionKeystatic method inChatViewModel.swiftthat normalizes and compares keys, with a special-case bidirectional alias match for"main"↔"agent:main:main"— consistent with how the TypeScript UI already handles this inapp-render.helpers.tsacceptsCanonicalSessionKeyEventsForExternalRunstest covering the fix, and anacceptsCanonicalSessionKeyEventsForOwnPendingRuntest documenting that own-run events already bypassed the session key guard via theisOurRunflagConfidence Score: 5/5
Last reviewed commit: 8a45e9a