Merged
Conversation
openclaw-barnacle
bot
added
app: web-ui
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
src/cli/nodes-cli/register.push.ts
Outdated
Comment on lines
78
to
79
| const { ok: okLabel } = getNodesTheme(); | ||
| defaultRuntime.log(okLabel(`push.test status=${status} ok=${ok} env=${env}`)); |
Contributor
There was a problem hiding this comment.
Success color used for failed pushes
The output is always formatted with the ok (green/success) theme color, even when the APNs push fails (ok=false). When a push returns e.g. status 400, the user sees green-colored text saying ok=false, which is misleading. Consider choosing the color based on the result:
Suggested change
| const { ok: okLabel } = getNodesTheme(); | |
| defaultRuntime.log(okLabel(`push.test status=${status} ok=${ok} env=${env}`)); | |
| const { ok: okLabel, error: errorLabel } = getNodesTheme(); | |
| const label = ok ? okLabel : errorLabel; | |
| defaultRuntime.log(label(`push.test status=${status} ok=${ok} env=${env}`)); |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/cli/nodes-cli/register.push.ts
Line: 78:79
Comment:
**Success color used for failed pushes**
The output is always formatted with the `ok` (green/success) theme color, even when the APNs push fails (`ok=false`). When a push returns e.g. status 400, the user sees green-colored text saying `ok=false`, which is misleading. Consider choosing the color based on the result:
```suggestion
const { ok: okLabel, error: errorLabel } = getNodesTheme();
const label = ok ? okLabel : errorLabel;
defaultRuntime.log(label(`push.test status=${status} ok=${ok} env=${env}`));
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Author
|
It appears that this broke |
18 tasks
anschmieg
pushed a commit
to anschmieg/openclaw
that referenced
this pull request
Feb 19, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 6a1c442 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
HenryChenV
pushed a commit
to HenryChenV/openclaw
that referenced
this pull request
Feb 20, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 6a1c442 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openclaw nodes register pushCLI flowTesting
Greptile Summary
Adds a complete APNs push test pipeline: protocol schemas (
PushTestParams/PushTestResult), apush.testgateway server method (gated behindoperator.writescope), anopenclaw nodes pushCLI command, APNs infrastructure (push-apns.ts) with token registration, JWT-based auth with caching, and HTTP/2 delivery, plus apush.apns.registernode event handler for iOS nodes to register their push tokens.push.testhandler follows existing patterns (respondInvalidParams,respondUnavailableOnThrow).pushcommand always renders output in green "success" color regardless of whether the push succeeded or failed, which could confuse operators when debugging push failures.Confidence Score: 4/5
src/cli/nodes-cli/register.push.tsuses success color for failed push results.Last reviewed commit: a411741