Skip to content

Comments

use process PATH for bash tool#202

Merged
steipete merged 2 commits intomainfrom
fix/path-env
Jan 6, 2026
Merged

use process PATH for bash tool#202
steipete merged 2 commits intomainfrom
fix/path-env

Conversation

@joshp123
Copy link
Contributor

@joshp123 joshp123 commented Jan 5, 2026

Human Description (from Josh)

"in nix mode then path gets all fucked up and tools that are built and in the bash closure for that nix thing dont show up. then clawdis is sad. im tired and dont really konw whats going on"

Feature Intent (low‑friction)

In Nix-managed installs, tools are added to the gateway process PATH. The bash tool was ignoring that PATH and defaulting to a hardcoded system path, so Nix-provided tools (e.g., picnic/summarize) appeared missing inside tool execution. This change makes the bash tool inherit the gateway process PATH, so tools that are already available to Clawdbot remain available during command execution.

Process summary:

  • Observed tools missing inside bash despite being installed and visible to the gateway process.
  • Traced the mismatch to the bash tool’s default PATH.
  • Switched default PATH to process.env.PATH to align tool execution with the gateway environment.

Prompt History (UTC, user prompts)

  • 2026-01-05T01:00:07.757251Z check the logs. its failing in our padel test chat and sending stupid empty messages
  • 2026-01-05T01:00:08.757251Z summarize is apparently not available in path.
  • 2026-01-05T01:00:09.757251Z new session says CLI's not on PATH. Got the auth token cached at ~/.picnic-token but no picnic binary available.
  • 2026-01-05T01:00:10.757251Z Need to install the picnic CLI or add it to PATH. Where's the package at?

what: default bash PATH to process.env.PATH

why: ensure Nix-provided tools on PATH inside sessions

tests: not run
@joshp123 joshp123 marked this pull request as draft January 5, 2026 00:27
steipete added a commit that referenced this pull request Jan 6, 2026
@steipete steipete marked this pull request as ready for review January 6, 2026 03:05
@steipete steipete merged commit cbc39bd into main Jan 6, 2026
25 checks passed
@steipete steipete deleted the fix/path-env branch January 6, 2026 03:05
@steipete
Copy link
Contributor

steipete commented Jan 6, 2026

Marked ready and merged (squash). Added a thank-you changelog entry in Unreleased Fixes: .

@steipete
Copy link
Contributor

steipete commented Jan 6, 2026

Marked ready and merged (squash). Added a thank-you changelog entry in Unreleased Fixes: CHANGELOG.md.

dgarson added a commit to dgarson/clawdbot that referenced this pull request Feb 7, 2026
…7) (openclaw#202)

Implements a comprehensive, configurable scoring system for determining
which experiences should become long-term memories.

## New Module: scoring/

- **types.ts**: Full type definitions for factors, breakdowns, configs
- **factors.ts**: Five factor scorers (novelty, impact, relational, temporal, userIntent)
- **scorer.ts**: Composite scorer with tool/pattern overrides, threshold profiles
- **defaults.ts**: Default weights, profiles (standard/aggressive/conservative), overrides
- **index.ts**: Barrel exports

## Factor Scoring Model

- **Novelty (0.25)**: Detects repetitive vs. new tool usage patterns
- **Impact (0.30)**: Classifies tool types (high/medium/low impact), error detection, meta keywords
- **Relational (0.15)**: Entity detection via tags, keywords, file paths, URLs
- **Temporal (0.10)**: Time-of-day awareness, burst detection, pacing analysis
- **User Intent (0.20)**: Explicit marks, manual captures, intent keywords

## Override System

- Tool-specific rules: fixedScore, minScore, maxScore, weightMultiplier
- Pattern-based rules: error boost, large result detection, tag matching
- User intent override: highest priority

## Integration

- Updated evaluate.ts with evaluateRelevance() bridge function
- Updated config.ts with scoring config resolution (backwards compatible)
- Re-exports for convenience: shouldCaptureMultiFactor, isHighValueMultiFactor, etc.
- breakdownToTrace() for compact trace event embedding

## Tests

- 48 tests across factors.test.ts and scorer.test.ts
- All passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants