fix(telegram): avoid starting streaming replies with only 1-2 words#19673
Closed
emanuelst wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(telegram): avoid starting streaming replies with only 1-2 words#19673emanuelst wants to merge 1 commit intoopenclaw:mainfrom
emanuelst wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
|
Superseded by #27449, which ports this fix intent onto current main (lane-delivery architecture) and includes regression coverage for the short-stale-partial first preview case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(telegram): avoid starting streaming replies with only 1-2 words
Summary
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
List user-visible changes (including defaults/config).
Telegram streaming no longer shows an incomplete first preview fragment.
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation: N/ARepro + Verification
Environment
Steps
NoofNo problem).Expected
Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
Risks and Mitigations
None
Notes
Greptile Summary
This PR fixes an issue where Telegram streaming would display incomplete first preview fragments (e.g., showing "No" before "No problem" appears). The fix adds logic to update the draft stream with the final text before calling
stop()when streaming has occurred but no preview message has been sent yet. This ensures the first visible message contains the complete text rather than stale partial content.draftStream.stop()to prime the draft with final text whenhasStreamedMessageis true butpreviewMessageIdis undefinedtokenparameter to twoeditMessageTelegramcalls for proper account contextConfidence Score: 5/5
Last reviewed commit: 79895b7