Summary

saveCronStore in src/cron/store.ts was always writing jobs.json.bak on every save, even when the serialized cron payload was unchanged. This created unnecessary disk churn and made the backup file less useful because it was being overwritten with the latest state each write.

Root Cause

The previous save flow always:

1. wrote a temp file,
2. renamed it over jobs.json,
3. copied the new jobs.json to jobs.json.bak.

That means .bak represented the newest snapshot, not the previous one, and it was rewritten on every persist tick.

Fix

• Added a pre-write read of the current store content.
• Added a no-op short-circuit when serialized JSON is unchanged.
• When content changes, create jobs.json.bak from the previous on-disk jobs.json before replacing it.

This preserves meaningful backup semantics and avoids unnecessary backup rewrites.

Tests

Added/updated tests in src/cron/store.test.ts:

• verifies no backup file is created when saving identical content twice,
• verifies backup contains the previous store content after a changed save.

Validation

• pnpm lint
• pnpm build
• pnpm test

AI Assistance

• AI-assisted
• Fully tested

Greptile Summary

Fixed unnecessary disk churn in cron store backup mechanism. The previous implementation always created a backup file on every save, even when the content was unchanged. Now the function reads the current file first, short-circuits if the serialized JSON is identical, and only creates jobs.json.bak from the previous jobs.json when the content actually changes. This preserves proper backup semantics (backup = previous state, not current state) and eliminates wasteful disk writes.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The implementation is well-designed with proper error handling, atomic file operations via temp files, and comprehensive test coverage. The logic correctly handles all edge cases including missing files, unchanged content, and first-time saves. The changes eliminate unnecessary disk I/O while preserving backup semantics.
• No files require special attention

_{Last reviewed commit: 3dbb196}

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}