Skip to content

fix(feishu): replace console.log with runtime log for typing indicator errors#18841

Merged
Takhoffman merged 3 commits intoopenclaw:mainfrom
Clawborn:fix/feishu-typing-log-cleanup
Feb 28, 2026
Merged

fix(feishu): replace console.log with runtime log for typing indicator errors#18841
Takhoffman merged 3 commits intoopenclaw:mainfrom
Clawborn:fix/feishu-typing-log-cleanup

Conversation

@Clawborn
Copy link
Copy Markdown
Contributor

@Clawborn Clawborn commented Feb 17, 2026 •
edited by greptile-apps bot
Loading

Typing indicators are non-critical, but errors should still be logged via the runtime logger (verbose only) rather than console.log, which bypasses log levels.

Fix: Updated addTypingIndicator/removeTypingIndicator to accept runtime env and use it for logging.

Greptile Summary

Replaces console.log/console.error calls with runtime logger methods in the Feishu and Zalo extensions, ensuring error and debug output respects log-level configuration.

  • Feishu typing.ts: Error logging in addTypingIndicator/removeTypingIndicator catch blocks now uses runtime?.log?.() gated by shouldLogVerbose(), instead of unconditional console.log. Both functions accept a new optional runtime?: RuntimeEnv parameter.
  • Feishu reply-dispatcher.ts: Updated call sites for addTypingIndicator/removeTypingIndicator to pass the existing params.runtime through.
  • Zalo monitor.ts: Replaced console.error with runtime.error?.() for polling and image download errors, and replaced console.log with the existing logVerbose() helper for sticker/unsupported message logging.

Confidence Score: 5/5

  • This PR is safe to merge — it only changes logging mechanisms without altering any business logic.
  • The changes are straightforward console.log/console.error replacements with runtime logger calls, following patterns already established elsewhere in these extensions (e.g., Zalo's logVerbose helper). No logic changes, no new dependencies, no API surface changes. All call sites are updated and no stale console calls remain in the affected files.
  • No files require special attention.

Last reviewed commit: 658392c

@openclaw-barnacle openclaw-barnacle bot added channel: zalo Channel integration: zalo channel: feishu Channel integration: feishu size: XS trusted-contributor labels Feb 17, 2026
Clawborn and others added 3 commits February 27, 2026 22:39
@Clawborn @Takhoffman
fix(zalo): replace console.log/error with runtime logging
4cfb93a 
Using console methods directly bypasses the structured logging system and runtime controls (like verbose mode).\n\nFix: Replace console.log/error with runtime.log/error and logVerbose helper.
@Takhoffman
fix(feishu): replace console.log with runtime log for typing indicato…
5d06a29 
…r errors

Typing indicators are non-critical, but errors should still be logged via the runtime logger (verbose only) rather than console.log, which bypasses log levels.\n\nFix: Updated addTypingIndicator/removeTypingIndicator to accept runtime env and use it for logging.

Co-authored-by: Clawborn <[email protected]>
@Takhoffman
fix(feishu): preserve typing backoff behavior and update changelog
b67b0d6
@Takhoffman Takhoffman force-pushed the fix/feishu-typing-log-cleanup branch from f023f54 to b67b0d6 Compare February 28, 2026 04:56
@Takhoffman Takhoffman merged commit 10f1be1 into openclaw:main Feb 28, 2026
11 checks passed
@Takhoffman
Copy link
Copy Markdown
Contributor

Takhoffman commented Feb 28, 2026

PR #18841 - fix(feishu): replace console.log with runtime log for typing indicator errors (#18841)

Merged via squash.

  • Merge commit: 10f1be1
  • Verified: pnpm install --frozen-lockfile, pnpm build, pnpm check, pnpm test:macmini
  • Changes made:
    M extensions/feishu/src/reply-dispatcher.ts
    M extensions/feishu/src/typing.ts
    M extensions/zalo/src/monitor.ts
    M CHANGELOG.md
  • Why these changes were made:
    Replace raw console logging with runtime-gated logging while preserving Feishu typing backoff circuit-breaker behavior on modern main, and document the fix in the changelog.
  • Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @Clawborn!

r4jiv007 pushed a commit to r4jiv007/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @r4jiv007
fix(feishu): replace console.log with runtime log for typing indicato…
accf20c 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
mylukin pushed a commit to mylukin/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @mylukin
fix(feishu): replace console.log with runtime log for typing indicato…
9a41aa2 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @wanjizheng
fix(feishu): replace console.log with runtime log for typing indicato…
ff34f9c 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @wanjizheng
fix(feishu): replace console.log with runtime log for typing indicato…
faecce1 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
(cherry picked from commit ff34f9c)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @wanjizheng
fix(feishu): replace console.log with runtime log for typing indicato…
32c41c8 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
(cherry picked from commit ff34f9c)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @wanjizheng
fix(feishu): replace console.log with runtime log for typing indicato…
4b8202d 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
(cherry picked from commit ff34f9c)
vincentkoc pushed a commit to Sid-Qin/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @vincentkoc
fix(feishu): replace console.log with runtime log for typing indicato…
bc088c9 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
vincentkoc pushed a commit to rylena/rylen-openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @vincentkoc
fix(feishu): replace console.log with runtime log for typing indicato…
4820bd4 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
newtontech pushed a commit to newtontech/openclaw-fork that referenced this pull request Feb 28, 2026
@Takhoffman
fix(feishu): replace console.log with runtime log for typing indicato…
568131c 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
@Takhoffman @wanjizheng
fix(feishu): replace console.log with runtime log for typing indicato…
b9df3ae 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
@Takhoffman @wanjizheng
fix(feishu): replace console.log with runtime log for typing indicato…
1b2cfac 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
@github-actions github-actions bot mentioned this pull request Mar 1, 2026
Closed
6 tasks
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026
@github-actions
fix(feishu): replace console.log with runtime log for typing indicato…
93fcb27 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
(cherry picked from commit 10f1be1)

# Conflicts:
#	CHANGELOG.md
@gemini-code-assist gemini-code-assist bot mentioned this pull request Mar 1, 2026
Merged
ansh pushed a commit to vibecode/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @ansh
fix(feishu): replace console.log with runtime log for typing indicato…
10a26d0 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @steipete
fix(feishu): replace console.log with runtime log for typing indicato…
f0ad63d 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request Mar 2, 2026
@Takhoffman @safzanpirani
fix(feishu): replace console.log with runtime log for typing indicato…
6a4f673 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @steipete
fix(feishu): replace console.log with runtime log for typing indicato…
176dc4d 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
venjiang pushed a commit to venjiang/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @venjiang
fix(feishu): replace console.log with runtime log for typing indicato…
f056865 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman
fix(feishu): replace console.log with runtime log for typing indicato…
3985bf1 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @execute008
fix(feishu): replace console.log with runtime log for typing indicato…
f2543d5 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026
@github-actions
fix(feishu): replace console.log with runtime log for typing indicato…
598d40a 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
(cherry picked from commit 10f1be1)

# Conflicts:
#	CHANGELOG.md
dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request Mar 3, 2026
@Takhoffman @dorgonman
fix(feishu): replace console.log with runtime log for typing indicato…
b4a9e42 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request Mar 6, 2026
@Takhoffman
fix(feishu): replace console.log with runtime log for typing indicato…
ee175f2 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
@Takhoffman
fix(feishu): replace console.log with runtime log for typing indicato…
2435c25 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
Mateljan1 pushed a commit to Mateljan1/openclaw that referenced this pull request Mar 7, 2026
@Takhoffman @Mateljan1
fix(feishu): replace console.log with runtime log for typing indicato…
07a0850 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
@alexey-pelykh alexey-pelykh mentioned this pull request Mar 10, 2026
Closed
alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 15, 2026
@Takhoffman @alexey-pelykh
fix(feishu): replace console.log with runtime log for typing indicato…
7055bcf 
…r errors (openclaw#18841) thanks @Clawborn

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
(cherry picked from commit 10f1be1)
@alexey-pelykh alexey-pelykh mentioned this pull request Mar 15, 2026
Merged
alexey-pelykh added a commit to remoteclaw/remoteclaw that referenced this pull request Mar 15, 2026
@alexey-pelykh @Takhoffman
fix(feishu): replace console.log with runtime log for typing indicato…
af6bec4 
…r errors (openclaw#18841) thanks @Clawborn (#1470)

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini



(cherry picked from commit 10f1be1)

Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Clawborn <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

channel: feishu Channel integration: feishu channel: zalo Channel integration: zalo size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Clawborn @Takhoffman