Fix #12770 - Proper validation - update Antigravity default model and trim leading#18585
Merged
steipete merged 1 commit intoopenclaw:mainfrom Feb 16, 2026
Conversation
…im leading whitespace in BlueBubbles replies
Contributor
Additional Comments (2)
Prompt To Fix With AIThis is a comment left during a code review.
Path: docs/help/testing.md
Line: 241:241
Comment:
**Stale model name in command example**
This line still references `claude-opus-4-6-thinking` but the model list on line 264 was updated to `claude-opus-4-5-thinking`. This should be updated to match.
```suggestion
- Antigravity (OAuth): `OPENCLAW_LIVE_GATEWAY_MODELS="google-antigravity/claude-opus-4-5-thinking,google-antigravity/gemini-3-pro-high" pnpm test:live src/gateway/gateway-models.profiles.live.test.ts`
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: docs/help/testing.md
Line: 269:269
Comment:
**Stale model name in smoke command**
Same issue here — the gateway smoke command still references `claude-opus-4-6-thinking` while the model list on line 264 was updated to `claude-opus-4-5-thinking`. This will cause the smoke test to use the old (invalid) model.
```suggestion
`OPENCLAW_LIVE_GATEWAY_MODELS="openai/gpt-5.2,openai-codex/gpt-5.3-codex,anthropic/claude-opus-4-6,google/gemini-3-pro-preview,google/gemini-3-flash-preview,google-antigravity/claude-opus-4-5-thinking,google-antigravity/gemini-3-flash,zai/glm-4.7,minimax/minimax-m2.1" pnpm test:live src/gateway/gateway-models.profiles.live.test.ts`
```
How can I resolve this? If you propose a fix, please make it concise. |
Member
|
Reverted in main.
This PR was merged accidentally, so we reverted it to restore prior behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Body
Summary
Problem: Antigravity was using an invalid
DEFAULT_MODEL, and BlueBubbles replies could contain unintended leading whitespace when blocks were coalesced or dispatched.Why it matters: The invalid model ID caused runtime failures during model resolution. Leading whitespace in outbound replies could break validation logic and produce inconsistent message formatting.
What changed:
DEFAULT_MODELtogoogle-antigravity/claude-opus-4-5-thinking.What did NOT change (scope boundary):
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Security Impact (required)
NoNoNoNoNoNo security surface changes introduced.
Repro + Verification
Environment
Steps (Before Fix)
DEFAULT_MODEL.For BlueBubbles:
Expected
Actual (Before Fix)
Evidence
Verified via runtime logs and manual integration testing.
Human Verification (required)
Verified scenarios:
Edge cases checked:
What you did NOT verify:
Compatibility / Migration
YesNoNoNo migration steps required.
Failure Recovery (if this breaks)
How to disable/revert this change quickly:
Revert this PR or restore previous
DEFAULT_MODELvalue.Files/config to restore:
extensions/google-antigravity-auth/index.tsKnown bad symptoms reviewers should watch for:
Risks and Mitigations
Risk: Trimming could remove intentional formatting in rare cases.
Greptile Summary
Updates the Antigravity
DEFAULT_MODELfromclaude-opus-4-6-thinkingtoclaude-opus-4-5-thinkingand addstrimStart()normalization to BlueBubbles outbound text to strip leading whitespace before validation and dispatch. The model change aligns with the existing forward-compat fallback insrc/agents/model-forward-compat.ts.extensions/google-antigravity-auth/index.ts:DEFAULT_MODELconstant updated to valid model ID.extensions/bluebubbles/src/send.ts:trimStart()added insidesendMessageBlueBubbles, normalizing leading whitespace for all callers (channel, actions, monitor-processing, media-send).extensions/bluebubbles/src/channel.ts:trimStart()also added in thesendTextoutbound path before callingsendMessageBlueBubbles— this is redundant with thesend.tschange but not harmful.docs/help/testing.md: Model list updated on line 264, but two command-line examples on lines 241 and 269 still reference the oldclaude-opus-4-6-thinkingmodel name. These should be updated for consistency.Confidence Score: 3/5
send.ts,channel.ts, andindex.tsare straightforward and correct. However, the docs update intesting.mdis incomplete — two command-line examples still reference the old invalid model name, which undermines the purpose of this PR. Additionally, the zh-CN translation docs also still reference the old model name (though these are noted as generated and out of scope).docs/help/testing.md— lines 241 and 269 still reference the old model nameclaude-opus-4-6-thinkingand need to be updated to match line 264.Last reviewed commit: 36d193e
(2/5) Greptile learns from your feedback when you react with thumbs up/down!