Skip to content

Slack: expand advanced modal controls payloads and confirms#18467

Closed
Solvely-Colin wants to merge 1 commit into
openclaw:mainfrom
Solvely-Colin:codex/slack-advanced-modal-controls
Closed

Slack: expand advanced modal controls payloads and confirms#18467
Solvely-Colin wants to merge 1 commit into
openclaw:mainfrom
Solvely-Colin:codex/slack-advanced-modal-controls

Conversation

@Solvely-Colin

@Solvely-Colin Solvely-Colin commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Delivers an advanced modal-controls bundle by adding richer structured select payloads and native confirm dialogs for slash arg menus.

  • add structured selection arrays in interaction payloads:
    • selectedUsers
    • selectedChannels
    • selectedConversations
  • keep existing unified selectedValues while preserving per-entity detail
  • add native Slack confirm dialogs to slash arg menu elements:
    • button
    • overflow
    • static_select
  • extend interactions/slash tests to validate both structured payloads and confirm-dialog emission

Scope

  • src/slack/monitor/events/interactions.ts
  • src/slack/monitor/events/interactions.test.ts
  • src/slack/monitor/slash.ts
  • src/slack/monitor/slash.test.ts

Validation

  • pnpm test src/slack/monitor/events/interactions.test.ts src/slack/monitor/slash.test.ts
  • pnpm check

Dependency

Depends on:

If reviewing before dependencies merge, review tip commit: 4d343a427.

Greptile Summary

Fixes a this-binding bug in the viewClosed handler registration. The old code destructured viewClosed from the type-cast ctx.app object, which detaches the method from its receiver and loses the this context when invoked. The new code retains a reference to the cast object (appWithViewClosed) and calls viewClosed as a method on it, preserving the correct this binding for the Slack Bolt App instance.

  • Replaces destructured method extraction with method-call-on-object pattern for viewClosed
  • No functional changes to handler logic, type signatures, or event routing
  • Single focused commit that matches the actual code change

Confidence Score: 5/5

  • This PR is safe to merge — it's a small, focused fix that preserves method binding with no behavioral changes.
  • The change is a single-commit, minimal refactor that fixes a potential this-binding issue. The transformation is mechanical (destructured method → method call on object), the type signatures are unchanged, and existing tests cover the viewClosed handler registration path. No new logic, no removed safety checks, no risk of regression.
  • No files require special attention.

Last reviewed commit: c028c42

@Solvely-Colin
Solvely-Colin force-pushed the codex/slack-advanced-modal-controls branch from eaf2ee6 to c028c42 Compare February 17, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: slack Channel integration: slack size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants