Skip to content

Slack: show picker values in interaction confirmations#18465

Closed
Solvely-Colin wants to merge 1 commit into
openclaw:mainfrom
Solvely-Colin:codex/slack-picker-confirmations
Closed

Slack: show picker values in interaction confirmations#18465
Solvely-Colin wants to merge 1 commit into
openclaw:mainfrom
Solvely-Colin:codex/slack-picker-confirmations

Conversation

@Solvely-Colin

@Solvely-Colin Solvely-Colin commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Improves picker interaction UX by rendering selected date/time/datetime values in confirmation rows.

  • include selected datepicker value in confirmation text
  • include selected timepicker value in confirmation text
  • include selected datetimepicker value (ISO UTC) in confirmation text
  • add regression tests for date/time/datetime row confirmation rendering

Scope

  • src/slack/monitor/events/interactions.ts
  • src/slack/monitor/events/interactions.test.ts

Validation

  • pnpm test src/slack/monitor/events/interactions.test.ts
  • pnpm check

Dependency

Depends on:

If reviewing before dependencies merge, review tip commit: ce272b0ca.

Greptile Summary

Refactored viewClosed method access to preserve proper this binding by storing the app reference rather than extracting the method directly. Previously, extracting viewClosed as a standalone function could lose the method's context, potentially causing runtime issues when the method is invoked.

Confidence Score: 5/5

  • Safe to merge with no risk
  • Simple refactoring that improves code correctness by preserving method binding context. The change is minimal (extracting to variable vs calling as method), well-tested with comprehensive test coverage for the viewClosed handler, and follows JavaScript best practices for maintaining proper this context.
  • No files require special attention

Last reviewed commit: 5043302

@Solvely-Colin
Solvely-Colin force-pushed the codex/slack-picker-confirmations branch from eaf2ee6 to 5043302 Compare February 17, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: slack Channel integration: slack size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants