Slack: show picker values in interaction confirmations#18465
Closed
Solvely-Colin wants to merge 1 commit into
Closed
Slack: show picker values in interaction confirmations#18465Solvely-Colin wants to merge 1 commit into
Solvely-Colin wants to merge 1 commit into
Conversation
This was referenced Feb 16, 2026
Solvely-Colin
force-pushed
the
codex/slack-picker-confirmations
branch
from
February 16, 2026 23:03
ce272b0 to
eaf2ee6
Compare
Solvely-Colin
force-pushed
the
codex/slack-picker-confirmations
branch
from
February 17, 2026 00:55
eaf2ee6 to
5043302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves picker interaction UX by rendering selected date/time/datetime values in confirmation rows.
datepickervalue in confirmation texttimepickervalue in confirmation textdatetimepickervalue (ISO UTC) in confirmation textScope
src/slack/monitor/events/interactions.tssrc/slack/monitor/events/interactions.test.tsValidation
pnpm test src/slack/monitor/events/interactions.test.tspnpm checkDependency
Depends on:
If reviewing before dependencies merge, review tip commit:
ce272b0ca.Greptile Summary
Refactored
viewClosedmethod access to preserve properthisbinding by storing the app reference rather than extracting the method directly. Previously, extractingviewClosedas a standalone function could lose the method's context, potentially causing runtime issues when the method is invoked.Confidence Score: 5/5
viewClosedhandler, and follows JavaScript best practices for maintaining properthiscontext.Last reviewed commit: 5043302