Skip to content

Slack: add header and context blocks to arg menus#18458

Closed
Solvely-Colin wants to merge 1 commit into
openclaw:mainfrom
Solvely-Colin:codex/slack-arg-menu-header-context
Closed

Slack: add header and context blocks to arg menus#18458
Solvely-Colin wants to merge 1 commit into
openclaw:mainfrom
Solvely-Colin:codex/slack-arg-menu-header-context

Conversation

@Solvely-Colin

@Solvely-Colin Solvely-Colin commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Expands native slash argument menus to use more Block Kit primitives by adding header and context intro blocks.

  • add header block for command/argument identity
  • keep section block for menu description text
  • add context block to provide concise menu guidance
  • preserve existing menu interaction behavior (button/overflow/static_select)
  • update slash menu tests for the richer block structure

Scope

  • src/slack/monitor/slash.ts
  • src/slack/monitor/slash.test.ts

Validation

  • pnpm test src/slack/monitor/slash.test.ts
  • pnpm check

Dependency

Depends on:

If reviewing before dependencies merge, review tip commit: 5d5f93916.

Greptile Summary

This PR refactors the viewClosed method extraction to preserve method binding in the Slack interaction handler. The change stores a reference to the app object (appWithViewClosed) instead of extracting the viewClosed method directly, ensuring the this context is maintained when the method is called.

Key Changes:

  • Refactored viewClosed extraction to call appWithViewClosed.viewClosed() instead of storing the method in a variable
  • This prevents potential this binding issues if the Slack Bolt library's viewClosed method relies on internal state

Important Note:
The PR title/description mentions "add header and context blocks to arg menus" with changes to src/slack/monitor/slash.ts, but the actual commit (f13be1d) is "preserve viewClosed method binding" affecting src/slack/monitor/events/interactions.ts. The commit matching the PR description (5f9a046) exists on a different branch. The PR metadata should be updated to match the actual changes being merged.

Confidence Score: 4/5

  • This PR is safe to merge - the code change is a valid refactoring that preserves method binding
  • The code change itself is correct and well-tested (existing tests cover the viewClosed handler). However, there's a significant mismatch between the PR description and actual changes, which creates confusion about what's being merged. The technical implementation is sound, but the PR metadata needs correction.
  • No files require special attention - the code change is straightforward and preserves existing behavior

Last reviewed commit: f13be1d

@Solvely-Colin
Solvely-Colin force-pushed the codex/slack-arg-menu-header-context branch from eaf2ee6 to f13be1d Compare February 17, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: slack Channel integration: slack size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants