Slack: enrich modal input payload normalization#18455
Closed
Solvely-Colin wants to merge 1 commit into
Closed
Conversation
openclaw-barnacle
Bot
added
channel: slack
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+142
to
+143
| const inputEmail = | ||
| actionType === "email_text_input" && inputValue?.includes("@") ? inputValue : undefined; |
Contributor
There was a problem hiding this comment.
email validation only checks for @ character
the current validation inputValue?.includes("@") is very basic and will accept invalid emails like "@@", "@", or "foo@". while Slack's email_text_input type does client-side validation, consider adding a more robust check or document that this relies on Slack's validation
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/slack/monitor/events/interactions.ts
Line: 142:143
Comment:
email validation only checks for `@` character
the current validation `inputValue?.includes("@")` is very basic and will accept invalid emails like `"@@"`, `"@"`, or `"foo@"`. while Slack's `email_text_input` type does client-side validation, consider adding a more robust check or document that this relies on Slack's validation
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
This was referenced Feb 16, 2026
Solvely-Colin
force-pushed
the
codex/slack-modal-input-features
branch
from
February 16, 2026 23:03
2bd414c to
eaf2ee6
Compare
openclaw-barnacle
Bot
added
size: XS
and removed
agents
Solvely-Colin
force-pushed
the
codex/slack-modal-input-features
branch
from
February 17, 2026 00:55
eaf2ee6 to
7e6fb0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a combined modal-input feature package for Slack interactions by normalizing richer input element payloads.
number_inputwith parsedinputNumberemail_text_inputwithinputEmailurl_text_inputwith canonicalinputUrlrich_text_inputwithrichTextValueinputKindfor text/number/email/url/rich_text input familiesScope
src/slack/monitor/events/interactions.tssrc/slack/monitor/events/interactions.test.tsValidation
pnpm test src/slack/monitor/events/interactions.test.tspnpm checkDependency
Depends on:
If reviewing before dependencies merge, review tip commit:
2bd414cc2.