Skip to content

Slack: add overflow menus for slash arg choices#18439

Closed
Solvely-Colin wants to merge 1 commit into
openclaw:mainfrom
Solvely-Colin:codex/slack-overflow-arg-menus
Closed

Slack: add overflow menus for slash arg choices#18439
Solvely-Colin wants to merge 1 commit into
openclaw:mainfrom
Solvely-Colin:codex/slack-overflow-arg-menus

Conversation

@Solvely-Colin

@Solvely-Colin Solvely-Colin commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds compact Slack overflow menus for native slash argument selection when choice counts are mid-sized.

  • render overflow menus for command arg choices in the compact range
  • keep existing behavior for small (button) and large (static_select) menus
  • preserve existing action routing by reusing encoded command arg values
  • add tests for overflow rendering and overflow selection dispatch

Scope

  • src/slack/monitor/slash.ts
  • src/slack/monitor/slash.test.ts

Validation

  • pnpm test src/slack/monitor/slash.test.ts
  • pnpm check

Dependency

Depends on:

If reviewing before dependencies merge, review tip commit: 05e4b9ed7.

Greptile Summary

Fixes this binding for the viewClosed method on the Slack Bolt app instance. The previous code destructured viewClosed into a standalone variable before calling it, which would lose the method's this context if the implementation references this internally (standard for Bolt listener registration methods). The new code stores the cast app reference as appWithViewClosed and calls appWithViewClosed.viewClosed(...), preserving the correct receiver.

  • Refactored viewClosed extraction from inline destructuring to a named variable (appWithViewClosed) with method-call syntax
  • No behavioral changes to handler logic, event payloads, or session routing

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, correct fix that preserves method binding without altering any handler logic.
  • The change is a single, well-scoped refactor (8 insertions, 10 deletions) in one file that fixes a potential this binding issue when calling the viewClosed method. No handler logic, event payloads, or routing behavior is modified. The existing test suite covers viewClosed registration and invocation. The fix follows standard JavaScript patterns for preserving method context.
  • No files require special attention

Last reviewed commit: 8ca13de

@Solvely-Colin
Solvely-Colin force-pushed the codex/slack-overflow-arg-menus branch from eaf2ee6 to 8ca13de Compare February 17, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: slack Channel integration: slack size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants