Slack: add overflow menus for slash arg choices#18439
Closed
Solvely-Colin wants to merge 1 commit into
Closed
Conversation
This was referenced Feb 16, 2026
Solvely-Colin
force-pushed
the
codex/slack-overflow-arg-menus
branch
from
February 16, 2026 23:03
05e4b9e to
eaf2ee6
Compare
Solvely-Colin
force-pushed
the
codex/slack-overflow-arg-menus
branch
from
February 17, 2026 00:55
eaf2ee6 to
8ca13de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds compact Slack
overflowmenus for native slash argument selection when choice counts are mid-sized.overflowmenus for command arg choices in the compact rangebutton) and large (static_select) menusScope
src/slack/monitor/slash.tssrc/slack/monitor/slash.test.tsValidation
pnpm test src/slack/monitor/slash.test.tspnpm checkDependency
Depends on:
If reviewing before dependencies merge, review tip commit:
05e4b9ed7.Greptile Summary
Fixes
thisbinding for theviewClosedmethod on the Slack Bolt app instance. The previous code destructuredviewClosedinto a standalone variable before calling it, which would lose the method'sthiscontext if the implementation referencesthisinternally (standard for Bolt listener registration methods). The new code stores the cast app reference asappWithViewClosedand callsappWithViewClosed.viewClosed(...), preserving the correct receiver.viewClosedextraction from inline destructuring to a named variable (appWithViewClosed) with method-call syntaxConfidence Score: 5/5
thisbinding issue when calling theviewClosedmethod. No handler logic, event payloads, or routing behavior is modified. The existing test suite coversviewClosedregistration and invocation. The fix follows standard JavaScript patterns for preserving method context.Last reviewed commit: 8ca13de