Slack: enrich block action context payloads#18431
Closed
Solvely-Colin wants to merge 1 commit into
Closed
Conversation
This was referenced Feb 16, 2026
Solvely-Colin
force-pushed
the
codex/slack-block-action-context
branch
from
February 16, 2026 23:03
a0d5547 to
eaf2ee6
Compare
Solvely-Colin
force-pushed
the
codex/slack-block-action-context
branch
from
February 17, 2026 00:55
eaf2ee6 to
22baace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enriches Slack
block_actioninteraction events with additional context fields and safer channel/message fallbacks.teamId,triggerId,responseUrl, andthreadTsin block action payloadscontainer.channel_id/container.message_tswhenchannel/messageare absentScope
src/slack/monitor/events/interactions.tssrc/slack/monitor/events/interactions.test.tsValidation
pnpm test src/slack/monitor/events/interactions.test.tspnpm checkDependency
Depends on:
If reviewing before dependencies merge, review tip commit:
a0d55470b.Greptile Summary
Refactors the
viewClosedmethod call inregisterSlackInteractionEventsto preservethisbinding. The previous code extractedviewClosedfrom the type-castctx.appobject into a standalone variable, then called it directly — which would lose the method'sthiscontext if the underlying implementation depends on it. The new code keeps a reference to the whole cast object (appWithViewClosed) and invokesappWithViewClosed.viewClosed(...), preserving correct method dispatch.viewClosedis now called as a method on the object rather than as a detached function, preventing potentialthis-binding bugstypeof ... !== "function") and handler registration remain identicalviewClosedbinding fix. The enrichment changes may be in dependent PRs not yet merged into the base.Confidence Score: 5/5
Last reviewed commit: 22baace