Slack: expand interaction payload normalization coverage#18413
Closed
Solvely-Colin wants to merge 1 commit into
Closed
Slack: expand interaction payload normalization coverage#18413Solvely-Colin wants to merge 1 commit into
Solvely-Colin wants to merge 1 commit into
Conversation
This was referenced Feb 16, 2026
Solvely-Colin
force-pushed
the
codex/slack-interaction-payload-coverage
branch
from
February 16, 2026 23:03
2451e72 to
eaf2ee6
Compare
Solvely-Colin
force-pushed
the
codex/slack-interaction-payload-coverage
branch
from
February 17, 2026 00:55
eaf2ee6 to
de5e226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves Slack interaction payload normalization coverage so downstream workflows receive complete, consistent data.
selectedLabelsselected_options, users, channels, conversations)selected_date,selected_time,selected_date_time)Scope
src/slack/monitor/events/interactions.tssrc/slack/monitor/events/interactions.test.tsValidation
pnpm test src/slack/monitor/events/interactions.test.tspnpm checkDependency
Depends on:
If reviewing before dependencies merge, review tip commit:
2451e726e.Greptile Summary
Fixes a
this-binding bug in theviewClosedhandler registration. The previous code destructured theviewClosedmethod from the castctx.appobject, which detaches it from its receiver and loses thethiscontext. The new code stores a reference to the object and callsviewClosedas a method, preservingthisbinding — consistent with howctx.app.action(...)andctx.app.view(...)are already called elsewhere in the same function.viewClosedfunction reference with method call onappWithViewClosedobjectthisbinding at runtimeviewClosedregistration pattern with the existingactionandviewregistration patternsConfidence Score: 5/5
this-binding issue with a minimal, well-scoped change.action()andview()in the same function. No new logic, no new dependencies, no behavioral changes beyond the binding fix.Last reviewed commit: de5e226