Skip to content

feat(ios): add Talk voice directive hint toggle#18250

Merged
mbelinky merged 3 commits intomainfrom
slice/ios-voice-directive-hint
Feb 16, 2026
Merged

feat(ios): add Talk voice directive hint toggle#18250
mbelinky merged 3 commits intomainfrom
slice/ios-voice-directive-hint

Conversation

@mbelinky
Copy link
Contributor

@mbelinky mbelinky commented Feb 16, 2026

Intent

Ship Slice 1 only: a low-risk toggle to control whether Talk Mode includes the ElevenLabs voice directive hint in the prompt.

Changes

  • add includeVoiceDirectiveHint parameter to TalkPromptBuilder.build(...) (default: true)
  • wire iOS Talk prompt builder call to read talk.voiceDirectiveHint.enabled
  • preserve existing behavior by defaulting missing preference to true
  • add Settings > Device > Features toggle: Voice Directive Hint
  • add unit tests for default-on and disabled behavior

Scope Guardrails

  • no background-audio lifecycle changes
  • no Talk/TTS pipeline refactor
  • no chat.push behavior changes

Validation

  • swift test --package-path apps/shared/OpenClawKit

Greptile Summary

Added an iOS-only feature toggle (talk.voiceDirectiveHint.enabled) to control whether the ElevenLabs voice directive hint is included in Talk Mode prompts. The implementation adds a new parameter to TalkPromptBuilder.build(...) with a safe default (true) that preserves existing behavior, wires it to iOS Settings UI, and includes comprehensive unit tests.

Key changes:

  • Added includeVoiceDirectiveHint parameter to TalkPromptBuilder.build(...) (defaults to true)
  • iOS TalkModeManager reads talk.voiceDirectiveHint.enabled preference (defaults to true if missing)
  • New Settings toggle: "Voice Directive Hint" under Device > Features
  • Unit tests verify both default-on and disabled behavior

Observations:

  • macOS TalkModeRuntime.swift:397 still calls TalkPromptBuilder.build(...) without the new parameter (relies on default). Consider whether macOS should also have this preference or if iOS-only is intentional per the PR scope.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are well-isolated, preserve backward compatibility via safe defaults, include comprehensive unit tests, and follow established patterns. The implementation correctly handles the missing preference case by defaulting to true, ensuring existing behavior is maintained. No logical errors, security issues, or breaking changes detected.
  • No files require special attention

Last reviewed commit: 93bf0cf

Attribution

@openclaw-barnacle openclaw-barnacle bot added app: ios App: ios size: XS maintainer Maintainer-authored PR labels Feb 16, 2026
@github-actions
Copy link

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

@github-actions
Copy link

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

@github-actions
Copy link

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

@mbelinky mbelinky merged commit ad27716 into main Feb 16, 2026
20 of 21 checks passed
@mbelinky mbelinky deleted the slice/ios-voice-directive-hint branch February 16, 2026 17:33
archerhpagent pushed a commit to howardpark/openclaw that referenced this pull request Feb 18, 2026
* feat(ios): add Talk voice directive hint toggle

* docs(changelog): credit voice directive hint slice

---------

Co-authored-by: Mariano Belinky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: ios App: ios maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments