fix(matrix): 2-member group rooms misclassified as DMs#17987
Closed
camopel wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(matrix): 2-member group rooms misclassified as DMs#17987camopel wants to merge 1 commit intoopenclaw:mainfrom
camopel wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Fixes #17771 Rooms explicitly listed in the groups allowlist config were still being classified as DMs when they had exactly 2 members, because the memberCount===2 heuristic in createDirectRoomTracker ran before checking the config. Pass the set of configured group room IDs into the direct room tracker and skip the DM check entirely for those rooms.
openclaw-barnacle
bot
added
channel: matrix
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+261
to
+263
| configuredGroupRoomIds: new Set( | ||
| roomsConfig ? Object.keys(roomsConfig).filter((k) => k !== "*") : [], | ||
| ), |
Contributor
There was a problem hiding this comment.
Alias-keyed rooms won't match at runtime
The roomsConfig keys can be room aliases (e.g., #openclaw:matrix.org) when the user configures them that way — these are kept as-is by the resolution logic at lines 155–157. However, isDirectMessage receives the internal room ID (!xxx:server) from the Matrix SDK, so configuredGroupRoomIds.has(roomId) will never match an alias-keyed entry.
This means the fix only works when the config contains !-prefixed internal room IDs or short names that get resolved via resolveMatrixTargets. Rooms configured by full alias (#name:server) will still be misclassified as DMs.
Consider filtering only !-prefixed keys, or resolving aliases to internal room IDs before building this set.
Prompt To Fix With AI
This is a comment left during a code review.
Path: extensions/matrix/src/matrix/monitor/index.ts
Line: 261:263
Comment:
**Alias-keyed rooms won't match at runtime**
The `roomsConfig` keys can be room aliases (e.g., `#openclaw:matrix.org`) when the user configures them that way — these are kept as-is by the resolution logic at lines 155–157. However, `isDirectMessage` receives the internal room ID (`!xxx:server`) from the Matrix SDK, so `configuredGroupRoomIds.has(roomId)` will never match an alias-keyed entry.
This means the fix only works when the config contains `!`-prefixed internal room IDs or short names that get resolved via `resolveMatrixTargets`. Rooms configured by full alias (`#name:server`) will still be misclassified as DMs.
Consider filtering only `!`-prefixed keys, or resolving aliases to internal room IDs before building this set.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17771
Problem
Matrix rooms with exactly 2 members that are explicitly configured in the
groupsallowlist get misclassified as DMs. This happens becausecreateDirectRoomTrackeruses amemberCount === 2heuristic that runs before any config awareness — so a 2-person group channel gets routed as a DM session instead of a group session.Fix
Pass the set of configured group room IDs (from
channels.matrix.groups) intocreateDirectRoomTracker. If a room ID is in that set, skip the DM classification entirely and returnfalseimmediately.Changes
extensions/matrix/src/matrix/monitor/direct.ts— accept optionalconfiguredGroupRoomIdsset in options; check it as the first guard inisDirectMessage()extensions/matrix/src/matrix/monitor/index.ts— collect room IDs fromroomsConfig(excluding the"*"wildcard) and pass them to the trackerTesting
Tested with a 2-member Matrix room (
#openclaw) in the groups config — correctly classified as group after the patch, was incorrectly classified as DM before.Greptile Summary
This PR fixes a bug where 2-member Matrix group rooms configured in
channels.matrix.groupsare incorrectly classified as DMs by thememberCount === 2heuristic increateDirectRoomTracker. The fix passes a set of configured group room IDs into the tracker so they can be excluded from DM classification as the first check.configuredGroupRoomIdsset is built fromObject.keys(roomsConfig), but after resolution these keys can be room aliases (#name:server) rather than internal room IDs (!xxx:server). Since the Matrix SDK always provides internal!-prefixed room IDs toisDirectMessage, alias-keyed rooms won't match and will still be misclassifiedresolveMatrixTargets)Confidence Score: 3/5
extensions/matrix/src/matrix/monitor/index.ts— theconfiguredGroupRoomIdsset construction needs to account for alias keys vs. internal room IDsLast reviewed commit: cb50d35
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!