fix(discord): honor proxy for app-id and allowlist REST resolution#17958
Merged
steipete merged 2 commits intoopenclaw:mainfrom Feb 16, 2026
Merged
fix(discord): honor proxy for app-id and allowlist REST resolution#17958steipete merged 2 commits intoopenclaw:mainfrom
steipete merged 2 commits intoopenclaw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
channels.discord.proxyto Discord REST calls made during monitor startupWhy
In restricted networks, gateway proxy could be enabled while startup REST calls still used direct network access, causing:
Failed to resolve Discord application idThis change makes startup behavior consistent with proxy configuration.
Testing
pnpm vitest run --config vitest.unit.config.ts src/discord/monitor/provider.rest-proxy.test.ts src/discord/monitor/provider.proxy.test.ts src/discord/monitor/provider.skill-dedupe.test.tsGreptile Summary
Routes Discord startup REST calls (application-id lookup and allowlist resolution) through the same proxy configured via
channels.discord.proxy, fixing failures in restricted networks where the gateway proxy was enabled but REST calls used direct access.resolveDiscordRestFetch()inprovider.tsusingundici.ProxyAgent— mirrors the established pattern insrc/telegram/proxy.tsresolveDiscordChannelAllowlist,resolveDiscordUserAllowlist, andfetchDiscordApplicationIdfetchon invalid proxy URLs with error loggingConfidence Score: 5/5
src/telegram/proxy.ts. The newresolveDiscordRestFetchfunction mirrorsmakeProxyFetch, the type casting is identical, and the error-handling fallback is robust. All three call sites (fetchDiscordApplicationId,resolveDiscordChannelAllowlist,resolveDiscordUserAllowlist) already accept an optionalfetcherparameter, so the plumbing is seamless. The help text update is accurate. Tests cover both the happy path and error fallback.Last reviewed commit: 6043f56
(2/5) Greptile learns from your feedback when you react with thumbs up/down!