fix: filter error payloads from user-facing messages#17950
Closed
Suksham-sharma wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix: filter error payloads from user-facing messages#17950Suksham-sharma wants to merge 1 commit intoopenclaw:mainfrom
Suksham-sharma wants to merge 1 commit intoopenclaw:mainfrom
Conversation
isRenderablePayload did not check the isError flag, causing internal error results (context overflow, tool failures, role ordering conflicts) to leak to users on all messaging channels. These errors are meant to stay in the agent context for self-correction, not be delivered. Add tests for isRenderablePayload covering all payload types and the isError filtering behavior. Fixes openclaw#17828
|
This pull request has been automatically marked as stale due to inactivity. |
Contributor
Author
|
are there any updates that are required ? |
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isRenderablePayload()did not check theisErrorflag on payloadsChanges
isRenderablePayload()whenpayload.isErroris trueisRenderablePayloadcovering all payload types and the isError filteringFixes #17828
Greptile Summary
Prevents internal error messages from being sent to end users by filtering out error payloads. The fix adds an early return in
isRenderablePayload()to check theisErrorflag, ensuring that context overflow errors, tool failures, and role ordering conflicts stay in the agent context for self-correction rather than being delivered on messaging channels.Confidence Score: 5/5
Last reviewed commit: b981813