Skip to content

fix: filter error payloads from user-facing messages#17950

Closed
Suksham-sharma wants to merge 1 commit intoopenclaw:mainfrom
Suksham-sharma:fix/filter-error-payloads-from-user
Closed

fix: filter error payloads from user-facing messages#17950
Suksham-sharma wants to merge 1 commit intoopenclaw:mainfrom
Suksham-sharma:fix/filter-error-payloads-from-user

Conversation

@Suksham-sharma
Copy link
Copy Markdown
Contributor

@Suksham-sharma Suksham-sharma commented Feb 16, 2026

Summary

  • isRenderablePayload() did not check the isError flag on payloads
  • Internal error results (context overflow, tool failures, role ordering conflicts) were being sent to users on all messaging channels
  • These errors are meant to stay in the agent context for self-correction, not be delivered to end users

Changes

  • Added early return in isRenderablePayload() when payload.isError is true
  • Added test coverage for isRenderablePayload covering all payload types and the isError filtering

Fixes #17828

Greptile Summary

Prevents internal error messages from being sent to end users by filtering out error payloads. The fix adds an early return in isRenderablePayload() to check the isError flag, ensuring that context overflow errors, tool failures, and role ordering conflicts stay in the agent context for self-correction rather than being delivered on messaging channels.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The fix is a simple, well-tested guard clause that prevents a clear bug (error messages leaking to users). The change is minimal, isolated to a single function, and includes comprehensive test coverage. No edge cases or regressions identified.
  • No files require special attention

Last reviewed commit: b981813

isRenderablePayload did not check the isError flag, causing internal
error results (context overflow, tool failures, role ordering conflicts)
to leak to users on all messaging channels. These errors are meant to
stay in the agent context for self-correction, not be delivered.

Add tests for isRenderablePayload covering all payload types and
the isError filtering behavior.

Fixes openclaw#17828
@openclaw-barnacle
Copy link
Copy Markdown

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

@openclaw-barnacle openclaw-barnacle bot added the stale Marked as stale due to inactivity label Feb 22, 2026
@Suksham-sharma
Copy link
Copy Markdown
Contributor Author

are there any updates that are required ?

@openclaw-barnacle openclaw-barnacle bot removed the stale Marked as stale due to inactivity label Feb 23, 2026
@openclaw-barnacle
Copy link
Copy Markdown

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

@openclaw-barnacle openclaw-barnacle bot added the stale Marked as stale due to inactivity label Mar 15, 2026
@openclaw-barnacle
Copy link
Copy Markdown

Closing due to inactivity.
If you believe this PR should be revived, post in #pr-thunderdome-dangerzone on Discord to talk to a maintainer.
That channel is the escape hatch for high-quality PRs that get auto-closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS stale Marked as stale due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Tool error results (isError: true) leak to user as messages

2 participants