cron: separate webhook POST delivery from announce by advaitpaliwal · Pull Request #17901 · openclaw/openclaw

advaitpaliwal · 2026-02-16T08:49:06Z

Summary

Describe the problem and fix in 2–5 bullets:

Problem: cron used notify: true + global cron.webhook for webhook POSTs, while delivery.mode="announce" handled channel delivery; this split caused confusion and duplicated concepts.
Why it matters: webhook POST and channel announce are different transport paths, and users need per-job webhook URLs.
What changed: added delivery.mode="webhook" (with delivery.to as URL), removed notify from cron job schema/types/UI/tool docs, and kept a legacy fallback for old notify jobs via cron.webhook.
What did NOT change (scope boundary): channel announce behavior (delivery.mode="announce") and isolated-run delivery mechanics remain unchanged.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related Gateway/Control UI: preserve partial output on abort #15026

User-visible / Behavior Changes

Cron jobs now support delivery.mode: "webhook" + delivery.to: "https://..." for finished-run webhook POST delivery.
delivery.mode: "announce" remains channel delivery only.
Cron job notify is removed from add/update/list contracts and Control UI form.
cron.webhook is now documented/used as a legacy fallback only for older jobs that still contain notify: true.

Security Impact (required)

New permissions/capabilities? (No)
Secrets/tokens handling changed? (No)
New/changed network calls? (Yes)
Command/tool execution surface changed? (No)
Data access scope changed? (No)
If any Yes, explain risk + mitigation:
- Risk: user-provided webhook URL can fail/timeout.
- Mitigation: existing 10s timeout + error logging remains; cron.webhookToken can be used for auth.

Repro + Verification

Environment

OS: macOS
Runtime/container: Node 22 + pnpm
Model/provider: N/A
Integration/channel (if any): Gateway cron + Control UI
Relevant config (redacted): optional cron.webhookToken

Steps

Create cron job with delivery.mode="webhook" and delivery.to URL.
Force-run the job.
Confirm webhook POST payload is emitted only for webhook-mode jobs with summary.

Expected

Webhook jobs POST finished event payload to delivery.to.
Non-webhook jobs do not POST.
Announce mode remains channel delivery behavior.

Actual

Matches expected.

Evidence

Attach at least one:

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios:
- webhook-mode finished POST for main and isolated cron jobs.
- announce-mode and none-mode behavior unchanged in delivery planner/UI rendering.
- protocol/UI/Swift delivery mode conformance includes webhook.
Edge cases checked:
- no-summary run does not POST.
- legacy notify fallback still posts via cron.webhook when present in stored jobs.
What you did not verify:
- full end-to-end manual webhook receiver outside test mocks.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly:
- set cron job delivery to none or remove webhook delivery fields.
- rollback to previous commit.
Files/config to restore:
- src/cron/*, src/gateway/server-cron.ts, src/gateway/protocol/schema/cron.ts, ui/src/ui/*.
Known bad symptoms reviewers should watch for:
- missing webhook POSTs when delivery.mode="webhook" is set.

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

Risk: existing automation may still set notify in add/update payloads.
- Mitigation: legacy store fallback remains for persisted jobs; docs/UI/tool schema now steer to delivery webhook mode.

Greptile Summary

Separates webhook POST delivery from channel announce delivery by adding delivery.mode="webhook" with delivery.to URL support, removing the deprecated notify field from the cron job schema, and maintaining backward compatibility for legacy jobs via cron.webhook fallback.

Key changes:

Added "webhook" as a new CronDeliveryMode alongside "announce" and "none"
Webhook mode now explicitly requires delivery.to URL instead of relying on global cron.webhook + notify flag
Removed notify field from protocol schema, UI forms, tool documentation, and type definitions
Legacy fallback preserved: stored jobs with notify: true continue to POST via cron.webhook config
Updated assertDeliverySupport to allow webhook mode for both main and isolated session targets, while restricting announce mode to isolated only
Channel routing (delivery.channel) correctly excluded for webhook mode
Documentation and UI updated to reflect webhook as a delivery mode rather than a separate notification mechanism

Confidence Score: 4/5

Safe to merge with minor attention to edge case handling
The refactor is well-structured with comprehensive test coverage, proper backward compatibility via legacy fallback, and clean separation of concerns. The score of 4 (not 5) reflects one edge case: webhook mode with missing URL returns null but doesn't fail fast at job creation time, which could lead to silent failures at runtime.
Review src/gateway/server-cron.ts:41-42 for webhook URL validation - consider adding validation at job creation time rather than silently returning null at runtime

_{Last reviewed commit: 9c549c6}

greptile-apps

_{25 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-16T08:52:07Z

src/gateway/server-cron.ts

+    const url = params.delivery?.to?.trim();
+    return url ? url : null;


webhook mode with empty/missing URL returns null silently at runtime rather than failing at job creation

This allows invalid webhook jobs to be created but fail silently when they run. Consider adding validation in src/cron/service/jobs.ts createJob or applyJobPatch to reject delivery.mode="webhook" when delivery.to is missing/empty.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/gateway/server-cron.ts Line: 41:42 Comment: webhook mode with empty/missing URL returns `null` silently at runtime rather than failing at job creation This allows invalid webhook jobs to be created but fail silently when they run. Consider adding validation in `src/cron/service/jobs.ts` `createJob` or `applyJobPatch` to reject `delivery.mode="webhook"` when `delivery.to` is missing/empty. How can I resolve this? If you propose a fix, please make it concise.

…vaitpaliwal

…vaitpaliwal)

tyler6204 · 2026-02-16T10:42:37Z

Merged via squash.

Merge commit: bc67af6

Thanks @advaitpaliwal!

@advaitpaliwal