fix(discord): preserve channel session keys via channel_id fallbacks by shakkernerd · Pull Request #17622 · openclaw/openclaw

shakkernerd · 2026-02-16T00:58:11Z

Summary

This is a focused first-pass fix for Discord session continuity issues reported in #16333 and #16979.

Added canonical Discord channel ID resolution that falls back in order:
- message.channelId
- message.channel_id
- message.rawData.channel_id
- event payload channel_id
Threaded that canonical messageChannelId through Discord preflight and processing so routing/session/history/reply paths no longer depend on a single runtime field shape.
Updated Discord threading + auto-thread paths to use the same canonical channel ID for thread/session context and API calls.
Updated route ID normalization to safely coerce runtime number/bigint IDs into stable string IDs for session keys.
Updated diagnostic state correlation so session state keyed by sessionKey is reused when later looked up by sessionId, and PI embedded runner now emits session state transitions with sessionKey where available.
Added targeted regression tests for channel-id fallback resolution, process-path channel-id fallback behavior, route numeric-id coercion, and diagnostic state reuse.

Verification

bunx vitest run --config vitest.unit.config.ts src/discord/monitor/message-utils.test.ts src/discord/monitor/message-handler.process.test.ts src/logging/diagnostic.test.ts src/routing/resolve-route.test.ts
bunx vitest run --config vitest.unit.config.ts src/discord/monitor/message-handler.inbound-contract.test.ts src/discord/monitor/monitor.test.ts
pnpm tsgo
pnpm check

This PR fixes Discord session continuity by implementing canonical channel ID resolution with multiple fallbacks (message.channelId → message.channel_id → message.rawData.channel_id → event payload channel_id). The changes thread this messageChannelId through preflight, processing, threading, and auto-thread creation paths to ensure consistent session keys regardless of runtime field shape variations.

Key improvements:

Added resolveDiscordMessageChannelId() helper with numeric type coercion support
Updated normalizeId() in route resolution to handle number/bigint types for stable session keys
Enhanced diagnostic session state correlation to reuse state keyed by sessionKey when looked up by sessionId
Updated Pi embedded runner to emit session state transitions with sessionKey where available
Added comprehensive regression tests covering fallback resolution, numeric ID coercion, and state reuse

The implementation is solid with proper type handling and fallback chains. Test coverage is strong across the critical paths.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The changes are well-structured with clear intent to fix session continuity issues. The implementation adds proper fallback chains without breaking existing logic, includes comprehensive test coverage for the new behavior, and maintains backward compatibility. The type handling for numeric IDs is correct, and the threading of messageChannelId through all paths is systematic and complete.
No files require special attention

_{Last reviewed commit: b8b2805}

greptile-apps

_{15 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-16T01:01:43Z

src/discord/monitor/message-utils.test.ts

+  it("falls back to message.rawData.channel_id", () => {
+    const channelId = resolveDiscordMessageChannelId({
+      message: asMessage({ rawData: { channel_id: "456" } }),
+    });
+    expect(channelId).toBe("456");
+  });


missing test case for message.channel_id fallback (the second fallback in the chain)

Prompt To Fix With AI

This is a comment left during a code review. Path: src/discord/monitor/message-utils.test.ts Line: 17:22 Comment: missing test case for `message.channel_id` fallback (the second fallback in the chain) How can I resolve this? If you propose a fix, please make it concise.

github-actions · 2026-02-16T01:05:26Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

github-actions · 2026-02-16T01:39:19Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

github-actions · 2026-02-16T02:01:30Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

github-actions · 2026-02-16T02:35:59Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

…penclaw#17622) * fix(discord): preserve channel session keys via channel_id fallbacks * docs(changelog): add discord session continuity note * Tests: cover discord channel_id fallback --------- Co-authored-by: Shadow <[email protected]>

greptile-apps bot reviewed Feb 16, 2026

View reviewed changes

thewilloftheshadow self-assigned this Feb 16, 2026

thewilloftheshadow added the channel: discord Channel integration: discord label Feb 16, 2026

openclaw-barnacle bot added agents Agent runtime and tooling size: M maintainer Maintainer-authored PR labels Feb 16, 2026

shakkernerd and others added 3 commits February 15, 2026 20:23

fix(discord): preserve channel session keys via channel_id fallbacks

622a25c

docs(changelog): add discord session continuity note

c655ae3

Tests: cover discord channel_id fallback

8d3fd4b

thewilloftheshadow force-pushed the fix/discord-session-key-continuity branch from 5056113 to 8d3fd4b Compare February 16, 2026 02:24

thewilloftheshadow merged commit 09566b1 into main Feb 16, 2026
10 checks passed

thewilloftheshadow deleted the fix/discord-session-key-continuity branch February 16, 2026 02:30

This was referenced Feb 16, 2026

Discord sessions not persisting - new session ID per message in same channel #16333

Closed

Discord channel session history lost after Gateway restart #16979

Closed

nathankjer mentioned this pull request Feb 18, 2026

[Bug]: Group/channel Discord sessions get new sessionId on every incoming message (Windows) #17520

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(discord): preserve channel session keys via channel_id fallbacks#17622

fix(discord): preserve channel session keys via channel_id fallbacks#17622
thewilloftheshadow merged 3 commits intomainfrom
fix/discord-session-key-continuity

shakkernerd commented Feb 16, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

shakkernerd commented Feb 16, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Related

Greptile Summary

Confidence Score: 5/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

shakkernerd commented Feb 16, 2026 •

edited by greptile-apps bot

Loading