feat(config): tools.alsoAllow additive allowlist#1742
Merged
shakkernerd merged 7 commits intomainfrom Jan 26, 2026
Merged
Conversation
Contributor
Author
|
@steipete this solves a hiccup with optional tools that explicitly need opt-in. For people who don't use allow lists to opt into tools. Will increase llm-task and lobster adoption. |
Member
|
Hey @vignesh07 can you resolve conflicts please. This is a good PR to get in. |
vignesh07
force-pushed
the
feat/tools-alsoAllow
branch
from
3ecbf6d to
3497be2
Compare
Contributor
Author
|
@shakkernerd fixed conflicts. However I think it can be improved a bit by adding stricter expectations. Will send one more commit in. |
Contributor
Author
|
@shakkernerd good to go. Feel free to change things around before merging. |
5 tasks
Member
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tools.allow = ["lobster"].allowis restrictive, that accidentally disables every other tool.Solution
alsoAllow?: string[]to tool policy configs (global tools, agent tools, group tools, byProvider tool policies).alsoAllowis merged additively into the effective allowlist.Behavior
alsoAllowunions into it.allowlist is present,alsoAllowunions into that.alsoAllowis set, treat it as additive on top of an implicit allow-all policy (equivalent toallow: ["*", ...alsoAllow]).UX / Guidance
tools.alsoAllow: ["lobster"]instead oftools.allow: ["lobster"].Tests
tools.profile=minimal+tools.alsoAllow=["sessions_list"]allows invokingsessions_list.tools.alsoAllow=["sessions_list"]works even when no allow/profile is set (implicit allow-all).CLAWDBOT_GATEWAY_TOKEN/CLAWDBOT_GATEWAY_PASSWORDinbeforeEach.