fix(voice-call): validate provider credentials from env vars#1724
Merged
shakkernerd merged 2 commits intoopenclaw:mainfrom Jan 26, 2026
Merged
fix(voice-call): validate provider credentials from env vars#1724shakkernerd merged 2 commits intoopenclaw:mainfrom
shakkernerd merged 2 commits intoopenclaw:mainfrom
Conversation
The `validateProviderConfig()` function now checks both config values AND environment variables when validating provider credentials. This aligns the validation behavior with `resolveProvider()` which already falls back to env vars. Previously, users who set credentials via environment variables would get validation errors even though the credentials would be found at runtime. The error messages correctly suggested env vars as an alternative, but the validation didn't actually check them. Affects all three supported providers: Twilio, Telnyx, and Plivo. Fixes openclaw#1709 Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1709
The
validateProviderConfig()function now checks both config values AND environment variables when validating provider credentials. This aligns the validation behavior withresolveProvider()which already falls back to env vars.Problem
Previously, users who set credentials via environment variables would get validation errors like:
The error message suggested env vars work, but the validation didn't actually check them. The credentials would only be found later in
resolveProvider(), which does check env vars.Changes
validateProviderConfig()to check both config and env vars for all three providers:TWILIO_ACCOUNT_SID,TWILIO_AUTH_TOKENTELNYX_API_KEY,TELNYX_CONNECTION_IDPLIVO_AUTH_ID,PLIVO_AUTH_TOKENTest Plan
🤖 Generated with Claude Code (issue-hunter-pro)