fix: add memory search health check to openclaw doctor#16294
Merged
Takhoffman merged 2 commits intoFeb 14, 2026
Conversation
| // Remote/downloadable models (hf: or http:) aren't pre-resolved on disk, | ||
| // so we can't confirm availability without a network call. Treat as | ||
| // potentially available — the user configured it intentionally. | ||
| if (/^(hf:|https?:)/i.test(modelPath)) { |
Contributor
There was a problem hiding this comment.
regex allows both http: and https: but the comment only mentions http:, update comment to include both
Suggested change
| if (/^(hf:|https?:)/i.test(modelPath)) { | |
| // Remote/downloadable models (hf: or http:/https:) aren't pre-resolved on disk, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/commands/doctor-memory-search.ts
Line: 100:100
Comment:
regex allows both `http:` and `https:` but the comment only mentions `http:`, update comment to include both
```suggestion
// Remote/downloadable models (hf: or http:/https:) aren't pre-resolved on disk,
```
How can I resolve this? If you propose a fix, please make it concise.When memory search is enabled but no embedding provider is configured, openclaw doctor now warns with actionable fix suggestions instead of letting users discover the misconfiguration through silent recall failures. Closes #13027 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Takhoffman
force-pushed
the
fix/doctor-memory-search-warning
branch
from
February 14, 2026 17:01
d871c04 to
7c4e955
Compare
Contributor
|
PR #16294 - fix: add memory search health check to openclaw doctor (#16294) Merged via squash.
Thanks @superlowburn! |
akoscz
pushed a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
… thanks @superlowburn Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test (noted unrelated local flakes) Co-authored-by: superlowburn <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
GwonHyeok
pushed a commit
to learners-superpumped/openclaw
that referenced
this pull request
Feb 15, 2026
… thanks @superlowburn Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test (noted unrelated local flakes) Co-authored-by: superlowburn <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
Twynzen
pushed a commit
to Twynzen/sendell-clawd
that referenced
this pull request
Feb 15, 2026
… thanks @superlowburn Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test (noted unrelated local flakes) Co-authored-by: superlowburn <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
6 tasks
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 1, 2026
… thanks @superlowburn Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test (noted unrelated local flakes) Co-authored-by: superlowburn <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 69ba9a0)
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 3, 2026
… thanks @superlowburn Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test (noted unrelated local flakes) Co-authored-by: superlowburn <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 69ba9a0)
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
… thanks @superlowburn Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test (noted unrelated local flakes) Co-authored-by: superlowburn <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
… thanks @superlowburn Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test (noted unrelated local flakes) Co-authored-by: superlowburn <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
… thanks @superlowburn Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test (noted unrelated local flakes) Co-authored-by: superlowburn <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
This was referenced Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noteMemorySearchHealth()check toopenclaw doctorthat detects when memory search is enabled but no embedding provider is configuredresolveApiKeyForProvider()and local model path checksWhat it checks
The new check handles 4 scenarios:
enabled: false) — brief info note, not a warninglocalbut no model file found — suggests configuring local model or switching to remoteopenclaw auth addauto(default) and no provider available — generic guidance listing all fix optionsEach note ends with
openclaw memory status --deepas the verify command.Why
Users expect persistent memory to work after setup, but without an embeddings provider configured, memory search silently fails. Users blame "AI forgot" when really they need to configure an embedding provider. This check surfaces the issue during
openclaw doctorwith specific, actionable fix guidance.Design decisions
memory status --deepalready does runtime probingresolveApiKeyForProvider()— same resolution path as the embedding system (checks config profiles, keychain, env vars, config file), avoiding false positives from only checking env varsenabled: false, shows a brief note rather than a warningdoctor-security.ts(builds message, callsnote())Scope
This PR addresses the
openclaw doctorportion of #13027. Onboarding wizard enhancements and runtime warnings mentioned in the issue are left as future work.Test plan
openclaw doctorwithout any API keys configured — verify warning appearsopenclaw doctorwith OPENAI_API_KEY set — verify no warningagents.defaults.memorySearch.enabled: false— verify info note appearsCloses #13027
🤖 Generated with Claude Code
Greptile Overview
Greptile Summary
Adds a new health check to
openclaw doctorthat detects misconfigured memory search embeddings providers and displays actionable fix suggestions. The implementation follows existing doctor check patterns, uses config-only detection (no network calls), and handles all major scenarios: explicitly disabled memory search, local models (missing files), specific remote providers (missing API keys), and auto-detection fallback. The code correctly integrates with existing auth resolution logic and provides clear, specific guidance for each failure mode.Confidence Score: 5/5
Last reviewed commit: d871c04