Skip to content

Comments

revert: undo #12027 heartbeat bootstrap behavior#16183

Merged
Takhoffman merged 1 commit intomainfrom
tak/revert-pr-12027
Feb 14, 2026
Merged

revert: undo #12027 heartbeat bootstrap behavior#16183
Takhoffman merged 1 commit intomainfrom
tak/revert-pr-12027

Conversation

@Takhoffman
Copy link
Contributor

@Takhoffman Takhoffman commented Feb 14, 2026

Summary

Verification

  • pnpm test src/agents/workspace.e2e.test.ts (fails because repo test config excludes *.e2e.test.ts)
  • pnpm check (currently fails on existing src/gateway/tools-invoke-http.ts TypeScript errors on main)

Greptile Overview

Greptile Summary

This PR reverts commit 386bb0c6 from #12027, restoring the original ensureAgentWorkspace behavior that auto-creates HEARTBEAT.md during workspace initialization.

Key changes:

  • Restores heartbeatPath parameter in the return type of ensureAgentWorkspace
  • Re-enables loading and writing the HEARTBEAT.md template during bootstrap
  • Includes heartbeatPath in the isBrandNewWorkspace check
  • Removes the test that verified HEARTBEAT.md was NOT created
  • Removes the changelog entry from fix: don't auto-create HEARTBEAT.md on workspace init #12027

The template content (after frontmatter stripping) contains only markdown headers/comments, making it "effectively empty" per isHeartbeatContentEffectivelyEmpty(), so heartbeat API calls will still be skipped as intended. This revert appears to restore the correct default behavior where users get a documented template file with instructions.

Confidence Score: 5/5

  • This PR is safe to merge - it's a clean revert that restores tested, documented behavior
  • This is a straightforward revert of a recent commit that restores the previous workspace initialization behavior. The changes are minimal, well-contained, and restore documented functionality. The template that gets written is effectively empty (only contains markdown headers/comments), so the heartbeat will be correctly skipped until users add actual tasks. The revert properly undoes all aspects of the original PR including code changes, tests, and changelog entries.
  • No files require special attention

Last reviewed commit: cd52355

@openclaw-barnacle openclaw-barnacle bot added agents Agent runtime and tooling size: XS maintainer Maintainer-authored PR labels Feb 14, 2026
@Takhoffman
Copy link
Contributor Author

Updating rationale for this revert:

HEARTBEAT.md needs to exist on workspace init because it is part of onboarding behavior. This PR intentionally restores the previous bootstrap behavior so onboarding remains consistent.

I updated the PR body to reflect this reasoning.

@Takhoffman Takhoffman merged commit 274da72 into main Feb 14, 2026
23 of 24 checks passed
@Takhoffman Takhoffman deleted the tak/revert-pr-12027 branch February 14, 2026 12:33
hamidzr pushed a commit to hamidzr/openclaw that referenced this pull request Feb 14, 2026
openperf pushed a commit to openperf/moltbot that referenced this pull request Feb 14, 2026
openperf pushed a commit to openperf/moltbot that referenced this pull request Feb 14, 2026
BigUncle pushed a commit to BigUncle/openclaw that referenced this pull request Feb 14, 2026
mverrilli pushed a commit to mverrilli/openclaw that referenced this pull request Feb 14, 2026
GwonHyeok pushed a commit to learners-superpumped/openclaw that referenced this pull request Feb 15, 2026
Benkei-dev pushed a commit to Benkei-dev/openclaw that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant