fix(whatsapp): preserve outbound document filenames by TsekaLuk · Pull Request #15594 · openclaw/openclaw

TsekaLuk · 2026-02-13T17:07:19Z

Summary

pass the resolved media filename through WhatsApp outbound send options
use sendOptions.fileName for document payloads instead of hardcoding "file"
keep backward compatibility by falling back to "file" when filename is absent

Why

Outbound WhatsApp documents currently always appear as file on the receiver side because filename is hardcoded in createWebSendApi().

Changes

src/web/outbound.ts: capture document media.fileName and include it in ActiveWebSendOptions
src/web/active-listener.ts: add optional fileName to ActiveWebSendOptions
src/web/inbound/send-api.ts: use sendOptions?.fileName?.trim() || "file" for document payloads
src/web/outbound.test.ts: assert filename is propagated for document sends
src/web/inbound/send-api.test.ts (new): verify both propagated filename and default fallback behavior

Fixes #15560

Validation

pnpm check
pnpm build
pnpm vitest run src/web/outbound.test.ts src/web/inbound/send-api.test.ts
pnpm test:fast (fails on existing unrelated src/security/audit.test.ts assertion in local skill-scan fixture; unchanged by this PR)

Greptile Overview

Greptile Summary

This PR threads a resolved media filename from WhatsApp outbound media loading into the active web send options, and updates the inbound send API to use that filename for document payloads (falling back to "file" when absent). Tests were updated/added to assert filename propagation and default behavior.

One blocking issue: the new src/web/inbound/send-api.test.ts mocks recordChannelActivity using an incorrect relative path, so the mock won’t apply (and may fail module resolution). Fixing the mock path should make the new tests reliable.

Confidence Score: 4/5

Mostly safe to merge once the new test’s broken mock path is fixed.
The runtime change is small and well-covered by tests, but the added test currently mocks a non-existent module path and won’t reliably stub the dependency used by the code under test, which is a merge blocker for CI.
src/web/inbound/send-api.test.ts

_{Last reviewed commit: e1f7784}

greptile-apps

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-13T17:08:59Z

src/web/inbound/send-api.test.ts

+vi.mock("../../infra/channel-activity.js", () => ({
+  recordChannelActivity: (...args: unknown[]) => recordChannelActivity(...args),
+}));


Broken mock import path

send-api.ts imports recordChannelActivity from "../../infra/channel-activity.js" (relative to src/web/inbound/send-api.ts), but this test mocks "../../infra/channel-activity.js" relative to src/web/inbound/send-api.test.ts, which resolves to src/web/infra/channel-activity.js (non-existent) and won’t stub the real dependency. This will either throw during module resolution or cause the real recordChannelActivity to run.

Suggested change

vi.mock("../../infra/channel-activity.js", () => ({

recordChannelActivity: (...args: unknown[]) => recordChannelActivity(...args),

}));

vi.mock("../../../infra/channel-activity.js", () => ({

recordChannelActivity: (...args: unknown[]) => recordChannelActivity(...args),

}));

Prompt To Fix With AI

This is a comment left during a code review. Path: src/web/inbound/send-api.test.ts Line: 4:6 Comment: **Broken mock import path** `send-api.ts` imports `recordChannelActivity` from `"../../infra/channel-activity.js"` (relative to `src/web/inbound/send-api.ts`), but this test mocks `"../../infra/channel-activity.js"` relative to `src/web/inbound/send-api.test.ts`, which resolves to `src/web/infra/channel-activity.js` (non-existent) and won’t stub the real dependency. This will either throw during module resolution or cause the real `recordChannelActivity` to run. ```suggestion vi.mock("../../../infra/channel-activity.js", () => ({ recordChannelActivity: (...args: unknown[]) => recordChannelActivity(...args), })); ``` How can I resolve this? If you propose a fix, please make it concise.

TsekaLuk · 2026-02-13T17:12:06Z

Addressed, thanks. Updated the mock path to in and pushed commit f34019f.

TsekaLuk · 2026-02-13T17:12:20Z

Follow-up with exact details:

Updated mock path to ../../../infra/channel-activity.js
File: src/web/inbound/send-api.test.ts
Commit: f34019f

TsekaLuk · 2026-02-13T17:22:09Z

I investigated the current check failure on this PR.

The failing error is:

eslint(no-control-regex) at src/gateway/server/ws-connection.ts:22

I reproduced it by running pnpm check on refs/pull/15594/merge. This file is from the current base branch merge result, not from the WhatsApp filename changes in this PR.

I will re-run/refresh once the base-branch lint issue is resolved, and keep this PR branch updated.

TsekaLuk · 2026-02-13T17:24:29Z

Follow-up: I opened a focused base-fix PR for the lint regression here: #15610.\n\nIf that merges, this PR's should stop failing for the external blocker.

TsekaLuk · 2026-02-13T17:24:42Z

Correction with exact text:

external blocker is CI check
failing lint: eslint(no-control-regex)
file path: src/gateway/server/ws-connection.ts

Tracked/fixed in #15610.

TsekaLuk · 2026-02-13T17:31:44Z

Applied the baseline lint fix directly to this branch.

New commit: 6a427c857

fixes eslint(no-control-regex) in src/gateway/server/ws-connection.ts
keeps branch pnpm check green locally

This should unblock the check job from the shared base-branch failure mode.

TsekaLuk · 2026-02-13T17:35:39Z

Rebased this branch onto latest main and force-pushed to clear merge conflicts.

Current head: 63912bd76
Status now shows mergeable=MERGEABLE; CI has restarted.

…TsekaLuk

…TsekaLuk

@TsekaLuk

…w#15594) thanks @TsekaLuk

TsekaLuk · 2026-02-13T17:50:22Z

Hey! 👋 CI is all green on this one. Would you have time to take a look? Happy to make changes if needed. Thanks!

…TsekaLuk

…TsekaLuk

@TsekaLuk

…w#15594) thanks @TsekaLuk

…TsekaLuk

…TsekaLuk

@TsekaLuk

…w#15594) thanks @TsekaLuk

steipete · 2026-02-13T17:54:14Z

Merged via squash.

Prepared head SHA: 8e0d765
Merge commit: c544811

Thanks @TsekaLuk!

@steipete