Skip to content

openai-codex: add gpt-5.3-codex-spark forward-compat model#15174

Merged
mbelinky merged 3 commits intoopenclaw:mainfrom
loiie45e:fix/codex-spark-forward-compat
Feb 13, 2026
Merged

openai-codex: add gpt-5.3-codex-spark forward-compat model#15174
mbelinky merged 3 commits intoopenclaw:mainfrom
loiie45e:fix/codex-spark-forward-compat

Conversation

@loiie45e
Copy link
Contributor

@loiie45e loiie45e commented Feb 13, 2026 •
edited by greptile-apps bot
Loading

Problem

openai-codex/gpt-5.3-codex-spark can be available in Codex (and works via Codex CLI), but OpenClaw can currently reject it as Unknown model because it is not yet present in the discovered model registry (often showing as configured,missing). This can crash runs when the model is selected.

What this PR changes

  • Treat gpt-5.3-codex-spark as a forward-compatible OpenAI Codex model id (same bucket as gpt-5.3-codex).
  • If the model registry does not include the id, build a fallback model by cloning the existing gpt-5.2-codex template. This preserves critical OpenClaw Codex wiring (notably api: openai-codex-responses and the Codex baseUrl), and avoids immediate Unknown model errors.
  • Include gpt-5.3-codex-spark in the Codex allowlist used by live model filtering.

Why template-clone from gpt-5.2-codex

OpenClaw already uses template cloning as a forward-compat strategy for new model ids where the provider transport is unchanged. gpt-5.2-codex is the closest known-good Codex template and ensures we keep the Codex-specific API/endpoint behavior rather than falling back to a generic OpenAI provider config.

Tests

  • Added unit test coverage for resolving openai-codex/gpt-5.3-codex-spark via the forward-compat fallback path (template from gpt-5.2-codex).
  • Local run: npx vitest run src/agents/pi-embedded-runner/model.test.ts

Greptile Overview

Greptile Summary

This PR adds forward-compat support for the OpenAI Codex model id gpt-5.3-codex-spark.

  • src/agents/pi-embedded-runner/model.ts extends the existing Codex forward-compat fallback so that when openai-codex/gpt-5.3-codex-spark is requested but missing from the discovered model registry, OpenClaw clones the gpt-5.2-codex template (preserving api/baseUrl/contextWindow/maxTokens) to avoid an Unknown model error.
  • src/agents/live-model-filter.ts adds gpt-5.3-codex-spark to the CODEX_MODELS allowlist used by live model filtering.
  • src/agents/pi-embedded-runner/model.test.ts adds unit coverage ensuring the forward-compat fallback resolves openai-codex/gpt-5.3-codex-spark using the gpt-5.2-codex template.

I didn’t find any must-fix issues introduced by these changes.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are small and additive: a new allowlist entry and an extension of an existing forward-compat fallback, covered by a focused unit test. No behavioral regressions were identified in the model resolution flow.
  • No files require special attention

Last reviewed commit: 1349841

(2/5) Greptile learns from your feedback when you react with thumbs up/down!

@openclaw-barnacle openclaw-barnacle bot added agents Agent runtime and tooling size: XS labels Feb 13, 2026
@loiie45e
Copy link
Contributor Author

loiie45e commented Feb 13, 2026

Repro / user impact notes (why this exists):

  • openclaw models list can show openai-codex/gpt-5.3-codex-spark as configured,missing when the discovered model registry does not yet include this id.
  • Selecting the model in OpenClaw can then fail early with Error: Unknown model: openai-codex/gpt-5.3-codex-spark (crashing runs before any assistant output).
  • Meanwhile, the same id works via Codex CLI (e.g. codex exec -m gpt-5.3-codex-spark ...).

This PR intentionally keeps the fix minimal and reversible by using the existing forward-compat template-clone fallback strategy (from gpt-5.2-codex) until the provider’s discovery/catalog includes spark as a first-class entry.

@openclaw-barnacle openclaw-barnacle bot added the commands Command implementations label Feb 13, 2026
@loiie45e
Copy link
Contributor Author

loiie45e commented Feb 13, 2026

Follow-up (quality-of-life): this branch now also updates openclaw models list to avoid tagging a configured model as missing when OpenClaw can resolve it via an existing forward-compat fallback (resolveModel(...)).

This makes openai-codex/gpt-5.3-codex-spark show up as a normal entry (not configured,missing) even before the upstream model catalog/discovery includes spark as a first-class model.

@loiie45e
Copy link
Contributor Author

loiie45e commented Feb 13, 2026

Additional validation (local):

  • Built this branch locally and ran a 10/10 consecutive embedded smoke test using OpenClaw's agent --local path (pi embedded runner), targeting openai-codex/gpt-5.3-codex-spark.
  • Prompt: Reply with exactly OK and nothing else.
  • Result: 10/10 runs returned OK (no Unknown model errors). Typical latency ~2.4–3.7s per run on macOS arm64.

This is intended to complement CI with an end-to-end-ish check of the exact OpenClaw provider path that previously failed.

@mbelinky mbelinky force-pushed the fix/codex-spark-forward-compat branch from 724dbfa to c7d5682 Compare February 13, 2026 15:06
mbelinky added a commit to loiie45e/openclaw that referenced this pull request Feb 13, 2026
@mbelinky
fix: add changelog entry for spark models-list fallback (openclaw#15174…
c7d5682 
…) thanks @loiie45e
mbelinky added a commit to loiie45e/openclaw that referenced this pull request Feb 13, 2026
@mbelinky
fix: add changelog entry for spark models-list fallback (openclaw#15174…
1cc563d 
…) thanks @loiie45e
@mbelinky mbelinky force-pushed the fix/codex-spark-forward-compat branch from c7d5682 to 1cc563d Compare February 13, 2026 15:17
@mbelinky mbelinky force-pushed the fix/codex-spark-forward-compat branch from 1cc563d to 6cac87c Compare February 13, 2026 15:20
@mbelinky mbelinky merged commit 2e04630 into openclaw:main Feb 13, 2026
9 checks passed
@mbelinky
Copy link
Contributor

mbelinky commented Feb 13, 2026

Merged via maintainer flow.

What was done:

  • Rebasing + conflict resolution onto latest main (changelog conflict only).
  • Preserved scope to spark forward-compat + models list missing-tag fallback.
  • Added changelog entry with attribution.
  • Ran local gates in serial mode (build, check, unit/extensions/gateway vitest configs).

Traceability:

  • Original PR commits reviewed: 1349841cb, 724dbface
  • Rebases prepared on top of main: 1ad559b2f, 35eb014e7, 6cac87cbf
  • Final merge commit on main: 2e04630105e59f1a09af61bcc1014c7a08e1a1d5

Thanks @loiie45e.

alex-muradov pushed a commit to alex-muradov/openclaw that referenced this pull request Feb 13, 2026
@loiie45e @degagius
openai-codex: add gpt-5.3-codex-spark forward-compat model (openclaw#…
6b78677 
…15174)

Merged via maintainer flow after rebase + local gates.

Prepared head SHA: 6cac87c

Co-authored-by: loiie45e <[email protected]>
Co-authored-by: mbelinky <[email protected]>
zhangyang-crazy-one pushed a commit to zhangyang-crazy-one/openclaw that referenced this pull request Feb 13, 2026
@loiie45e @degagius
openai-codex: add gpt-5.3-codex-spark forward-compat model (openclaw#…
5e8ce42 
…15174)

Merged via maintainer flow after rebase + local gates.

Prepared head SHA: 6cac87c

Co-authored-by: loiie45e <[email protected]>
Co-authored-by: mbelinky <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 13, 2026
Open
skyhawk14 pushed a commit to skyhawk14/openclaw that referenced this pull request Feb 13, 2026
@loiie45e @degagius
openai-codex: add gpt-5.3-codex-spark forward-compat model (openclaw#…
e6f6350 
…15174)

Merged via maintainer flow after rebase + local gates.

Prepared head SHA: 6cac87c

Co-authored-by: loiie45e <[email protected]>
Co-authored-by: mbelinky <[email protected]>
leftspin pushed a commit to clickety-clacks/clawdbot that referenced this pull request Feb 13, 2026
@loiie45e @degagius
openai-codex: add gpt-5.3-codex-spark forward-compat model (openclaw#…
3fe85eb 
…15174)

Merged via maintainer flow after rebase + local gates.

Prepared head SHA: 6cac87c

Co-authored-by: loiie45e <[email protected]>
Co-authored-by: mbelinky <[email protected]>
steipete pushed a commit to azade-c/openclaw that referenced this pull request Feb 14, 2026
@loiie45e @degagius @steipete
openai-codex: add gpt-5.3-codex-spark forward-compat model (openclaw#…
b21f1f1 
…15174)

Merged via maintainer flow after rebase + local gates.

Prepared head SHA: 6cac87c

Co-authored-by: loiie45e <[email protected]>
Co-authored-by: mbelinky <[email protected]>
@nickytonline nickytonline mentioned this pull request Feb 14, 2026
Closed
leftspin pushed a commit to clickety-clacks/clawdbot that referenced this pull request Feb 14, 2026
@loiie45e @degagius
openai-codex: add gpt-5.3-codex-spark forward-compat model (openclaw#…
3955374 
…15174)

Merged via maintainer flow after rebase + local gates.

Prepared head SHA: 6cac87c

Co-authored-by: loiie45e <[email protected]>
Co-authored-by: mbelinky <[email protected]>
GwonHyeok pushed a commit to learners-superpumped/openclaw that referenced this pull request Feb 15, 2026
@loiie45e @degagius @GwonHyeok
openai-codex: add gpt-5.3-codex-spark forward-compat model (openclaw#…
ddfd138 
…15174)

Merged via maintainer flow after rebase + local gates.

Prepared head SHA: 6cac87c

Co-authored-by: loiie45e <[email protected]>
Co-authored-by: mbelinky <[email protected]>
cloud-neutral pushed a commit to cloud-neutral-toolkit/openclawbot.svc.plus that referenced this pull request Feb 15, 2026
@loiie45e @degagius
openai-codex: add gpt-5.3-codex-spark forward-compat model (openclaw#…
2c2e531 
…15174)

Merged via maintainer flow after rebase + local gates.

Prepared head SHA: 6cac87c

Co-authored-by: loiie45e <[email protected]>
Co-authored-by: mbelinky <[email protected]>
jiulingyun added a commit to jiulingyun/openclaw-cn that referenced this pull request Feb 15, 2026
@jiulingyun
feat: add gpt-5.3-codex-spark forward-compat model (openclaw#15174) (…
a3f3c19 
…upstream 2e04630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

agents Agent runtime and tooling commands Command implementations size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loiie45e @mbelinky

Comments