fix(memory-lancedb): ship @lancedb/lancedb for bundled extension#13671
Closed
CryptoJym wants to merge 3 commits intoopenclaw:mainfrom
Closed
fix(memory-lancedb): ship @lancedb/lancedb for bundled extension#13671CryptoJym wants to merge 3 commits intoopenclaw:mainfrom
CryptoJym wants to merge 3 commits intoopenclaw:mainfrom
Conversation
Bundled extensions under extensions/* rely on the root node_modules at runtime in packaged installs, so memory-lancedb was failing with missing @lancedb/lancedb. Add it as an optionalDependency at the root and add a regression test to prevent future packaging regressions.
- Declare openai at the root so bundled memory-lancedb doesn't rely on transitive hoisting. - Extend the regression test to assert root declares all memory-lancedb deps. - Prevent workspace-generated extensions/*/node_modules artifacts from being packed.
Author
|
Follow-up guardrails (kept intentionally light):
Verified locally: |
thewilloftheshadow
force-pushed
the
main
branch
from
bfc1ccb to
f92900f
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
openclaw-barnacle
bot
added
stale
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bundled extensions under
extensions/*ship in the npm package, but their dependency graphs are not guaranteed to be installed for end users.This caused the bundled
memory-lancedbextension to break in fresh installs (e.g.openclaw ltm stats) when required deps were missing or only available via transitive hoisting.Additionally, workspace-generated
extensions/*/node_modules/.bin/*artifacts can end up in the packed tarball, and those scripts contain absolute paths from the build machine.Fix
@lancedb/lancedbat the root as anoptionalDependencyso installs can succeed even on platforms where LanceDB native bindings may not be available.openaiat the root somemory-lancedbdoes not rely on transitive hoisting/version drift.extensions/memory-lancedbruntime deps.extensions/.npmignoreto exclude workspace-installednode_modulesartifacts from the published package.Verification
pnpm lintpnpm testnpm pack --dry-run --jsonshowsnode_modules entries 0