(feat)Normalize to pass WebSocket CDP URLs for Browser#13325
Closed
snekkenull wants to merge 5 commits intoopenclaw:mainfrom
Closed
(feat)Normalize to pass WebSocket CDP URLs for Browser#13325snekkenull wants to merge 5 commits intoopenclaw:mainfrom
snekkenull wants to merge 5 commits intoopenclaw:mainfrom
Conversation
bfc1ccb to
f92900f
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for remote browser CDP which using WS protocol by normalize ws/wss → http/https so callers can pass WebSocket CDP URLs.
Greptile Summary
This PR enables users to pass WebSocket CDP URLs (
ws://,wss://) as browser configuration, automatically normalizing them to HTTP/HTTPS for REST endpoint access. The normalization convertsws:→http:andwss:→https:in two locations:parseHttpUrl()insrc/browser/config.ts:96-106andparseBaseUrl()insrc/browser/extension-relay.ts:117-138.Changes:
parseHttpUrl()andparseBaseUrl()to accept and normalize WebSocket protocolsws://toftp://for unsupported protocol validationThe approach aligns with existing normalization patterns in the codebase (see
normalizeCdpHttpBaseForJsonEndpointsinsrc/browser/pw-session.ts:529-549).Confidence Score: 5/5
pw-session.ts.Last reviewed commit: 3ce0867
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!