Repository navigation
fix(ios): open session dashboards without nested control UI - #132983
fuller-stack-dev merged 18 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
a8defe8 to
dcb0444
Compare
|
Codex review: needs real behavior proof before merge. Reviewed September 2, 2026, 11:21 AM ET / 15:21 UTC. ClawSweeper reviewWhat this changesThis PR opens dashboard sessions in an authenticated native iOS Control UI sheet, carries the device client identity into the gateway connection, and improves focused-dashboard widget sizing and scroll handoff. Merge readiness⛔ Blocked until stronger real behavior proof is added - 5 items remain Keep open: no definite implementation defect was found, but the prior authority-chain proof requirement remains unmet. The supplied iPhone and mocked-browser evidence supports rendering and scrolling, not rejection of a revoked or reassigned stored device grant before Gateway I/O. Priority: P1 Review scores
Verification
How this fits togetherThe iOS session sidebar recognizes dashboard sessions and opens a focused Control UI document in a native sheet. That document seeds the authenticated gateway connection, then renders sandboxed dashboard widgets and hands excess scrolling to the outer dashboard. flowchart LR
A[Session sidebar] --> B[Dashboard session route]
B --> C[Native iOS sheet]
C --> D[Authenticated Control UI]
D --> E[Gateway connection]
E --> F[Sandboxed dashboard widgets]
F --> G[Outer dashboard scrolling]
Before merge
Findings
Agent review detailsSecurityNeeds attention: The diff introduces a native-to-WebView stored operator-grant handoff without final-effect evidence that revoked or reassigned authority is rejected before Gateway I/O. PR surfaceSource +162, Tests +496, Other +641. Total +1299 across 29 files. View PR surface stats
Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the single Control UI dashboard renderer, but add a redacted real-Gateway trace proving a revoked or reassigned stored device grant is rejected before dashboard connection or board access succeeds. Do we have a high-confidence way to reproduce the issue? No high-confidence live reproduction was established in this read-only review; source and branch tests make the focused iOS dashboard scenario clear. Is this the best way to solve the issue? Unclear: reusing the canonical Control UI renderer is architecturally sound, but the authorization handoff is not ready without final-effect revocation or reassignment evidence. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 65e5b2e19c9d. LabelsLabel justifications:
EvidenceSecurity concerns:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (4 earlier review cycles)
|
|
Addressed both blocking findings:
Verification: 25 focused iOS tests and the simulator build passed on unchanged iOS inputs; after merging current main, the production dashboard E2E passed 9/9 and the changed gateway/board/canvas suites passed 159/159 at @clawsweeper re-review |
|
Merged via squash.
|
…#132983) * fix(ios): open published session dashboards * fix(ios): render dashboards without the control shell * fix(dashboard): confine native routes and preserve scrolling * fix(ui): restore dashboard scroll after sandbox load * fix(ios): preserve dashboard routing and auth fallback * test(ui): settle frameless border transitions
What Problem This Solves
Fixes an issue where iOS users opening a published session dashboard saw the entire Control UI nested inside the native dashboard sheet. That duplicated navigation, allowed horizontal overflow, and left long dashboards unable to scroll to their final content after a sandboxed widget consumed part of a touch or wheel gesture.
Why This Change Was Made
The iOS app now resolves a session's published dashboard and opens a dedicated native dashboard sheet. The Control UI handles that request through a scoped dashboard route that mounts only the board document, while normal chat, split, and dashboard routes keep their existing shell.
The board host also renews scroll authority after the sandbox replaces its inner document. That keeps frame and nonce validation intact while allowing the remaining gesture distance to reach the dashboard's single outer scroll owner.
Rendering the normal Control UI shell in the sheet was rejected because it creates nested navigation and competing scroll owners. Rendering dashboard HTML directly in Swift was also rejected because it would duplicate the board runtime and widget security contract.
Production LOC: +561/-65 (net +496). Tests: +691/-4. The production growth is the native dashboard presentation and the focused board route; it does not add a second dashboard renderer.
User Impact
Tapping a published session dashboard in the iOS app opens the dashboard content directly. The view fits the phone width, contains no nested Control UI chrome, and lets long dashboards scroll to the final row and bottom padding. Existing chat and split views are unchanged.
Evidence
743ab05ef6990f086aac3cc1401dfc883e3472f3: the sheet was shell-free, had no horizontal overflow, and reached the final row with bottom padding. The final rebased head has the same production patch ID; later changes only rebased it onto currentmainand corrected test cleanup.node scripts/run-vitest.mjs run --config test/vitest/vitest.ui.config.ts --configLoader runner ui/src/api/gateway.node.test.ts ui/src/app/gateway-store.test.ts ui/src/app/settings.node.test.ts ui/src/components/board/board-view-sizing.test.ts ui/src/components/board/board-widget-frame.test.ts(162 passed)node scripts/run-vitest.mjs run --config test/vitest/vitest.unit.config.ts --configLoader runner src/canvas/wrap.test.ts(1 passed)node scripts/run-vitest.mjs run --config test/vitest/vitest.ui-e2e.config.ts --configLoader runner ui/src/e2e/dashboard-fullscreen.e2e.test.ts(9 passed, including nested sandbox touch and wheel handoff, short-dashboard overflow guards, route ambiguity, and failure states)node scripts/check-changed.mjs -- <changed files>passed conflict, format, dependency, dead-code, i18n, core typecheck, core-test typecheck, and UI typecheck gates. Its full-core lint lane crashed while constructingtsgolint's program aroundpackages/session-url-contract/src/parse.ts, an unchanged file frommain; direct type-aware lint of every TypeScript file changed by this PR passed.autoreview --mode branch --base upstream/mainreported no accepted or actionable findings on the final patch.The final rebased head could not rerun the iOS simulator suite locally because this Mac has the iOS 26.5 SDK but only an iOS 27.0 simulator runtime. The physically tested and final production diffs produce the same stable patch ID, and hosted CI will compile and test the exact PR head.