Skip to content

fix(ios): open session dashboards without nested control UI - #132983

Merged
fuller-stack-dev merged 18 commits into
openclaw:mainfrom
fuller-stack-dev:fix/ios-dashboard-focus-presentation
Sep 2, 2026
Merged

fuller-stack-dev merged 18 commits into
openclaw:mainfrom
fuller-stack-dev:fix/ios-dashboard-focus-presentation

Conversation

@fuller-stack-dev

Copy link
Copy Markdown
Member

What Problem This Solves

Fixes an issue where iOS users opening a published session dashboard saw the entire Control UI nested inside the native dashboard sheet. That duplicated navigation, allowed horizontal overflow, and left long dashboards unable to scroll to their final content after a sandboxed widget consumed part of a touch or wheel gesture.

Why This Change Was Made

The iOS app now resolves a session's published dashboard and opens a dedicated native dashboard sheet. The Control UI handles that request through a scoped dashboard route that mounts only the board document, while normal chat, split, and dashboard routes keep their existing shell.

The board host also renews scroll authority after the sandbox replaces its inner document. That keeps frame and nonce validation intact while allowing the remaining gesture distance to reach the dashboard's single outer scroll owner.

Rendering the normal Control UI shell in the sheet was rejected because it creates nested navigation and competing scroll owners. Rendering dashboard HTML directly in Swift was also rejected because it would duplicate the board runtime and widget security contract.

Production LOC: +561/-65 (net +496). Tests: +691/-4. The production growth is the native dashboard presentation and the focused board route; it does not add a second dashboard renderer.

User Impact

Tapping a published session dashboard in the iOS app opens the dashboard content directly. The view fits the phone width, contains no nested Control UI chrome, and lets long dashboards scroll to the final row and bottom padding. Existing chat and split views are unchanged.

Evidence

  • Reproduced on a physical iPhone against Rosita: the dashboard sheet showed a nested Control UI, overflowed horizontally, and could not reach the bottom of the long disk-cleanup dashboard.
  • Verified the production patch on the same iPhone and Rosita at 743ab05ef6990f086aac3cc1401dfc883e3472f3: the sheet was shell-free, had no horizontal overflow, and reached the final row with bottom padding. The final rebased head has the same production patch ID; later changes only rebased it onto current main and corrected test cleanup.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.ui.config.ts --configLoader runner ui/src/api/gateway.node.test.ts ui/src/app/gateway-store.test.ts ui/src/app/settings.node.test.ts ui/src/components/board/board-view-sizing.test.ts ui/src/components/board/board-widget-frame.test.ts (162 passed)
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.unit.config.ts --configLoader runner src/canvas/wrap.test.ts (1 passed)
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.ui-e2e.config.ts --configLoader runner ui/src/e2e/dashboard-fullscreen.e2e.test.ts (9 passed, including nested sandbox touch and wheel handoff, short-dashboard overflow guards, route ambiguity, and failure states)
  • node scripts/check-changed.mjs -- <changed files> passed conflict, format, dependency, dead-code, i18n, core typecheck, core-test typecheck, and UI typecheck gates. Its full-core lint lane crashed while constructing tsgolint's program around packages/session-url-contract/src/parse.ts, an unchanged file from main; direct type-aware lint of every TypeScript file changed by this PR passed.
  • autoreview --mode branch --base upstream/main reported no accepted or actionable findings on the final patch.

The final rebased head could not rerun the iOS simulator suite locally because this Mac has the iOS 26.5 SDK but only an iOS 27.0 simulator runtime. The physically tested and final production diffs produce the same stable patch ID, and hosted CI will compile and test the exact PR head.

@clawsweeper

clawsweeper Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@openclaw-barnacle openclaw-barnacle Bot added app: ios App: ios app: web-ui App: web-ui size: XL maintainer Maintainer-authored PR labels Aug 30, 2026
@fuller-stack-dev
fuller-stack-dev force-pushed the fix/ios-dashboard-focus-presentation branch from a8defe8 to dcb0444 Compare August 30, 2026 01:30
@fuller-stack-dev
fuller-stack-dev marked this pull request as ready for review August 30, 2026 01:30
@clawsweeper clawsweeper Bot added P2 Normal backlog priority with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Aug 30, 2026
@clawsweeper

clawsweeper Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed September 2, 2026, 11:21 AM ET / 15:21 UTC.

ClawSweeper review

What this changes

This PR opens dashboard sessions in an authenticated native iOS Control UI sheet, carries the device client identity into the gateway connection, and improves focused-dashboard widget sizing and scroll handoff.

Merge readiness

⛔ Blocked until stronger real behavior proof is added - 5 items remain

Keep open: no definite implementation defect was found, but the prior authority-chain proof requirement remains unmet. The supplied iPhone and mocked-browser evidence supports rendering and scrolling, not rejection of a revoked or reassigned stored device grant before Gateway I/O.

Priority: P1
Reviewed head: f66e795ade50dc5e1f798886882399e66ffb7ad6

Review scores

Measure Result What it means
Overall readiness 🦪 silver shellfish (2/6) The implementation and focused UI coverage are coherent, but the authority-bearing connection handoff lacks required final-effect proof.
Proof confidence 🦪 silver shellfish (2/6) Needs stronger real behavior proof before merge: Authority-chain proof required: the changed Authenticated Control UI WebView → native startup metadata/local storage → GatewayBrowserClient WebSocket path lacks a redacted real-Gateway final-effect trace proving that a revoked or reassigned stored grant is rejected before dashboard connection or board access succeeds. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Patch quality 🦐 gold shrimp (3/6) Security review found an item that needs attention.

Verification

Check Result Evidence
Real behavior Needs proof Needs stronger real behavior proof before merge: Authority-chain proof required: the changed Authenticated Control UI WebView → native startup metadata/local storage → GatewayBrowserClient WebSocket path lacks a redacted real-Gateway final-effect trace proving that a revoked or reassigned stored grant is rejected before dashboard connection or board access succeeds. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed 6 items Introduced native authorization handoff: The iOS WebView injects a device identity and scoped stored authorization into origin-scoped local storage, then exposes native gateway client metadata to the Control UI.
Stored grant is selected for connection: The browser gateway client loads the stored device authorization and can select its token for an operator connection when its scopes permit reading.
Focused dashboard implementation: The native dashboard screen builds canonical focused dashboard routes and presents the authenticated Control UI rather than duplicating dashboard rendering in Swift.
Findings None None.
Security Needs attention Prove stored-grant revocation before connection: The injected local-storage grant can be selected for an operator connection; demonstrate that revocation or reassignment is enforced at the final Gateway boundary before merging.

How this fits together

The iOS session sidebar recognizes dashboard sessions and opens a focused Control UI document in a native sheet. That document seeds the authenticated gateway connection, then renders sandboxed dashboard widgets and hands excess scrolling to the outer dashboard.

flowchart LR
  A[Session sidebar] --> B[Dashboard session route]
  B --> C[Native iOS sheet]
  C --> D[Authenticated Control UI]
  D --> E[Gateway connection]
  E --> F[Sandboxed dashboard widgets]
  F --> G[Outer dashboard scrolling]
Loading

Before merge

  • Add real behavior proof - Needs stronger real behavior proof before merge: Authority-chain proof required: the changed Authenticated Control UI WebView → native startup metadata/local storage → GatewayBrowserClient WebSocket path lacks a redacted real-Gateway final-effect trace proving that a revoked or reassigned stored grant is rejected before dashboard connection or board access succeeds. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
  • Resolve security concern: Prove stored-grant revocation before connection - The injected local-storage grant can be selected for an operator connection; demonstrate that revocation or reassignment is enforced at the final Gateway boundary before merging.
  • Resolve merge risk (P1) - A stored operator grant now crosses from native state into WebView storage; without final-effect revocation or reassignment proof, the authorization boundary before Gateway I/O is unverified.
  • Resolve merge risk (P1) - This bug-fix PR adds a net 534 production lines, increasing compatibility surface across iOS, Control UI startup, gateway identity, and sandbox scrolling.
  • Complete next step (P2) - Add a redacted real-Gateway final-effect trace showing that, after this native handoff, the nearest revoked or reassigned stored device grant is rejected before the dashboard connection or board request succeeds.

Findings

  • [medium] Prove stored-grant revocation before connection — apps/ios/Sources/Web/AuthenticatedControlUIWebView.swift:111
Agent review details

Security

Needs attention: The diff introduces a native-to-WebView stored operator-grant handoff without final-effect evidence that revoked or reassigned authority is rejected before Gateway I/O.

PR surface

Source +162, Tests +496, Other +641. Total +1299 across 29 files.

View PR surface stats
Area Files Added Removed Net
Source 11 199 37 +162
Tests 9 501 5 +496
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 9 670 29 +641
Total 29 1370 71 +1299

Review metrics

Metric Value Why it matters
Production versus test delta production +534 net; tests/test support +761 net; generated i18n +4 net The new native presentation, authorization handoff, and scroll ownership explain substantial growth, but the bug-fix production increase needs the missing boundary proof before merge.

Merge-risk options

Maintainer options:

  1. Prove revocation at the Gateway boundary (recommended)
    Add a redacted real-Gateway final-effect trace in which the nearest revoked or reassigned stored device grant cannot establish the dashboard connection or board request.
  2. Pause pending authorization proof
    Do not merge this authority-bearing handoff until the final authorization decision is demonstrated at the Gateway boundary.

Technical review

Best possible solution:

Keep the single Control UI dashboard renderer, but add a redacted real-Gateway trace proving a revoked or reassigned stored device grant is rejected before dashboard connection or board access succeeds.

Do we have a high-confidence way to reproduce the issue?

No high-confidence live reproduction was established in this read-only review; source and branch tests make the focused iOS dashboard scenario clear.

Is this the best way to solve the issue?

Unclear: reusing the canonical Control UI renderer is architecturally sound, but the authorization handoff is not ready without final-effect revocation or reassignment evidence.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 65e5b2e19c9d.

Labels

Label justifications:

  • P1: The PR changes a user-facing iOS dashboard and authenticated gateway workflow.
  • merge-risk: 🚨 compatibility: Existing iOS Control UI sessions now receive a different focused presentation, identity, and authentication handoff path.
  • merge-risk: 🚨 auth-provider: The browser gateway client consumes native client metadata and scoped stored device authorization for connection selection.
  • merge-risk: 🚨 security-boundary: An operator grant is transferred into the WebView, while revocation and reassignment rejection at final I/O remains unproven.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs stronger real behavior proof before merge: Authority-chain proof required: the changed Authenticated Control UI WebView → native startup metadata/local storage → GatewayBrowserClient WebSocket path lacks a redacted real-Gateway final-effect trace proving that a revoked or reassigned stored grant is rejected before dashboard connection or board access succeeds. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Evidence

Security concerns:

  • [medium] Prove stored-grant revocation before connection — apps/ios/Sources/Web/AuthenticatedControlUIWebView.swift:111
    The injected local-storage grant can be selected for an operator connection; demonstrate that revocation or reassignment is enforced at the final Gateway boundary before merging.
    Confidence: 0.9

What I checked:

  • Introduced native authorization handoff: The iOS WebView injects a device identity and scoped stored authorization into origin-scoped local storage, then exposes native gateway client metadata to the Control UI. (apps/ios/Sources/Web/AuthenticatedControlUIWebView.swift:65, f66e795ade50)
  • Stored grant is selected for connection: The browser gateway client loads the stored device authorization and can select its token for an operator connection when its scopes permit reading. (ui/src/api/gateway.ts:607, f66e795ade50)
  • Focused dashboard implementation: The native dashboard screen builds canonical focused dashboard routes and presents the authenticated Control UI rather than duplicating dashboard rendering in Swift. (apps/ios/Sources/Chat/SessionDashboardScreen.swift:12, f66e795ade50)
  • Coverage is not final-effect revocation proof: The branch adds focused-route, native-handoff, sizing, nonce, and mocked Gateway/sandbox browser coverage, but the reviewed evidence contains no real-Gateway trace showing a revoked or reassigned stored grant rejected before the dashboard request succeeds. (ui/src/e2e/dashboard-fullscreen.e2e.test.ts:255, f66e795ade50)
  • PR/base identity: The inspected merge result has the pinned base as first parent and this exact PR head as second parent, so the reviewed authority path is attributable to this branch's merge result. (ebd4d0285289)
  • Related feature history: Prior merged mobile and focused-presentation work established the iOS authenticated Control UI and focused-route area. (apps/ios/Sources/Web/AuthenticatedControlUIWebView.swift, 262deec72c1c)

Likely related people:

  • Peter Steinberger: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Provide a redacted real-Gateway revocation or reassignment trace showing rejection before the dashboard connection or board request succeeds.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (4 earlier review cycles)
  • reviewed 2026-08-30T01:38:33.635Z sha dcb0444 :: needs maintainer review before merge. :: none
  • reviewed August 29, 2026, 9:57 PM ET / August 30, 2026, 01:57 UTC sha unknown :: found issues before merge. :: [P1] Preserve configured credentials when device authorization is unusable | [P1] Route global dashboard sessions with their selected agent
  • reviewed 2026-09-02T09:54:29.065Z sha 5d3da9c :: needs maintainer review before merge. :: none
  • reviewed 2026-09-02T10:07:56.366Z sha 2a57504 :: needs real behavior proof before merge. :: none

@clawsweeper clawsweeper Bot added merge-risk: 🚨 auth-provider 🚨 May break OAuth, tokens, provider routing, model choice, or credentials. merge-risk: 🚨 compatibility 🚨 May break existing users, config, migrations, defaults, or upgrade paths. P1 High-priority user-facing bug, regression, or broken workflow. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. and removed P2 Normal backlog priority with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Aug 30, 2026
@fuller-stack-dev

Copy link
Copy Markdown
Member Author

Addressed both blocking findings:

  • Stored device authorization now augments startup auth without removing the configured token/password fallback.
  • Dashboard presentation now carries the roster agent ID, so global/unscoped sessions resolve the canonical focused route while malformed scoped keys remain rejected.

Verification: 25 focused iOS tests and the simulator build passed on unchanged iOS inputs; after merging current main, the production dashboard E2E passed 9/9 and the changed gateway/board/canvas suites passed 159/159 at a130c89c956dddeafc5509abbdebd9c86e622ef7.

@clawsweeper re-review

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Sep 2, 2026
@clawsweeper clawsweeper Bot added merge-risk: 🚨 security-boundary 🚨 May affect sandboxing, authorization, credentials, or sensitive data. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Sep 2, 2026
@fuller-stack-dev
fuller-stack-dev merged commit f1ae53b into openclaw:main Sep 2, 2026
723 of 831 checks passed
@fuller-stack-dev

Copy link
Copy Markdown
Member Author

Merged via squash.

@fuller-stack-dev
fuller-stack-dev deleted the fix/ios-dashboard-focus-presentation branch September 2, 2026 16:17
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Sep 3, 2026
…#132983)

* fix(ios): open published session dashboards

* fix(ios): render dashboards without the control shell

* fix(dashboard): confine native routes and preserve scrolling

* fix(ui): restore dashboard scroll after sandbox load

* fix(ios): preserve dashboard routing and auth fallback

* test(ui): settle frameless border transitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: ios App: ios app: web-ui App: web-ui maintainer Maintainer-authored PR merge-risk: 🚨 auth-provider 🚨 May break OAuth, tokens, provider routing, model choice, or credentials. merge-risk: 🚨 compatibility 🚨 May break existing users, config, migrations, defaults, or upgrade paths. merge-risk: 🚨 security-boundary 🚨 May affect sandboxing, authorization, credentials, or sensitive data. P1 High-priority user-facing bug, regression, or broken workflow. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. size: XL status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant