fix(discord): resolve numeric guildId/channelId pairs in channel allowlist by mcaxtr · Pull Request #12204 · openclaw/openclaw

mcaxtr · 2026-02-09T00:49:20Z

Summary

When users configure Discord channel allowlists with numeric guildId/channelId pairs (e.g. 111222333/444555666), parseDiscordChannelInput treated the channel part as a channel name rather than an ID. This caused the resolution to attempt a name-based lookup against guild channels, which always failed for numeric IDs, silently dropping inbound messages from those channels.

Changes

Numeric channel ID detection: when both halves of guild/channel are all-digits, parse the channel part as channelId for direct API lookup
Guild membership validation: reject entries where the fetched channel belongs to a different guild than specified
Graceful error handling: catch 404/403 from channel lookups so one bad entry doesn't abort the entire batch
Guild context preservation: include guildId on unresolved results so downstream onboarding doesn't default to wildcard guild
Name fallback: when a numeric channel ID lookup fails and a guild was specified, fall back to name matching within that guild (supports channels with numeric names like "2024")

Test plan

"111222333/444555666" resolves via direct channel ID lookup (TDD — test written first)
"111222333/444555666" where channel belongs to different guild → resolved: false with note
"111222333/999000111" where channel ID is 404 → marks unresolved, doesn't abort batch, preserves guildId
"111222333/777888999" where channel ID is 403 → marks unresolved, doesn't abort batch
"111222333/2024" where "2024" is a channel name → falls back to name matching within guild
All 7 new tests fail before fix, pass after
All 12 existing discord test files pass (40+ tests)
pnpm build && pnpm check clean

Greptile Overview

Greptile Summary

This PR updates Discord allowlist parsing/resolution to correctly handle numeric guildId/channelId inputs by treating the channel segment as an ID (with optional guild-scoped name fallback on 404), adds a guild-membership consistency check for resolved channels, and improves channel fetch error classification (403 vs 404 vs invalid payload) so a single bad entry doesn’t abort batch resolution.

The main logic lives in src/discord/resolve-channels.ts, where parseDiscordChannelInput now returns {guildId, channelId} when both segments are all-digits, and fetchChannel now returns a discriminated FetchChannelResult to avoid conflating forbidden/not-found/invalid responses. src/discord/resolve-channels.test.ts adds coverage for the numeric-pair path, guild mismatch rejection, 404/403 behavior, and malformed payload handling.

Confidence Score: 5/5

This PR is safe to merge with minimal risk.
The changes are localized to Discord allowlist parsing/resolution, add targeted tests for the new numeric guildId/channelId path, and the new error classification avoids previously reported incorrect fallbacks. I did not find any additional deterministic logic issues in the diff beyond previously addressed threads.
No files require special attention

greptile-apps

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

src/discord/resolve-channels.ts

greptile-apps · 2026-02-09T00:50:30Z

Additional Comments (1)

src/discord/resolve-channels.ts
Duplicate guild lookup

parsed.guildId && guilds.find(...) ? guilds.find(...) : ... performs the same find twice. This isn’t just style: because it’s inside the main resolution loop, it doubles work for guildOnly entries and makes behavior harder to reason about if this block ever changes (e.g. if guilds becomes non-static). Store the result of the first find and reuse it.

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/discord/resolve-channels.ts
Line: 193:201

Comment:
**Duplicate guild lookup**

`parsed.guildId && guilds.find(...) ? guilds.find(...) : ...` performs the same `find` twice. This isn’t just style: because it’s inside the main resolution loop, it doubles work for `guildOnly` entries and makes behavior harder to reason about if this block ever changes (e.g. if `guilds` becomes non-static). Store the result of the first `find` and reuse it.

How can I resolve this? If you propose a fix, please make it concise.

mcaxtr · 2026-02-09T00:58:16Z

Re: Duplicate guild lookup — Good catch, fixed in 307c26b. Both instances now store the find result in guildById and reuse it via nullish coalescing:

const guildById = parsed.guildId ? guilds.find((entry) => entry.id === parsed.guildId) : undefined;
const guild = guildById ?? (parsed.guild ? resolveGuildByName(guilds, parsed.guild) : undefined);

@greptile-apps could you please re-review? The duplicate lookup is resolved, and I've explained the numeric-name fallback rationale in the inline thread.

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/discord/resolve-channels.ts

mcaxtr · 2026-02-09T01:06:50Z

@greptile-apps Great catch on the 403-vs-404 distinction — fixed in 1e0f4c5. fetchChannel now returns a discriminated union ("found" | "not-found" | "forbidden") so the name fallback only triggers on 404, not 403. New test confirms 403 stays hard-unresolved.

Could you please re-review?

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

src/discord/resolve-channels.test.ts

src/discord/resolve-channels.ts

mcaxtr · 2026-02-09T01:20:53Z

@greptile-apps Addressed both new comments:

Invalid payload misclassified — Fixed in c3e74b3. Malformed 200 responses now return { status: "invalid" } instead of "not-found", preventing the name-fallback from triggering on unexpected API data. New test covers this.
Test IDs aren't numeric — Explained in the thread: the numeric IDs are intentional since the tests specifically exercise the numeric guildId/channelId parsing path from issue Discord inbound messages silently dropped after update — parseDiscordChannelInput fails to resolve numeric channel IDs #12185. The pre-existing tests with g1/c1 cover the name-based path.

Could you please re-review?

mcaxtr · 2026-03-02T15:38:55Z

Rebase note: The numeric guildId/channelId parsing fix in parseDiscordChannelInput has since landed independently in main. This PR no longer carries that change.

What this PR still adds on top of current main:

Error discrimination on fetchChannel — returns a FetchChannelResult discriminated union (found/not-found/forbidden/invalid) instead of DiscordChannelSummary | null. Without this, a single 404 or 403 from the Discord API throws an unhandled DiscordApiError and aborts the entire allowlist resolution batch.
Name-based fallback — when a numeric channel ID lookup returns not-found and a guildId was specified, falls back to name matching within that guild (supports channels literally named with numbers like "2024").
guildId preservation on unresolved results — the current failure path drops guildId, which causes downstream onboarding to default to wildcard guild.

Rebased onto current main — diff is clean against these three changes + corresponding tests.

…ling Parse numeric channel part as channelId in guildId/channelId input format. Validate guild membership to reject channels belonging to different guilds. Handle 404 and 403 in fetchChannel to prevent batch abort on invalid or inaccessible channel IDs. Preserve guildId context on unresolved lookups so downstream code retains guild association. Fixes openclaw#12185

…up fails When a numeric channel ID cannot be resolved via the Discord API (404), attempt name-based matching within the guild as a graceful degradation. Deduplicate guild lookup logic that was repeated across the numeric and name-based resolution paths.

…ect fallbacks Distinguish 403 (access denied) from 404 (not found) so name-based fallback only triggers on genuine not-found responses. Treat malformed channel payloads (missing id/name) as invalid rather than not-found to avoid incorrect name matching on corrupted API responses.

…ch fetch signature

aisle-research-bot · 2026-03-03T04:09:49Z

🤖 We're reviewing this PR with Aisle

We're running a security check on the changes in this PR now. This usually takes a few minutes. ⌛
We'll post the results here as soon as they're ready.

Progress:

Analysis
Triage
Finalization

Latest run failed. Keeping previous successful results. Trace ID: 019cb1e33dee4672c27967d5094eba9b.

_{Last updated on: 2026-03-03T04:09:56Z}

thewilloftheshadow · 2026-03-03T15:03:21Z

Superseded by #33142 which consolidates the fixes from this PR. Closing this in favor of that PR.

openclaw-barnacle bot added the channel: discord Channel integration: discord label Feb 9, 2026

greptile-apps bot reviewed Feb 9, 2026

View reviewed changes

src/discord/resolve-channels.ts Outdated Show resolved Hide resolved

greptile-apps bot reviewed Feb 9, 2026

View reviewed changes

src/discord/resolve-channels.ts Show resolved Hide resolved

greptile-apps bot reviewed Feb 9, 2026

View reviewed changes

src/discord/resolve-channels.test.ts Show resolved Hide resolved

src/discord/resolve-channels.ts Show resolved Hide resolved

mcaxtr force-pushed the fix/12185-discord-numeric-channel-id branch 2 times, most recently from 9fdbc29 to 71a3650 Compare February 12, 2026 04:15

openclaw-barnacle bot added the size: M label Feb 12, 2026

thewilloftheshadow mentioned this pull request Feb 12, 2026

Fix Discord allowlist parsing for numeric IDs #8406

Closed

mcaxtr force-pushed the fix/12185-discord-numeric-channel-id branch from 71a3650 to ef5c6db Compare February 13, 2026 02:24

openclaw-barnacle bot added the trusted-contributor label Feb 13, 2026

mcaxtr force-pushed the fix/12185-discord-numeric-channel-id branch from ef5c6db to af7d222 Compare February 13, 2026 14:35

openclaw-barnacle bot added the experienced-contributor label Feb 13, 2026

mcaxtr force-pushed the fix/12185-discord-numeric-channel-id branch 8 times, most recently from a0ae671 to 1f1e0e1 Compare February 15, 2026 14:47

thewilloftheshadow force-pushed the main branch from bfc1ccb to f92900f Compare February 15, 2026 18:46

mcaxtr force-pushed the fix/12185-discord-numeric-channel-id branch 3 times, most recently from c54b6fd to 3ffa93a Compare February 19, 2026 03:21

sebslight mentioned this pull request Feb 20, 2026

fix(discord): recognize numeric channel IDs in guildId/channelId input #20213

Closed

19 tasks

mcaxtr force-pushed the fix/12185-discord-numeric-channel-id branch from 2420696 to 877a62e Compare February 27, 2026 15:46

mcaxtr force-pushed the fix/12185-discord-numeric-channel-id branch from 877a62e to d0999b2 Compare March 2, 2026 15:18

mcaxtr added 5 commits March 3, 2026 01:09

fix: update bare numeric guild id test for graceful 404 handling

fe6e578

fix(test): use RequestInfo|URL parameter type in fetcher mocks to mat…

fb6c155

…ch fetch signature

mcaxtr force-pushed the fix/12185-discord-numeric-channel-id branch from d0999b2 to fb6c155 Compare March 3, 2026 04:09

thewilloftheshadow mentioned this pull request Mar 3, 2026

fix(discord): harden channel resolution #33142

Merged

18 tasks

thewilloftheshadow closed this Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(discord): resolve numeric guildId/channelId pairs in channel allowlist#12204

fix(discord): resolve numeric guildId/channelId pairs in channel allowlist#12204
mcaxtr wants to merge 5 commits intoopenclaw:mainfrom
mcaxtr:fix/12185-discord-numeric-channel-id

mcaxtr commented Feb 9, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

greptile-apps bot commented Feb 9, 2026

Uh oh!

mcaxtr commented Feb 9, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

mcaxtr commented Feb 9, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

mcaxtr commented Feb 9, 2026

Uh oh!

mcaxtr commented Mar 2, 2026

Uh oh!

aisle-research-bot bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

thewilloftheshadow commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mcaxtr commented Feb 9, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Greptile Overview

Greptile Summary

Confidence Score: 5/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot commented Feb 9, 2026

Uh oh!

mcaxtr commented Feb 9, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mcaxtr commented Feb 9, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mcaxtr commented Feb 9, 2026

Uh oh!

mcaxtr commented Mar 2, 2026

Uh oh!

aisle-research-bot bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thewilloftheshadow commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcaxtr commented Feb 9, 2026 •

edited by greptile-apps bot

Loading

aisle-research-bot bot commented Mar 3, 2026 •

edited

Loading