fix(paths): structurally resolve home dir to prevent Windows path bugs#12125
Merged
sebslight merged 2 commits intoopenclaw:mainfrom Feb 9, 2026
Merged
fix(paths): structurally resolve home dir to prevent Windows path bugs#12125sebslight merged 2 commits intoopenclaw:mainfrom
sebslight merged 2 commits intoopenclaw:mainfrom
Conversation
Contributor
Author
|
Hey @sebslight, this is a follow-up to your #12091 work. On Windows, The fix has two parts:
Would love your thoughts when you have a moment! |
mcaxtr
force-pushed
the
fix/12119-windows-homedir-resolve
branch
3 times, most recently
from
4ab6cd8 to
4be3c50
Compare
mcaxtr
changed the title
sebslight
force-pushed
the
fix/12119-windows-homedir-resolve
branch
from
4be3c50 to
d586252
Compare
Extract resolveRawHomeDir as a private function and gate the public
resolveEffectiveHomeDir through a single path.resolve() exit point.
This makes it structurally impossible for unresolved paths (missing
drive letter on Windows) to escape the function, regardless of how
many return paths exist in the raw lookup logic.
Simplify resolveRequiredHomeDir to only resolve the process.cwd()
fallback, since resolveEffectiveHomeDir now returns resolved values.
Fix shortenMeta in tool-meta.ts: the colon-based split for file:line
patterns (e.g. file.txt:12) conflicts with Windows drive letters
(C:\...) because indexOf(":") matches the drive colon first.
shortenHomeInString already handles file:line patterns correctly via
split/join, so the colon split was both unnecessary and harmful.
Update test assertions across all affected files to use path.resolve()
in expected values and input strings so they match the now-correct
resolved output on both Unix and Windows.
Fixes openclaw#12119
sebslight
force-pushed
the
fix/12119-windows-homedir-resolve
branch
from
d586252 to
b04330e
Compare
Member
1 task
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 9, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
zendizmo
pushed a commit
to zendizmo/openclaw
that referenced
this pull request
Feb 9, 2026
openclaw#12125) * fix(paths): structurally resolve home dir to prevent Windows path bugs Extract resolveRawHomeDir as a private function and gate the public resolveEffectiveHomeDir through a single path.resolve() exit point. This makes it structurally impossible for unresolved paths (missing drive letter on Windows) to escape the function, regardless of how many return paths exist in the raw lookup logic. Simplify resolveRequiredHomeDir to only resolve the process.cwd() fallback, since resolveEffectiveHomeDir now returns resolved values. Fix shortenMeta in tool-meta.ts: the colon-based split for file:line patterns (e.g. file.txt:12) conflicts with Windows drive letters (C:\...) because indexOf(":") matches the drive colon first. shortenHomeInString already handles file:line patterns correctly via split/join, so the colon split was both unnecessary and harmful. Update test assertions across all affected files to use path.resolve() in expected values and input strings so they match the now-correct resolved output on both Unix and Windows. Fixes openclaw#12119 * fix(changelog): add paths Windows fix entry (openclaw#12125) --------- Co-authored-by: Sebastian <[email protected]>
yeboster
pushed a commit
to yeboster/openclaw
that referenced
this pull request
Feb 9, 2026
openclaw#12125) * fix(paths): structurally resolve home dir to prevent Windows path bugs Extract resolveRawHomeDir as a private function and gate the public resolveEffectiveHomeDir through a single path.resolve() exit point. This makes it structurally impossible for unresolved paths (missing drive letter on Windows) to escape the function, regardless of how many return paths exist in the raw lookup logic. Simplify resolveRequiredHomeDir to only resolve the process.cwd() fallback, since resolveEffectiveHomeDir now returns resolved values. Fix shortenMeta in tool-meta.ts: the colon-based split for file:line patterns (e.g. file.txt:12) conflicts with Windows drive letters (C:\...) because indexOf(":") matches the drive colon first. shortenHomeInString already handles file:line patterns correctly via split/join, so the colon split was both unnecessary and harmful. Update test assertions across all affected files to use path.resolve() in expected values and input strings so they match the now-correct resolved output on both Unix and Windows. Fixes openclaw#12119 * fix(changelog): add paths Windows fix entry (openclaw#12125) --------- Co-authored-by: Sebastian <[email protected]>
Ethermious
pushed a commit
to Ethermious/openclaw
that referenced
this pull request
Feb 9, 2026
openclaw#12125) * fix(paths): structurally resolve home dir to prevent Windows path bugs Extract resolveRawHomeDir as a private function and gate the public resolveEffectiveHomeDir through a single path.resolve() exit point. This makes it structurally impossible for unresolved paths (missing drive letter on Windows) to escape the function, regardless of how many return paths exist in the raw lookup logic. Simplify resolveRequiredHomeDir to only resolve the process.cwd() fallback, since resolveEffectiveHomeDir now returns resolved values. Fix shortenMeta in tool-meta.ts: the colon-based split for file:line patterns (e.g. file.txt:12) conflicts with Windows drive letters (C:\...) because indexOf(":") matches the drive colon first. shortenHomeInString already handles file:line patterns correctly via split/join, so the colon split was both unnecessary and harmful. Update test assertions across all affected files to use path.resolve() in expected values and input strings so they match the now-correct resolved output on both Unix and Windows. Fixes openclaw#12119 * fix(changelog): add paths Windows fix entry (openclaw#12125) --------- Co-authored-by: Sebastian <[email protected]>
lucasmpramos
pushed a commit
to butley/openclaw
that referenced
this pull request
Feb 10, 2026
openclaw#12125) * fix(paths): structurally resolve home dir to prevent Windows path bugs Extract resolveRawHomeDir as a private function and gate the public resolveEffectiveHomeDir through a single path.resolve() exit point. This makes it structurally impossible for unresolved paths (missing drive letter on Windows) to escape the function, regardless of how many return paths exist in the raw lookup logic. Simplify resolveRequiredHomeDir to only resolve the process.cwd() fallback, since resolveEffectiveHomeDir now returns resolved values. Fix shortenMeta in tool-meta.ts: the colon-based split for file:line patterns (e.g. file.txt:12) conflicts with Windows drive letters (C:\...) because indexOf(":") matches the drive colon first. shortenHomeInString already handles file:line patterns correctly via split/join, so the colon split was both unnecessary and harmful. Update test assertions across all affected files to use path.resolve() in expected values and input strings so they match the now-correct resolved output on both Unix and Windows. Fixes openclaw#12119 * fix(changelog): add paths Windows fix entry (openclaw#12125) --------- Co-authored-by: Sebastian <[email protected]>
yeboster
pushed a commit
to yeboster/openclaw
that referenced
this pull request
Feb 13, 2026
openclaw#12125) * fix(paths): structurally resolve home dir to prevent Windows path bugs Extract resolveRawHomeDir as a private function and gate the public resolveEffectiveHomeDir through a single path.resolve() exit point. This makes it structurally impossible for unresolved paths (missing drive letter on Windows) to escape the function, regardless of how many return paths exist in the raw lookup logic. Simplify resolveRequiredHomeDir to only resolve the process.cwd() fallback, since resolveEffectiveHomeDir now returns resolved values. Fix shortenMeta in tool-meta.ts: the colon-based split for file:line patterns (e.g. file.txt:12) conflicts with Windows drive letters (C:\...) because indexOf(":") matches the drive colon first. shortenHomeInString already handles file:line patterns correctly via split/join, so the colon split was both unnecessary and harmful. Update test assertions across all affected files to use path.resolve() in expected values and input strings so they match the now-correct resolved output on both Unix and Windows. Fixes openclaw#12119 * fix(changelog): add paths Windows fix entry (openclaw#12125) --------- Co-authored-by: Sebastian <[email protected]>
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 13, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
skyhawk14
pushed a commit
to skyhawk14/openclaw
that referenced
this pull request
Feb 13, 2026
openclaw#12125) * fix(paths): structurally resolve home dir to prevent Windows path bugs Extract resolveRawHomeDir as a private function and gate the public resolveEffectiveHomeDir through a single path.resolve() exit point. This makes it structurally impossible for unresolved paths (missing drive letter on Windows) to escape the function, regardless of how many return paths exist in the raw lookup logic. Simplify resolveRequiredHomeDir to only resolve the process.cwd() fallback, since resolveEffectiveHomeDir now returns resolved values. Fix shortenMeta in tool-meta.ts: the colon-based split for file:line patterns (e.g. file.txt:12) conflicts with Windows drive letters (C:\...) because indexOf(":") matches the drive colon first. shortenHomeInString already handles file:line patterns correctly via split/join, so the colon split was both unnecessary and harmful. Update test assertions across all affected files to use path.resolve() in expected values and input strings so they match the now-correct resolved output on both Unix and Windows. Fixes openclaw#12119 * fix(changelog): add paths Windows fix entry (openclaw#12125) --------- Co-authored-by: Sebastian <[email protected]>
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 14, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
mbelinky
pushed a commit
that referenced
this pull request
Feb 14, 2026
#12125) * fix(paths): structurally resolve home dir to prevent Windows path bugs Extract resolveRawHomeDir as a private function and gate the public resolveEffectiveHomeDir through a single path.resolve() exit point. This makes it structurally impossible for unresolved paths (missing drive letter on Windows) to escape the function, regardless of how many return paths exist in the raw lookup logic. Simplify resolveRequiredHomeDir to only resolve the process.cwd() fallback, since resolveEffectiveHomeDir now returns resolved values. Fix shortenMeta in tool-meta.ts: the colon-based split for file:line patterns (e.g. file.txt:12) conflicts with Windows drive letters (C:\...) because indexOf(":") matches the drive colon first. shortenHomeInString already handles file:line patterns correctly via split/join, so the colon split was both unnecessary and harmful. Update test assertions across all affected files to use path.resolve() in expected values and input strings so they match the now-correct resolved output on both Unix and Windows. Fixes #12119 * fix(changelog): add paths Windows fix entry (#12125) --------- Co-authored-by: Sebastian <[email protected]>
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 14, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 15, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 16, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 18, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
akoscz
added a commit
to akoscz/openclaw
that referenced
this pull request
Feb 20, 2026
resolveDefaultConfigCandidates returns resolved paths (with drive letter on Windows) after upstream openclaw#12125. The test used raw path.join with a Unix-style home, missing the drive prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12119
Problem
resolveEffectiveHomeDir()returned raw env-var values (e.g.OPENCLAW_HOME="/custom/home") without callingpath.resolve(). On POSIX this is harmless, but on Windowspath.join("/custom/home", ".openclaw")produces\custom\home\.openclaw(missing the drive letter), breakingSTATE_DIRandCONFIG_PATHderivation.Additionally,
shortenMeta()intool-meta.tsusedindexOf(":")to split file:line patterns (e.g.file.txt:12), but this conflicts with Windows drive letters (C:\...) where the colon appears at index 1.Both issues were introduced/exposed by #12091 which added
OPENCLAW_HOMEsupport.Fix
Structural gate (
home-dir.ts): Extract the raw lookup logic into a privateresolveRawHomeDir()and gate the publicresolveEffectiveHomeDir()through a singlepath.resolve()exit point. This makes it structurally impossible for unresolved paths to escape, regardless of how many return paths exist. Future developers can add new env-var sources without rememberingpath.resolve().Simplify
resolveRequiredHomeDir: Remove the now-redundantpath.resolve()wrapper — only theprocess.cwd()fallback needs it.Fix
shortenMeta(tool-meta.ts): Remove the colon-based split that conflicts with Windows drive letters.shortenHomeInString()already handles file:line patterns correctly viasplit(home).join(prefix), so the colon split was both unnecessary and harmful.Tests: Update assertions across all affected files to use
path.resolve()in expected values and input strings so they match the now-correct resolved output on both Unix and Windows.Test plan
home-dir.test.tstests passtool-meta.test.tstests passutils.test.tstests passagent-scope.test.tstests passpaths.test.tstests passconfig.nix-integration-u3-u5-u9.test.tstests passworkspace.test.tstests passprofile.test.tstests passsession-utils.fs.test.tstests passpnpm build && pnpm checkcleanchecks-windows) passes