fix: don't auto-create HEARTBEAT.md on workspace init#12027
Merged
Takhoffman merged 3 commits intoopenclaw:mainfrom Feb 14, 2026
Merged
fix: don't auto-create HEARTBEAT.md on workspace init#12027Takhoffman merged 3 commits intoopenclaw:mainfrom
Takhoffman merged 3 commits intoopenclaw:mainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/agents/workspace.ts
Line: 125:137
Comment:
**Stale `heartbeatPath` return type**
`ensureAgentWorkspace` no longer creates/returns `heartbeatPath`, but the function signature still advertises `heartbeatPath?: string` and the internal `WorkspaceBootstrapFileName` union still includes `DEFAULT_HEARTBEAT_FILENAME`. This will leave callers/types thinking HEARTBEAT.md is part of the bootstrap set even though it’s now intentionally excluded. Please remove `heartbeatPath` from the return type (and any related bootstrap-type unions if this function is meant to describe what gets created).
How can I resolve this? If you propose a fix, please make it concise. |
shadril238
force-pushed
the
fix/heartbeat-missing-file-behavior
branch
from
e3c5b68 to
4892194
Compare
Fixes openclaw#11766 The documentation states 'If the file is missing, the heartbeat still runs and the model decides what to do.' However, ensureAgentWorkspace() was auto-creating HEARTBEAT.md from template (which is effectively empty), causing heartbeat to be silently disabled. This change removes HEARTBEAT.md from workspace initialization so that: - Missing file: heartbeat runs, LLM decides (per docs) - Empty file: heartbeat skipped (saves API calls) - File with tasks: heartbeat runs normally
Takhoffman
force-pushed
the
fix/heartbeat-missing-file-behavior
branch
from
4892194 to
e8b2311
Compare
Contributor
|
Merged via squash.
Thanks @shadril238! |
openclaw-barnacle
bot
added
size: XS
trusted-contributor
steipete
pushed a commit
to azade-c/openclaw
that referenced
this pull request
Feb 14, 2026
… thanks @shadril238 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test Co-authored-by: shadril238 <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
4 tasks
Contributor
|
@steipete This one removes the creation of HEARTBEAT.md completely---even on a brand new workspace. This doesn't sound right---the empty template file is intended as a starting point to grow one's own heartbeat actions. In my opinion, this is the right approach: #11807 Only create the HEARTBEAT.md on an empty workspace (i.e. when BOOTSTRAP.md is created). Tis PR also leads to a behavioural change: Previously, in a new workspace, the heartbeat would not run, as there was a blocking "functionally empty" file. Now, new workspaces don't have that file, and the heartbeat will run, leaving the agent to figure out what to do without any guidance. Removing the file and letting the heartbeat run without it should be a conscious choice for people who change their heartbeat prompt to tell the agent what to do. |
Takhoffman
added a commit
that referenced
this pull request
Feb 14, 2026
… thanks @shadril238" This reverts commit 386bb0c.
Takhoffman
added a commit
that referenced
this pull request
Feb 14, 2026
… thanks @shadril238" (#16183) This reverts commit 386bb0c.
hamidzr
pushed a commit
to hamidzr/openclaw
that referenced
this pull request
Feb 14, 2026
…aw#12027) thanks @shadril238" (openclaw#16183) This reverts commit 386bb0c.
openperf
pushed a commit
to openperf/moltbot
that referenced
this pull request
Feb 14, 2026
…aw#12027) thanks @shadril238" (openclaw#16183) This reverts commit 386bb0c.
openperf
pushed a commit
to openperf/moltbot
that referenced
this pull request
Feb 14, 2026
…aw#12027) thanks @shadril238" (openclaw#16183) This reverts commit 386bb0c.
BigUncle
pushed a commit
to BigUncle/openclaw
that referenced
this pull request
Feb 14, 2026
…aw#12027) thanks @shadril238" (openclaw#16183) This reverts commit 386bb0c.
mverrilli
pushed a commit
to mverrilli/openclaw
that referenced
this pull request
Feb 14, 2026
… thanks @shadril238 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test Co-authored-by: shadril238 <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
mverrilli
pushed a commit
to mverrilli/openclaw
that referenced
this pull request
Feb 14, 2026
…aw#12027) thanks @shadril238" (openclaw#16183) This reverts commit 386bb0c.
GwonHyeok
pushed a commit
to learners-superpumped/openclaw
that referenced
this pull request
Feb 15, 2026
… thanks @shadril238 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test Co-authored-by: shadril238 <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
GwonHyeok
pushed a commit
to learners-superpumped/openclaw
that referenced
this pull request
Feb 15, 2026
…aw#12027) thanks @shadril238" (openclaw#16183) This reverts commit 386bb0c.
cloud-neutral
pushed a commit
to cloud-neutral-toolkit/openclawbot.svc.plus
that referenced
this pull request
Feb 15, 2026
… thanks @shadril238 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test Co-authored-by: shadril238 <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>
Benkei-dev
pushed a commit
to Benkei-dev/openclaw
that referenced
this pull request
Feb 15, 2026
…aw#12027) thanks @shadril238" (openclaw#16183) This reverts commit 386bb0c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11766
Problem
Documentation states "If the file is missing, the heartbeat still runs and the model decides what to do." However, workspace initialization was auto-creating HEARTBEAT.md from a template containing only comments/headers, causing heartbeat to be silently disabled.
Solution
Remove HEARTBEAT.md from workspace initialization. The file should only exist if the user explicitly creates it with tasks.
Testing
Behavior After Fix
Greptile Overview
Greptile Summary
This PR updates
ensureAgentWorkspace(src/agents/workspace.ts) to stop auto-creatingHEARTBEAT.mdfrom the workspace templates during workspace initialization, aligning behavior with the docs (“if missing, heartbeat still runs”). It removes HEARTBEAT.md from the “brand new workspace” detection list and from the set of files written viawriteFileIfMissing, while keeping other bootstrap files (AGENTS/SOUL/TOOLS/IDENTITY/USER and BOOTSTRAP on first init) unchanged.Confidence Score: 4/5
ensureAgentWorkspacestill exposesheartbeatPath/heartbeat bootstrap naming even though the file is no longer created or returned, which can mislead callers and future changes.