refactor(channels): remove v2026.7.2-gated compat (flat streaming keys, group intro hint)#113533
Conversation
maintainer-approved early removal of v2026.7.2-gated compat
maintainer-approved early removal of v2026.7.2-gated compat Plugin SDK surface baseline update is maintainer-approved for this intentional removal.
openclaw-barnacle
Bot
added
docs
|
@clawsweeper re-review The previous review lease expired without replacing the start placeholder with a verdict or Rank-up moves. |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
clawsweeper
Bot
added
rating: 🦪 silver shellfish
|
Codex review: needs real behavior proof before merge. Reviewed July 25, 2026, 3:42 AM ET / 07:42 UTC. ClawSweeper reviewWhat this changesThis PR makes channel runtime accept only nested Merge readiness⛔ Blocked until real behavior proof from a real setup is added - 6 items remain Keep this PR open for explicit maintainer release/SDK compatibility confirmation. It deliberately removes fallback behavior and one public channel adapter, while the supplied context does not independently establish that external plugin authors received a shipped deprecation window; the Priority: P1 Review scores
Verification
How this fits togetherChannel configuration is parsed by channel plugins and shared streaming resolvers before auto-reply delivery renders partial, block, or progress output. Doctor is the upgrade boundary that rewrites legacy configuration into the canonical nested form before runtime consumes it. flowchart LR
A[User channel configuration] --> B[Doctor migration]
B --> C[Canonical nested streaming config]
A --> D[Channel plugin schema]
C --> E[Shared streaming resolvers]
D --> E
E --> F[Auto-reply delivery]
F --> G[Channel messages]
Decision needed
Why: This is an intentional compatibility and plugin-contract change rather than a mechanical defect; the PR body asserts early approval, but the supplied visible discussion does not provide the decision or its upgrade rationale. Before merge
Agent review detailsSecurityNone. PR surfaceSource -170, Tests -222, Docs -2, Generated 0. Total -394 across 26 files. View PR surface stats
Review metrics
Stored data modelPersistent data-model change detected: Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep one documented, shipped deprecation window for external plugin-facing fallbacks and the adapter, or obtain explicit owner approval that v2026.7.2 intentionally makes this breaking SDK/config transition and that doctor migration is sufficient for upgrades. Do we have a high-confidence way to reproduce the issue? Yes, from source: start with an external channel entry that uses a retired scalar or flat streaming form, then run the updated runtime without doctor normalization; the proposed resolver no longer reads that shape. A live current-head terminal reproduction was not included in the supplied evidence. Is this the best way to solve the issue? Unclear: nested-only runtime plus doctor-owned migration is the maintainable architecture, but early removal is not yet shown to be the best upgrade path for the published plugin/config contract. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 749dbcb2a7bf. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
ClawSweeper rank-up moves and compatibility decision resolved for landing:
No ClawSweeper implementation finding remains; this is the explicit v2026.7.2 SDK/config decision requested by the review. |
|
Merged via squash.
|
…s, group intro hint) (openclaw#113533) * refactor(channels): remove flat streaming compat maintainer-approved early removal of v2026.7.2-gated compat * refactor(channels): remove group intro hint adapter maintainer-approved early removal of v2026.7.2-gated compat Plugin SDK surface baseline update is maintainer-approved for this intentional removal.
1 participant
What Problem This Solves
Channel runtime still carried short-lived v2026.7.2 compatibility branches for flat streaming keys and the deprecated group-introduction hint even though migration ownership now belongs in doctor.
Supersedes the older held draft #107656 with the current reviewed scope and the maintainer-approved early-removal decision.
Why This Change Was Made
This AI-assisted, maintainer-approved early removal makes runtime consume only canonical nested
streaming.*configuration, keeps the key migration in doctor, and removes the deprecated group-intro adapter member.User Impact
Current canonical configurations behave the same. Configurations with the removed flat keys must be normalized through
openclaw doctor --fix; runtime no longer silently reads the old shape.Release-note context: channel streaming configuration now has one canonical nested runtime shape, with legacy repair owned by doctor.
Evidence
tbx_01kybcm321ng7e999xg4s7b660, Actions run 30137601175.src/channelsunit-fast loader/mock quirk reproduced separately; no failing file overlaps this patch, while focused proof and the authoritative changed gate are green.