fix(ui): fall back to updateAvailable.latestVersion for handoff version verification#112987
Open
xydigit-sj wants to merge 1 commit into
Open
fix(ui): fall back to updateAvailable.latestVersion for handoff version verification#112987xydigit-sj wants to merge 1 commit into
xydigit-sj wants to merge 1 commit into
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(ui): fall back to updateAvailable.latestVersion for handoff version verification This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87889
Supersedes #87968
What Problem This Solves
When a managed-service handoff is started, the gateway returns
ok=truewithresult.status="skipped"andreason="managed-service-handoff-started", but it does not always includeresult.after.version. On currentmain,pendingUpdateExpectedVersionbecomesnullin that case, so the post-restart verification path cannot detect a version mismatch.Why This Change Was Made
runUpdatenow falls back tosnapshot.updateAvailable.latestVersionwhen the handoff response omitsafter.version. This keeps version verification active even when the gateway handoff payload is minimal.User Impact
Dashboard users whose managed-service handoff response lacks an explicit
after.versionwill now still see a version-mismatch banner if the restarted gateway does not match the advertised latest version. There is no change whenafter.versionis present.Evidence
ui/src/app/overlays.test.tsthat simulates a handoff response withoutafter.version, suppliesupdateAvailable.latestVersion, and asserts the verification banner is shown when the reconnect version differs.node scripts/run-vitest.mjs ui/src/app/overlays.test.ts— pass (10/10).oxfmt --checkandoxlinton changed files — pass.