fix(cli): report startup, argument, and signal failures#112210
Merged
Conversation
steipete
marked this pull request as ready for review
July 21, 2026 07:58
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(cli): report startup, argument, and signal failures This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Contributor
Author
|
Land-ready proof for head
The latest ClawSweeper comment restarted as a review-start placeholder and contained no final findings or |
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112205
Closes #112206
Closes #112207
What Problem This Solves
Fixes three CLI failure paths that previously reported misleading success or generic failure statuses:
health,status,sessions, andagents listsilently ignored unsupported flags;Why This Change Was Made
Gateway duplicate-instance success is now confined to the explicit supervisor-recovery boundary; ordinary foreground lock and port conflicts exit 1. Route-first parsers validate their complete supported argv shape and defer unsupported input to the normal Commander parser. Both launcher implementations preserve the first gracefully forwarded SIGINT/SIGTERM while retaining exit 1 for spawn errors and hard-kill backstops.
The Gateway TLS supervisor probe is non-mutating and retries fingerprint discovery while the lock-owning Gateway finishes certificate generation. Existing bare
openclaw agents --jsonbehavior remains supported.User Impact
Shell scripts and supervisors can now trust the CLI exit status:
Evidence
run_3e83ca8ddd20executed 1,063 cases across broad CLI grammar, JSON output, config atomicity, completion generation, file inputs, real OpenAI concurrency, two isolated Gateways, 30 in-process restarts, a 600-call read soak, diagnostics, collisions, and resource cleanup. The run directly reproduced all three fixed defects.run_cb6a78e6864dpassed Gateway collision exit 1, all four routed unknown-option failures, retained bareagents --json, and early SIGINT/SIGTERM exits 130/143.tbx_01ky1ssr8fwr4n5racdxa616jp/ Actions run 29811216524 passed formatting, script declarations, plugin boundaries, dependency guards,tsgo:all, full core/extensions/scripts lint, storage guards, and import-cycle checks.run_516faadc2bd1passed.git diff --check: passed.