Skip to content

chore(ci): audit dependency fingerprint exports#112190

Merged
vincentkoc merged 1 commit into
mainfrom
cleanup/knip-deadcode-sweep-20260721a
Jul 21, 2026
Merged

chore(ci): audit dependency fingerprint exports#112190
vincentkoc merged 1 commit into
mainfrom
cleanup/knip-deadcode-sweep-20260721a

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The repository script export audit did not model the dependency-fingerprint action as an executable entrypoint. That allowed its unused named export to survive even though every real consumer executes the file directly.

Why This Change Was Made

Register the action in the dedicated script-export Knip config and keep computeDependencyFingerprint internal to its CLI module. The implementation and executable behavior are unchanged.

User Impact

No user-visible behavior changes. Maintainers now get a failing dead-code export gate if this action grows another unused module export.

Evidence

  • Before removal, the updated Knip entry-export audit reported exactly:
    • .github/actions/setup-node-env/dependency-fingerprint.mjs: computeDependencyFingerprint
  • After removal, the same Knip command passes with zero findings.
  • OPENCLAW_LOCAL_CHECK_MODE=throttled node scripts/run-vitest.mjs test/scripts/check-deadcode-exports.test.ts test/scripts/ci-workflow-guards.test.ts
    • 111 passed, 1 skipped.
  • The action produced the same deterministic v2-<sha256> value across repeated executions.
  • oxfmt --check passed for all three changed files.
  • Structured autoreview: clean, no accepted or actionable findings.
  • Blacksmith Testbox warmup was attempted twice but GitHub returned HTTP 429 while Testbox fetched ci-check-testbox.yml; hosted CI remains required before merge.

@vincentkoc vincentkoc self-assigned this Jul 21, 2026
@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jul 21, 2026
@clawsweeper

clawsweeper Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: chore(ci): audit dependency fingerprint exports This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc
vincentkoc marked this pull request as ready for review July 21, 2026 07:12
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready verification for a5c4acb1011b177d1eccd2e867811decee716bc1:

  • Dedicated Knip entry-export audit passed:
    CI=1 /tmp/openclaw-knip-tool/node_modules/.bin/knip --config config/knip.scripts-exports.config.ts --include-entry-exports --include exports,nsExports,types,nsTypes,enumMembers,namespaceMembers --no-progress --reporter compact --no-config-hints
  • Focused tests passed twice, including after the final rebase:
    OPENCLAW_LOCAL_CHECK_MODE=throttled node scripts/run-vitest.mjs test/scripts/check-deadcode-exports.test.ts test/scripts/ci-workflow-guards.test.ts
    Result: 111 passed, 1 skipped.
  • Repeated action execution produced the same v2-<sha256> fingerprint.
  • oxfmt --check and git diff --check passed.
  • Fresh pre-commit autoreview completed with no accepted or actionable findings.
  • Exact-head hosted CI passed, including openclaw/ci-gate: https://github.com/openclaw/openclaw/actions/runs/29809607475

Blacksmith Testbox warmup was attempted twice but GitHub returned HTTP 429 while fetching the workflow. No required validation was downgraded: the repo landing wrapper accepted the completed exact-head hosted CI run.

@vincentkoc
vincentkoc merged commit 1d28128 into main Jul 21, 2026
155 of 158 checks passed
@vincentkoc
vincentkoc deleted the cleanup/knip-deadcode-sweep-20260721a branch July 21, 2026 07:18
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

vincentkoc added a commit that referenced this pull request Jul 21, 2026
* origin/main: (24 commits)
  fix(agents): keep compaction on live session model (#95713)
  fix(plugin-sdk): guard provider catalog live URL parsing against malformed responses (#109986)
  chore(cli): drop dead classifiers and single-use wrappers left by fallback removal (#112191)
  feat(ui): expand the lobster pet's random universe (#112073)
  chore(ci): audit dependency fingerprint exports (#112190)
  fix(ui): preserve graphemes in provider icons (#109509)
  fix(ui): align settings search with navigation rows (#112172)
  fix(agents): allow configless gateway rebind to activate standalone owner (#111841)
  fix(secrets): register secret targets for installed-origin plugins (#104347)
  improve(ui): show real machine identity in the place picker (#112162)
  fix: webChat scrollback history is too limited — older assistant replies and tool outputs disappear when scrolling… (#104250)
  test(ui): run DOM-free suites in Node (#112031)
  feat(nodes): make computer.act eligibility capability-based for desktop nodes (#112107)
  fix(apps): harden mobile gateway and watch state
  fix(ci): restore Z.AI API Platform validation (#112171)
  fix(ui): prevent Logs controls from overlapping (#112170)
  fix #95291: message tool fails to deliver files/images on Feishu (400 volc-dcdn / write ECONNRESET) while same Lark SDK upload succeeds standalone (#95514)
  refactor(cli)!: remove automatic gateway→embedded fallback from openclaw agent (#112074)
  refactor: move provider transports into packages/ai behind a typed host port (#111669)
  fix(anthropic): complete transcript reverse-scan windows across short reads (#109431)
  ...
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant