fix(ui): prevent Logs filters overlapping entries at larger text scales#112170
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(ui): prevent Logs filters overlapping entries at larger text scales This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
vincentkoc
marked this pull request as ready for review
July 21, 2026 06:27
Member
Author
|
Merged via squash.
|
vincentkoc
added a commit
that referenced
this pull request
Jul 21, 2026
* origin/main: (24 commits) fix(agents): keep compaction on live session model (#95713) fix(plugin-sdk): guard provider catalog live URL parsing against malformed responses (#109986) chore(cli): drop dead classifiers and single-use wrappers left by fallback removal (#112191) feat(ui): expand the lobster pet's random universe (#112073) chore(ci): audit dependency fingerprint exports (#112190) fix(ui): preserve graphemes in provider icons (#109509) fix(ui): align settings search with navigation rows (#112172) fix(agents): allow configless gateway rebind to activate standalone owner (#111841) fix(secrets): register secret targets for installed-origin plugins (#104347) improve(ui): show real machine identity in the place picker (#112162) fix: webChat scrollback history is too limited — older assistant replies and tool outputs disappear when scrolling… (#104250) test(ui): run DOM-free suites in Node (#112031) feat(nodes): make computer.act eligibility capability-based for desktop nodes (#112107) fix(apps): harden mobile gateway and watch state fix(ci): restore Z.AI API Platform validation (#112171) fix(ui): prevent Logs controls from overlapping (#112170) fix #95291: message tool fails to deliver files/images on Feishu (400 volc-dcdn / write ECONNRESET) while same Lark SDK upload succeeds standalone (#95514) refactor(cli)!: remove automatic gateway→embedded fallback from openclaw agent (#112074) refactor: move provider transports into packages/ai behind a typed host port (#111669) fix(anthropic): complete transcript reverse-scan windows across short reads (#109431) ...
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where users opening Logs in the macOS app or a narrow Control UI window at a larger text scale could see the file path, severity filters, and log entries overlap after navigating from Settings.
Why This Change Was Made
The Logs fill-height rules now load with the Logs page instead of arriving as a side effect of the Config page stylesheet. The two control rows keep their content height while the log stream remains the flexible, scrollable region. No macOS shell change is needed because the app embeds the shared Control UI.
User Impact
Logs remain readable and usable in the macOS dashboard viewport and narrow browser windows, including at 125% text scale. Filters wrap normally without log entries rendering through them.
Evidence
Before: the new native-layout E2E reproduced the overlap at
863x584and 125% text scale after navigatingSettings -> Logs; it failed because a control row hadscrollHeight 69insideclientHeight 49.After: the same E2E passes and records non-overlapping control rows plus the scrollable log stream.
Visual proof:
Before recording · After recording · Proof bundle
node scripts/run-vitest.mjs run --config test/vitest/vitest.ui-e2e.config.ts --configLoader runner ui/src/e2e/logs-layout.e2e.test.ts ui/src/e2e/logs-autofollow.e2e.test.ts- 2 tests passed.node scripts/run-vitest.mjs run ui/src/pages/logs/view.test.ts ui/src/pages/logs/logs-page.test.ts- 12 tests passed.Blacksmith Testbox production build passed, including Control UI asset and performance checks: https://github.com/openclaw/openclaw/actions/runs/29805732387
Blacksmith Testbox
node scripts/run-tsgo.mjs -b tsconfig.projects.json- exit 0.oxfmt --checkandgit diff --checkpassed.Fresh branch autoreview: no accepted/actionable findings.
AI-assisted: yes.