feat: add NVIDIA Nemotron Speech ASR and TTS#112078
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 21, 2026, 1:43 AM ET / 05:43 UTC. Summary PR surface: Source +498, Tests +344, Docs +152. Total +994 across 13 files. Reproducibility: yes. from source: an existing configuration with NVIDIA auth and automatic media audio enabled can become eligible for the newly registered NVIDIA audio provider through its default model and auto-priority. The PR does not include a live upgrade-path demonstration confirming that this routing change is intended. Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review findings
Review detailsBest possible solution: Keep NVIDIA ASR/TTS in the existing NVIDIA plugin, but make automatic transcription opt-in through explicit audio configuration unless maintainers deliberately approve credential-only auto-selection and its privacy, routing, and upgrade behavior. Do we have a high-confidence way to reproduce the issue? Yes, from source: an existing configuration with NVIDIA auth and automatic media audio enabled can become eligible for the newly registered NVIDIA audio provider through its default model and auto-priority. The PR does not include a live upgrade-path demonstration confirming that this routing change is intended. Is this the best way to solve the issue? No, not yet. Reusing the existing NVIDIA plugin and credential is the right ownership boundary, but automatic ASR selection needs an explicit compatibility decision or an opt-in configuration path before it is the safest solution. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against b521a85d85f6. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +498, Tests +344, Docs +152. Total +994 across 13 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
What Problem This Solves
NVIDIA users could configure NVIDIA-hosted chat models, but could not reuse the same NVIDIA credential for OpenClaw's batch speech-to-text and text-to-speech workflows. This prevented inbound audio from using Parakeet and outbound spoken replies from using Magpie through the NVIDIA plugin.
Why This Change Was Made
This extends the existing NVIDIA plugin with one-shot HTTP Parakeet ASR and Magpie TTS providers. It follows OpenClaw's media and speech provider contracts, reuses shared NVIDIA authentication, normalizes unsupported inbound formats through trusted FFmpeg discovery, and deliberately does not register realtime or streaming speech providers.
User Impact
Users can now:
Documentation now covers setup, supported formats, customization, hosted endpoint overrides, and provider capabilities.
Evidence
Focused NVIDIA speech tests pass:
Command:
The branch was also checked with
git diff --check upstream/main...HEAD.