fix(memory): filter assistant process chatter from dreams#111922
fix(memory): filter assistant process chatter from dreams#111922ArthurNie wants to merge 1 commit into
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 20, 2026, 1:54 PM ET / 17:54 UTC. Summary PR surface: Source +13, Tests +143. Total +156 across 2 files. Reproducibility: yes. at source level: current main accepts normalized session lines after only the minimum-length check, and the linked report supplies concrete assistant-process examples that reach this ingestion path. I did not run a live Dreaming sweep in this read-only review. Review metrics: none identified. Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Keep the conservative exact-prefix, fully anchored ingestion filter and add a redacted terminal capture or runtime log from a controlled Dreaming sweep that shows the corpus output and preserved durable content. Do we have a high-confidence way to reproduce the issue? Yes at source level: current main accepts normalized session lines after only the minimum-length check, and the linked report supplies concrete assistant-process examples that reach this ingestion path. I did not run a live Dreaming sweep in this read-only review. Is this the best way to solve the issue? Yes. A narrowly anchored filter at session-corpus ingestion is the smallest maintainable fix for the reported forward-contamination path, and the branch deliberately preserves durable assistant statements and non-exact lookalikes. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against ea148e728db3. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +13, Tests +143. Total +156 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
What Problem This Solves
Ordinary assistant scratch/process notes can currently enter
memory/.dreams/session-corpus/*and feed Light/REM/Deep candidate surfaces. This creates low-value Dreaming inputs and can promote execution chatter rather than durable session content.This PR fixes the forward-ingestion path without changing transcript, SDK, or persisted-state schemas. The matcher intentionally covers only the reported terse operational forms; broader semantic classification and historical corpus cleanup remain out of scope.
Summary
Assistant:prefix and fully anchored conservative grammarEvidence
Local verification on commit
b1638d97cca5bcf5361f2a7584ad65ad4b4ad38a:./node_modules/.bin/oxfmt --check extensions/memory-core/src/dreaming-phases.ts extensions/memory-core/src/dreaming-phases.test.tsgit diff --check./node_modules/.bin/oxlint --tsconfig config/tsconfig/oxlint.extensions.json extensions/memory-core/src/dreaming-phases.ts extensions/memory-core/src/dreaming-phases.test.ts./node_modules/.bin/vitest run extensions/memory-core/src/dreaming-phases.test.ts— 47/47 passedpnpm tsgo:extensions:testThe corpus regression covers rejected chatter, preserved durable assistant outcomes, user and lowercase-prefix lookalikes, original source-line references, and cursor advancement through filtered entries.
Closes #80664