Skip to content

fix(release): accept package tarballs with large entry lists#111672

Merged
fuller-stack-dev merged 1 commit into
mainfrom
codex/package-tarball-large-list
Jul 20, 2026
Merged

fix(release): accept package tarballs with large entry lists#111672
fuller-stack-dev merged 1 commit into
mainfrom
codex/package-tarball-large-list

Conversation

@fuller-stack-dev

@fuller-stack-dev fuller-stack-dev commented Jul 20, 2026

Copy link
Copy Markdown
Member

What Problem This Solves

Fixes an issue where release and package-acceptance checks rejected otherwise valid self-contained OpenClaw tarballs when their archive entry listing exceeded Node's default child-process capture buffer.

Why This Change Was Made

The checker now gives only tar -tf a bounded 64 MiB capture buffer, matching the existing npm release-check capture limit, while keeping the current synchronous inventory-validation path. Spawn failures also retain the child error message when no exit status or stderr is available; package contents and plugin bundling are unchanged.

User Impact

Release operators can validate larger self-contained deployment artifacts without the checker terminating at Node's 1 MiB default output limit. Malformed archives and nonzero tar exits continue to fail with actionable diagnostics.

Evidence

  • Before the patch, a valid fixture whose tar -tf output measured 1,160,784 bytes failed with status 1 and tar -tf failed ...: null.
  • After the patch, the same fixture passed with OpenClaw package tarball integrity passed.
  • Blacksmith Testbox run 29719088844: all 35 focused checker tests passed, including the large-list regression and existing extraction-failure cleanup case; oxfmt passed on both touched files; oxlint reported 0 warnings and 0 errors.
  • git diff --check upstream/main...HEAD and node --check scripts/check-openclaw-package-tarball.mjs passed after the final rebase.
  • Autoreview: $autoreview --mode branch --base upstream/main returned no accepted/actionable findings on the final diff.

Real behavior proof

Behavior addressed: Valid package tarballs no longer fail validation solely because their entry listing exceeds Node's default 1 MiB spawnSync capture limit.

Real environment tested: Local macOS tar/Node execution and delegated Blacksmith Linux Node 24 Testbox.

Exact steps or command run after this patch: Generated a valid OpenClaw fixture with 8,000 additional archive entries, measured tar -tf output, ran node scripts/check-openclaw-package-tarball.mjs <fixture.tgz>, then ran pnpm test test/scripts/check-openclaw-package-tarball.test.ts -- --reporter=verbose on Testbox.

Evidence after fix: The real listing was 1,160,784 bytes; the checker exited 0, and all 35 focused tests passed on Testbox run 29719088844.

Observed result after fix: The large valid tarball passed; malformed tarballs and the existing fake nonzero extraction path still failed with their tar diagnostics, and failed extraction cleanup remained green.

What was not tested: The full release-validation or Package Acceptance workflow was not dispatched because this change is isolated to the checker process buffer and its direct test project.

@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts size: XS maintainer Maintainer-authored PR labels Jul 20, 2026
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. labels Jul 20, 2026
@clawsweeper

clawsweeper Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed July 20, 2026, 1:33 AM ET / 05:33 UTC.

Summary
The branch raises the bounded tar -tf capture limit to 64 MiB, improves spawn-failure diagnostics, and adds a regression test for tarballs whose entry listing exceeds Node’s default buffer.

PR surface: Tests +31, Other +3. Total +34 across 2 files.

Reproducibility: yes. —source reproduction is high confidence: a valid tarball whose tar -tf output exceeds 1 MiB triggers Node’s default capture limit on current main, and the added test constructs that condition. This review did not execute the fixture itself.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P2] Protected maintainer/release handling remains necessary; no narrow mechanical repair is indicated by this review.

Maintainer decision needed

  • Question: Should the release-check owner accept the 64 MiB bounded capture limit for valid package-tarball listings?
  • Rationale: The patch is narrow and source-backed, but the MEMBER-authored PR carries the repository’s maintainer label and changes release validation behavior.
  • Likely owner: fuller-stack-dev — They are the only evidenced current contributor for this focused release-check path in the supplied review material.
  • Options:
    • Accept the bounded limit (recommended): Merge the focused change after normal required checks complete, retaining the 64 MiB ceiling as the explicit guard against unbounded capture.
    • Choose another release-policy cap: Request a different documented limit only if release operators have a stricter memory-budget requirement for package acceptance.

Security
Cleared: The diff changes only a bounded child-process output limit and diagnostic fallback; it adds no dependency, permission, secret, download, or code-execution surface.

Review details

Best possible solution:

Land the bounded listing-buffer fix after a release owner confirms that the existing 64 MiB package-check ceiling is the intended operational limit.

Do we have a high-confidence way to reproduce the issue?

Yes—source reproduction is high confidence: a valid tarball whose tar -tf output exceeds 1 MiB triggers Node’s default capture limit on current main, and the added test constructs that condition. This review did not execute the fixture itself.

Is this the best way to solve the issue?

Yes. Applying a finite maxBuffer only to the archive-listing subprocess fixes the defined failure without changing package contents, validation rules, configuration, or the synchronous checker design.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against a22ede72e494.

Label changes

Label changes:

  • add P2: A valid release artifact can be rejected by package acceptance, but the failure is confined to release-validation tooling and has a bounded repair.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This is a MEMBER-authored PR, so contributor-proof gating does not apply; nevertheless, the PR body records an after-fix real tarball run and Testbox validation.

Label justifications:

  • P2: A valid release artifact can be rejected by package acceptance, but the failure is confined to release-validation tooling and has a bounded repair.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This is a MEMBER-authored PR, so contributor-proof gating does not apply; nevertheless, the PR body records an after-fix real tarball run and Testbox validation.
Evidence reviewed

PR surface:

Tests +31, Other +3. Total +34 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 1 31 0 +31
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 1 4 1 +3
Total 2 35 1 +34

What I checked:

Likely related people:

  • fuller-stack-dev: The available concrete history identifies this MEMBER as author of the focused release-check change; no older file-history provenance was available in the read-only review harness. (role: current release-check contributor; confidence: low; commits: b3354702205a; files: scripts/check-openclaw-package-tarball.mjs, test/scripts/check-openclaw-package-tarball.test.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@fuller-stack-dev fuller-stack-dev self-assigned this Jul 20, 2026
@fuller-stack-dev
fuller-stack-dev force-pushed the codex/package-tarball-large-list branch from b335470 to bf47ade Compare July 20, 2026 19:12
@fuller-stack-dev
fuller-stack-dev merged commit e2bb043 into main Jul 20, 2026
98 checks passed
@fuller-stack-dev
fuller-stack-dev deleted the codex/package-tarball-large-list branch July 20, 2026 19:21
@fuller-stack-dev

fuller-stack-dev commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

Merged via squash.

@github-actions github-actions Bot mentioned this pull request Jul 20, 2026
Open
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 21, 2026
@fuller-stack-dev
fix(release): accept large tarball entry lists (openclaw#111672)
7f89746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fuller-stack-dev fuller-stack-dev

Labels

maintainer Maintainer-authored PR P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. scripts Repository scripts size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fuller-stack-dev @Patrick-Erichsen