Skip to content

fix(ui): redesign the who's-online roster menu#111668

Merged
steipete merged 1 commit into
mainfrom
steipete/team-picker-redesign-8e7066
Jul 20, 2026
Merged

fix(ui): redesign the who's-online roster menu#111668
steipete merged 1 commit into
mainfrom
steipete/team-picker-redesign-8e7066

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

The footer "who's online" roster menu (team picker) in the Control UI looked unpolished: it relied on Web Awesome's default dropdown chrome instead of the app's menu styling, so its padding, corner radius, and background didn't match the sibling sidebar menus. The title didn't share a left edge with the rows (Web Awesome reserves a checkmark gutter for informational people rows), the 20px footer-size avatars were undersized for two-line name+email rows, and the name/email hierarchy was flat.

Why This Change Was Made

CSS-only redesign of .presence-roster-menu in ui/src/styles/layout.css, aligning it with the sidebar's other fixed menus (customize/session menus):

  • Menu chrome matches app menus: 6px padding, --radius-lg, --bg-elevated, --border-strong hairline, --shadow-lg, 232–288px width.
  • The Web Awesome checkmark gutter is hidden (::part(checkmark)) and item metrics are overridden so the title, avatars, and text share one left edge.
  • Roster avatars grow to 26px (two-line row scale) and carry an online status dot; the circle clips via the child image/initials so the badge can overflow the wrapper.
  • Names get --text at weight 500 over the muted email subtitle; hover/focus rows use the app's standard --bg-hover mix with --radius-md.

User Impact

The online-roster popover from the sidebar footer facepile now reads like a native part of the app: consistent chrome, aligned columns, clearer name/email hierarchy, and an at-a-glance online indicator per person. No behavior change.

Evidence

Before / after (dark), after (light) — captured via the mock-gateway dev harness with an injected 3-user presence payload:

Before After After (light)
before after after light
  • node scripts/run-vitest.mjs ui/src/components/viewer-facepile.test.ts — 6/6 passed.
  • oxfmt --check ui/src/styles/layout.css — clean; git diff --check clean.
  • Codex autoreview (gpt-5.6-sol, branch vs origin/main) — clean, no findings.

@steipete
steipete marked this pull request as ready for review July 20, 2026 05:13
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: S maintainer Maintainer-authored PR labels Jul 20, 2026
@clawsweeper clawsweeper Bot added proof: sufficient ClawSweeper judged the real behavior proof convincing. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels Jul 20, 2026
@clawsweeper

clawsweeper Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed July 20, 2026, 1:16 AM ET / 05:16 UTC.

Summary
The PR restyles the Control UI presence-roster popover with aligned menu chrome, larger status-marked avatars, and clearer two-line person rows.

PR surface: Source +54. Total +54 across 1 file.

Reproducibility: not applicable. the PR changes presentational styling, and its supplied captures directly show the intended before/after UI state.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster ✨ media proof bonus
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P2] A protected maintainer label requires an explicit human visual decision; there is no narrow mechanical repair for ClawSweeper to queue.

Maintainer decision needed

  • Question: Should this maintainer-labeled roster-menu polish be accepted after a final human visual review of the Control UI popover?
  • Rationale: The patch has no identified mechanical blocker, but the protected label requires explicit maintainer judgment rather than automated disposition of UI direction and visual standards.
  • Likely owner: steipete — They are the strongest available routing candidate for the intended UI treatment and current implementation.
  • Options:
    • Accept the polish (recommended): Merge after confirming the supplied dark- and light-theme captures represent the intended Control UI menu treatment.
    • Request a visual adjustment: Keep the PR open with a specific design correction if the menu chrome, row alignment, or status indicator does not meet the maintained UI standard.

Security
Cleared: The patch is limited to Control UI CSS and introduces no dependency, permission, secret, execution, or supply-chain change.

Review details

Best possible solution:

Retain the CSS-only implementation if a maintainer’s final visual check confirms it matches the intended sidebar-menu language at supported viewport sizes and themes.

Do we have a high-confidence way to reproduce the issue?

Not applicable: the PR changes presentational styling, and its supplied captures directly show the intended before/after UI state.

Is this the best way to solve the issue?

Yes: keeping the change CSS-only is the narrowest maintainable way to align this existing roster popover with adjacent Control UI menus without changing presence behavior.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against bdf71d7d98b6.

Label changes

Label changes:

  • add P3: The change is contained visual polish with no reported functional regression or user-data impact.
  • add proof: sufficient: Contributor real behavior proof is sufficient. The PR includes direct before/after screenshots of the roster menu in dark and light themes using an injected three-user presence payload.
  • add proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. The PR includes direct before/after screenshots of the roster menu in dark and light themes using an injected three-user presence payload.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (screenshot): The PR includes direct before/after screenshots of the roster menu in dark and light themes using an injected three-user presence payload.

Label justifications:

  • P3: The change is contained visual polish with no reported functional regression or user-data impact.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (screenshot): The PR includes direct before/after screenshots of the roster menu in dark and light themes using an injected three-user presence payload.
  • proof: sufficient: Contributor real behavior proof is sufficient. The PR includes direct before/after screenshots of the roster menu in dark and light themes using an injected three-user presence payload.
  • proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. The PR includes direct before/after screenshots of the roster menu in dark and light themes using an injected three-user presence payload.
Evidence reviewed

PR surface:

Source +54. Total +54 across 1 file.

View PR surface stats
Area Files Added Removed Net
Source 1 60 6 +54
Tests 0 0 0 0
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 1 60 6 +54

What I checked:

  • Focused UI surface: The proposed branch changes only the presence-roster CSS rules, keeping roster behavior and data flow outside the patch boundary. (ui/src/styles/layout.css:1982, f7a450a675a5)
  • After-fix behavior proof: The PR body supplies before/after captures for a three-user injected presence payload in dark and light themes, directly demonstrating the claimed visual result. (f7a450a675a5)
  • Repository handling signal: The item carries the protected maintainer label, which requires explicit maintainer handling and rules out automated close cleanup. (f7a450a675a5)
  • Current contributor history: Repository activity identifies steipete as a recurring contributor to current main, supporting routing to them for the intended UI direction, although the available history did not establish sole ownership of this CSS area. (ui/src/styles/layout.css:1982, f7a450a675a5)

Likely related people:

  • steipete: Authored this focused roster styling change and appears repeatedly in current repository activity; ownership of the existing roster surface is otherwise not established by the available history. (role: recent core contributor and current UI-direction contact; confidence: low; commits: f7a450a675a5; files: ui/src/styles/layout.css)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete
steipete merged commit a22ede7 into main Jul 20, 2026
187 of 200 checks passed
@steipete
steipete deleted the steipete/team-picker-redesign-8e7066 branch July 20, 2026 05:24
@steipete

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: S status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant