fix(lint): preserve caught error in memory-lancedb loadLanceDB#11061
Closed
leszekszpunar wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(lint): preserve caught error in memory-lancedb loadLanceDB#11061leszekszpunar wants to merge 1 commit intoopenclaw:mainfrom
leszekszpunar wants to merge 1 commit intoopenclaw:mainfrom
Conversation
This was referenced Feb 7, 2026
Contributor
Author
|
Closing -- #11093 (merged) excluded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
{ cause: err }to the re-thrownErrorinloadLanceDB()to satisfy thepreserve-caught-erroroxlint rule. This one-line fix unblocks CI lint checks for 9 open PRs that are currently failing solely due to this pre-existing violation onmain.Closes #11060
Behavior Changes
None. The original error is now chained via the standard ES2022
causeproperty instead of being discarded. This preserves the full error stack for debugging while satisfying the lint rule.Codebase and GitHub Search
Searched for other
preserve-caught-errorviolations -- this is the only instance blocking CI. Other lint errors in the repo are separate issues (type-aware rules in extensions).Tests
pnpm lint: confirmedpreserve-caught-errorcount drops from 1 to 0 after this change.Impact
Currently blocked PRs (lint-only failures): #11001, #11009, #11026, #11027, #11028, #11033, #11046.
Partially blocked (lint + other failures): #11032, #11035.
lobster-biscuit
Greptile Overview
Greptile Summary
extensions/memory-lancedb/index.tsto rethrow the LanceDB dynamic import failure with an ES2022 errorcause, satisfying thepreserve-caught-erroroxlint rule.Confidence Score: 5/5
Errorcause chaining; no new control flow or API changes were introduced, and the diff is isolated to a single catch/rethrow site.Context used:
dashboard- CLAUDE.md (source)dashboard- AGENTS.md (source)