feat(ios): harvest shared chat capabilities — verbosity, trace toggle, live talk level, sessions entry#110254
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 17, 2026, 9:40 PM ET / July 18, 2026, 01:40 UTC. Summary PR surface: Docs +1, Other +340. Total +341 across 28 files. Reproducibility: not applicable. as a bug reproduction: this PR adds iOS capability wiring. The supplied unit test clearly covers the verbosity request shape, but no real iOS runtime artifact demonstrates the new UI flows. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Confirm that iOS should adopt the macOS-style default-on local trace preference, then attach redacted simulator or device proof showing the trace toggle, talk-level animation, session selection, and persisted verbosity behavior. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: this PR adds iOS capability wiring. The supplied unit test clearly covers the verbosity request shape, but no real iOS runtime artifact demonstrates the new UI flows. Is this the best way to solve the issue? Unclear. Reusing the merged macOS/shared-chat pattern is a narrow implementation path, but a maintainer must confirm that its persisted default-on trace preference is the intended iOS product contract. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against cf63c83bf68c. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Docs +1, Other +340. Total +341 across 28 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
02b3082 to
28c75c2
Compare
28c75c2 to
caa8387
Compare
|
Merged via squash.
|
…, live talk level, sessions entry (openclaw#110254) * feat(ios): wire verbosity, assistant trace toggle, live talk level, and chat-local sessions entry * chore(i18n): translate new iOS chat strings and regenerate catalogs
What Problem This Solves
Several capabilities that already exist in the shared chat package or on macOS never reached iOS: the session verbosity setting is silently dropped by the iOS transport, assistant reasoning/tool traces cannot be shown at all, the talk button gives no visual feedback while listening or speaking, and reaching session management requires leaving the chat tab.
Why This Change Was Made
iOS and macOS share
OpenClawKit; this harvests recent shared-package work for iOS with small host wiring (audit-verified injection points):IOSGatewayChatTransportnow forwardsverboseLevelinsessions.patchinstead of dropping it (parity with the macOS transport fix in feat: align native macOS chat with the web chat capability set #109712).openclaw.webchat.showAssistantTracekey and default-on semantics as macOS — iOS previously never passed the flag, so traces were permanently hidden.TalkModeManager).User Impact
iPhone/iPad chat gains visible reasoning and tool activity on demand, a live talk waveform,
/verbosesettings that actually stick, and in-place session management — using code that already shipped for macOS and the shared package.Evidence
xcodebuild … test -only-testing:OpenClawTests/IOSGatewayChatTransportTests -only-testing:OpenClawTests/OpenClawTypographyTests— 23 tests, 0 failures (includes new verbosity set/clear coverage).IOS_DEST='generic/platform=iOS Simulator' pnpm ios:build— BUILD SUCCEEDED.pnpm format:swift,pnpm lint:swift,pnpm native:i18n:check, Apple/Android catalog tests — clean; the two new strings translated across all 21 locales.