fix(release): carry the Z.AI API Platform waiver#110243
Conversation
* test(ci): temporarily omit Z.AI API Platform validation * test(ci): align disabled provider count (cherry picked from commit 954c77d)
|
Codex review: needs maintainer review before merge. Reviewed July 17, 2026, 7:43 PM ET / 23:43 UTC. Summary PR surface: Tests -1, Config +3, Other 0. Total +2 across 6 files. Reproducibility: yes. from the provided release-validation diagnostic: the cited Release Checks job reproduces the failed Z.AI API Platform probes, and the changed workflow/shard paths directly encode the failing selection behavior. This review did not execute the credentialed live probes. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land the narrow frozen-branch backport only with release-owner acceptance of the temporary coverage waiver, keep the Coding Plan shard required, and remove the omission after a replacement API Platform credential passes a real completion probe. Do we have a high-confidence way to reproduce the issue? Yes, from the provided release-validation diagnostic: the cited Release Checks job reproduces the failed Z.AI API Platform probes, and the changed workflow/shard paths directly encode the failing selection behavior. This review did not execute the credentialed live probes. Is this the best way to solve the issue? Yes for the frozen release branch: it selectively carries the two already-merged main fixes, avoids the unrelated Android compatibility change, and preserves the healthy Z.AI Coding Plan proof rather than disabling Z.AI coverage wholesale. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 82fa956d5a22. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests -1, Config +3, Other 0. Total +2 across 6 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Land-ready proof at exact PR head
The waiver remains temporary and must be reverted after the replacement API Platform credential passes a real completion probe. After merge, prior preflight/validation evidence is superseded and both required canonical runs will be repeated at the new exact SHA. No tag or publication has occurred. |
What Problem This Solves
Canonical Full Release Validation
29620608973correctly used candidate-owned workflows, but Release Checks child29620688377still ran the known-broken Z.AI API Platform probes. Job88015298867reproduced the existing account outage: both global endpoint probes returned zero assistant content while 68 sibling live tests passed.The maintainer-approved temporary waiver from #109246 and its shard companion #109272 had been merged only into
mainfor the discarded temporary-harness design. Candidate-owned validation therefore needs the same release machinery frozen onextended-stable/2026.6.33.Why This Change Was Made
Two dependency-ordered commits:
954c77d4ef9d4e0f587344032eda90f694149d16:c4b2183db66f0f8f8b60edaf09f9c33b2f349a03:src/agents/zai.live.test.tsfrom the broad agents shard;No Android compatibility change is imported because the candidate-owned v6.11 CI does not need it.
User Impact
No product behavior change. Z.AI API Platform validation remains temporarily waived while its CI account is unavailable; Z.AI Coding Plan validation remains required. No provider runtime, credential, native, package, version, npm inventory, or publication code changes. The release remains npm-only.
The waiver must be reverted after the replacement API Platform credential passes a real completion probe.
Evidence
actionlint .github/workflows/openclaw-live-and-e2e-checks-reusable.ymlnode scripts/run-vitest.mjs test/scripts/package-acceptance-workflow.test.ts test/scripts/release-workflow-matrix-plan.test.ts test/scripts/test-live-shard.test.ts— 78/78 passednode_modules/.bin/oxfmt --check ...— cleangit diff --checksrc/agents/zai.live.test.ts; Coding Plan selects exactly that fileAfter merge, npm preflight and all-groups Full Release Validation will run from the new exact canonical SHA. No tag or publication has occurred.