Skip to content

fix(signal): preserve newlines in debounced messages#110090

Merged
steipete merged 2 commits into
mainfrom
codex/fix-signal-debounce-newlines
Jul 17, 2026
Merged

fix(signal): preserve newlines in debounced messages#110090
steipete merged 2 commits into
mainfrom
codex/fix-signal-debounce-newlines

Conversation

@steipete

@steipete steipete commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Problem This Solves

Fixes an issue where multiple Signal messages received inside the inbound debounce window reached the agent with visible literal \n text instead of line breaks.

Why This Change Was Made

Signal now joins both the agent-facing body and command body with real newline characters, matching sibling channel debounce behavior. The nearby verbose-log preview escape remains unchanged because logs intentionally keep the preview on one line.

The existing maintainer release-gate example is also rendered as a fenced shell command, with its generated title in inline code, so the docs gate accepts it.

AI-assisted: yes.

User Impact

Debounced Signal messages now reach the agent as distinct lines, preserving message boundaries without visible escape characters.

Release-note context: Signal debounce batches preserve message boundaries with real line breaks.

Evidence

  • Before fix: focused Signal inbound-context proof reproduced the bug with 2 failures and 45 passes; received values contained literal \n text.
  • After fix: the focused Signal file passed all 47 tests.
  • Rebased final-tree focused proof passed Signal 47/47.
  • A patch-superset remote changed gate passed selected formatting, typecheck, lint, plugin-boundary, import-cycle, state-guard, and test lanes.
  • Docs formatting and markdownlint passed all 722 files.
  • Exact-head hosted release gate 29617325982 completed all 136 jobs with zero failures.
  • Fresh final-branch autoreview: clean, no actionable findings, confidence 0.96.
  • git diff --check: passed.
  • Live Signal send/receive was not exercised because no linked Signal account was available in this task.

@openclaw-barnacle openclaw-barnacle Bot added channel: signal Channel integration: signal size: XS maintainer Maintainer-authored PR labels Jul 17, 2026
@steipete steipete self-assigned this Jul 17, 2026
@clawsweeper

clawsweeper Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 17, 2026, 6:17 PM ET / 22:17 UTC.

Summary
The branch changes debounced Signal inbound text and command bodies to join with actual newline characters, updates the affected assertions, and reformats an onboarding CI command example.

PR surface: Source 0, Tests +1, Docs +5. Total +6 across 3 files.

Reproducibility: yes. from source and focused assertions: the pre-patch debounce join used literal \\n, and the updated tests describe a two-message batch that exposes it. A real Signal account was not available here to independently reproduce the full transport path.

Review metrics: none identified.

Stored data model
Persistent data-model change detected: vector/embedding metadata: extensions/signal/src/monitor/event-handler.inbound-context.test.ts. Confirm migration or upgrade compatibility proof before merge.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P1] Add redacted after-fix evidence of two debounced Signal messages reaching the agent as separate lines.
  • If live access remains unavailable, obtain an explicit maintainer proof exception for this exact head.

Proof guidance:

  • [P1] Needs real behavior proof before merge: The contributor provides focused tests, CI, and an explicit statement that live Signal send/receive was not exercised; add a redacted Signal receive transcript, bridge log, or terminal capture before merge unless an owner records a proof exception. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Risk before merge

  • [P1] Merging changes the content delivered to agents and command parsing for every debounced Signal batch; without a real receive-path capture, the repository has no observed after-fix evidence that Signal transport preserves the intended boundaries end to end.

Maintainer options:

  1. Capture the debounced receive path (recommended)
    Before merge, add redacted live Signal evidence that a two-message batch reaches the agent with separate lines and no literal backslash-n text.
  2. Accept a documented proof exception
    A Signal owner may explicitly accept the focused regression coverage and hosted gate as adequate for this small delivery-format change.

Next step before merge

  • [P1] No mechanical patch repair is indicated; a protected-label owner must decide whether live Signal evidence is required or may be explicitly waived.

Maintainer decision needed

  • Question: Should this protected Signal PR require redacted after-fix receive-path proof, or is the focused regression coverage and hosted gate sufficient for an explicit exception?
  • Rationale: The patch changes message-delivery semantics and the contributor states that no linked Signal account was available, so only a responsible owner can accept or waive the real-behavior gate.
  • Likely owner: steipete — The author is assigned to this active Signal change and can either supply the available evidence or route the exception to the relevant owner.
  • Options:
    • Require live Signal proof (recommended): Request a redacted transcript, bridge log, or terminal capture showing two debounced inbound messages arrive at the agent with real line breaks.
    • Grant a proof exception: Accept the focused regression test and exact-head hosted CI as sufficient for this narrowly scoped fix despite no linked Signal account.

Security
Cleared: The three-file diff changes Signal string joining, assertions, and Markdown formatting; it introduces no dependency, permission, secret, workflow, or executable supply-chain surface.

Review details

Best possible solution:

Keep the narrow newline fix and obtain a redacted live Signal receive transcript or bridge/terminal capture showing a two-message debounced batch reaches the agent as separate lines; an explicit maintainer proof exception is the only safe alternative.

Do we have a high-confidence way to reproduce the issue?

Yes from source and focused assertions: the pre-patch debounce join used literal \\n, and the updated tests describe a two-message batch that exposes it. A real Signal account was not available here to independently reproduce the full transport path.

Is this the best way to solve the issue?

Yes for the code defect: changing the two debounce joins to actual newline characters is the narrowest consistent fix, and the adjacent tests cover agent text and command text. The remaining question is proof sufficiency, not an alternate implementation.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 84ff010eba9c.

Label changes

Label changes:

  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • remove rating: 🦪 silver shellfish: Current PR rating is rating: 🧂 unranked krab, so this older rating label is no longer current.

Label justifications:

  • P2: The PR fixes a limited but user-visible Signal inbound message-formatting defect without evidence of a broad outage.
  • merge-risk: 🚨 message-delivery: The patch intentionally changes the message separators supplied to agents and command handling for debounced Signal batches.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The contributor provides focused tests, CI, and an explicit statement that live Signal send/receive was not exercised; add a redacted Signal receive transcript, bridge log, or terminal capture before merge unless an owner records a proof exception. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed

PR surface:

Source 0, Tests +1, Docs +5. Total +6 across 3 files.

View PR surface stats
Area Files Added Removed Net
Source 1 2 2 0
Tests 1 5 4 +1
Docs 1 8 3 +5
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 3 15 9 +6

What I checked:

  • Changed debounce behavior: The patch changes both combined agent text and combined command text from literal backslash-n separators to newline characters, which directly addresses the reported visible escape sequences. (extensions/signal/src/monitor/event-handler.ts:731, 9cf44ef95d08)
  • Focused regression coverage: The updated Signal inbound-context test asserts newline preservation for both BodyForAgent and CommandBody, including the attachment path that checks RawBody and command text. (extensions/signal/src/monitor/event-handler.inbound-context.test.ts:386, 9cf44ef95d08)
  • Patch provenance: The functional change was introduced in commit 5cca163fcc69cf880a8d3ae63bef839901df13fe and the current head adds the separate documentation-formatting commit 9cf44ef95d08e742c467b079083591e21954e9cc. (extensions/signal/src/monitor/event-handler.ts:731, 5cca163fcc69)
  • Proof gap: The PR body explicitly says live Signal send/receive was not exercised; its focused tests, changed gate, and hosted CI are supplemental rather than real receive-path proof. (9cf44ef95d08)
  • Protected owner handling: The PR currently has the maintainer and status: 📣 needs proof labels, so automated cleanup or closure is not appropriate while the proof requirement needs owner judgment.

Likely related people:

  • steipete: Authored both commits on the current branch and is assigned to the PR; the available review context does not expose a stronger current-main feature-history owner. (role: recent Signal change contributor; confidence: medium; commits: 5cca163fcc69, 9cf44ef95d08; files: extensions/signal/src/monitor/event-handler.ts, extensions/signal/src/monitor/event-handler.inbound-context.test.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (13 earlier review cycles; latest 8 shown)
  • reviewed 2026-07-17T19:44:03.927Z sha 80a8d57 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T20:05:15.903Z sha 7424e98 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T20:14:37.375Z sha 7424e98 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T20:34:46.654Z sha 99d9013 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T21:11:25.920Z sha 58dbf79 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T21:27:04.007Z sha 58dbf79 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T21:41:16.628Z sha c39abc3 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T21:53:56.720Z sha 54786c5 :: needs real behavior proof before merge. :: none

@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Jul 17, 2026
@steipete
steipete force-pushed the codex/fix-signal-debounce-newlines branch from 603aac9 to 80a8d57 Compare July 17, 2026 19:41
@openclaw-barnacle openclaw-barnacle Bot added the app: android App: android label Jul 17, 2026
@steipete
steipete force-pushed the codex/fix-signal-debounce-newlines branch from 80a8d57 to 7424e98 Compare July 17, 2026 20:03
@openclaw-barnacle openclaw-barnacle Bot removed the app: android App: android label Jul 17, 2026
@steipete
steipete force-pushed the codex/fix-signal-debounce-newlines branch 2 times, most recently from 99d9013 to 58dbf79 Compare July 17, 2026 21:09
@clawsweeper clawsweeper Bot added merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. and removed merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. labels Jul 17, 2026
@openclaw-barnacle openclaw-barnacle Bot added the docs Improvements or additions to documentation label Jul 17, 2026
@steipete
steipete force-pushed the codex/fix-signal-debounce-newlines branch from c39abc3 to cad91a0 Compare July 17, 2026 21:46
@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels Jul 17, 2026
@steipete
steipete force-pushed the codex/fix-signal-debounce-newlines branch from 54786c5 to 9cf44ef Compare July 17, 2026 22:14
@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Jul 17, 2026
@steipete
steipete merged commit e805dbb into main Jul 17, 2026
256 of 258 checks passed
@steipete
steipete deleted the codex/fix-signal-debounce-newlines branch July 17, 2026 22:35
@steipete

steipete commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Merged via squash.

This was referenced Jul 17, 2026
Open
Open
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 18, 2026
@steipete
fix(signal): preserve newlines in debounced messages (openclaw#110090)
d759d53 
* fix(signal): use newlines in debounced messages

* docs: fix release gate command formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steipete steipete

Labels

channel: signal Channel integration: signal docs Improvements or additions to documentation maintainer Maintainer-authored PR merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. P2 Normal backlog priority with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. size: XS status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@steipete