Closed
Conversation
ee4779d to
8d8185b
Compare
8d8185b to
d3034de
Compare
Contributor
🦞 Codex ReviewFindings
Open Questions
Summary Review by Clawd 🦞 via Codex |
Contributor
|
Thanks for the PR! We already shipped per-group mention gating via telegram.groups with "*" defaults and removed telegram.requireMention (see src/telegram/bot.ts + docs/telegram.md). Closing as already implemented — appreciate the contribution. |
dgarson
referenced
this pull request
in dgarson/clawdbot
Feb 7, 2026
feat(meridia): experience-capture, experience-search, experience-reflect MCP tools (M3)
slathrop
referenced
this pull request
in slathrop/openclaw-js
Feb 11, 2026
slathrop
referenced
this pull request
in slathrop/openclaw-js
Feb 11, 2026
Tasks completed: 1/1 - Port commit #110 (exec approvals monospace command formatting) SUMMARY: .planning/phases/13-paths-config-refactoring/13-07-SUMMARY.md
Piboonsak
added a commit
to Piboonsak/openclaw_github
that referenced
this pull request
Mar 9, 2026
- Add SSH key retry logic (3 attempts, 15s delay) to handle transient VPS unreachability (openclaw#110) - Add SSH auth verification before proceeding with deploy - Pin [email protected] to avoid npm install failures (openclaw#109) - Add error handling for json5 install step - Add config verification logging for safeBins and model persistence (openclaw#97, openclaw#100) Fixes: openclaw#110, openclaw#109, openclaw#97, openclaw#100 Sprint: 1.6
github-actions bot
pushed a commit
to Piboonsak/openclaw_github
that referenced
this pull request
Mar 10, 2026
CyberSpencer
added a commit
to CyberSpencer/openclaw
that referenced
this pull request
Mar 19, 2026
…b_actions/actions/github-script-8 chore(deps): bump actions/github-script from 7 to 8
0x666c6f
added a commit
to 0x666c6f/openclaw
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
human written description
I love Clawd(is). So I am adding Clawd(is) to lots of group chats. Problem is, in some of them, you want the bot to always respond (e.g. for you and partner to manage your home), but in other ones, you want the bot to be on their best behaviour and not annoying (e.g. your padel chat, where the bot should only book padel slots for you).
We have requireMention as a setting, but its either globally on or off, so you can't switch the flag on per-chat granularity. Until now! This adds it.
It should also have sensible precedence rules too, so the most specific option (e.g. adding a per chat override) will have precedence over global settings, and that works both for the on or off modes.
Summary
Details
Config/schema
Telegram gating
Auto-reply/status
Docs
Tests
devenv shell -- pnpm vitest run -- src/telegram/bot.test.ts(ran full suite: 641 passed, 2 skipped)Prompts (step by step)
requireMentionon a per chat bases for clawdis, or not yet?i would put that in groups {default}
what do you think?
14. [2026-01-02 20:12:59 UTC] groupsDefault is clunky
i would put that in groups {default}
or not even
we can just put requreMention as a setting in there
15. [2026-01-02 20:13:23 UTC] i dont really understand
16. [2026-01-02 20:19:12 UTC] can you figure out what's most idiomatic and matches the patterns for other agent configs?
// Option C: Inheritance with "_default"
telegram: {
requireMention: true, // top-level = DMs
groups: {
_default: { requireMention: false }, // all groups unless overridden
"123456789": { requireMention: true } // specific group
}
}
Why _default over default:
default is a JS reserved word
_ prefix = "special key" convention
Clear it's metadata, not a group ID
Or even simpler (Option D):
telegram: {
requireMention: true, // DMs
groupRequireMention: false, // all groups
groupOverrides: {
"123456789": { requireMention: true }
}
}
17. [2026-01-02 20:19:39 UTC] I’d still accept the legacy groupsDefault for backward compatibility (deprecate it in docs), but promote _default
going forward.
-> legacy as in we added it or legacy as in its already there?
18. [2026-01-02 20:20:10 UTC] if we just introduced it in this PR its not legacy