fix: restore lint after Web Push migration#109845
Conversation
0ca3abc to
9b010b6
Compare
|
Codex review: needs real behavior proof before merge. Reviewed July 17, 2026, 5:21 AM ET / 09:21 UTC. Summary PR surface: Source -10. Total -10 across 1 file. Reproducibility: yes. at source level: the PR documents a 709-line module against a 700-line ratchet and reduces it to 699, while the current diff directly shows the proposed cleanup. This read-only review did not execute the failing lint path. Review metrics: 2 noteworthy metrics.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep migration behavior unchanged, restore the three comments encoding doctor ownership and exclusive-state invariants, and recover at least three lines from formatting or redundant local structure so the module remains below the 700-line limit. Do we have a high-confidence way to reproduce the issue? Yes at source level: the PR documents a 709-line module against a 700-line ratchet and reduces it to 699, while the current diff directly shows the proposed cleanup. This read-only review did not execute the failing lint path. Is this the best way to solve the issue? No in its current form: reducing the module below the lint budget is appropriate, but the narrowest maintainable fix preserves the migration-safety comments and removes equivalent nonessential lines elsewhere. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 0471b293bb5c. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -10. Total -10 across 1 file. View PR surface stats
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
9b010b6 to
296fae3
Compare
|
Merged via squash.
|
What Problem This Solves
Resolves a problem where the Web Push migration module exceeded the repository's 700-line lint budget, blocking exact-head validation for unrelated pull requests.
Why This Change Was Made
The migration stays behaviorally identical while redundant annotations, temporary values, formatting, and obvious comments are removed. The module now has 699 nonblank lines and needs no lint suppression.
User Impact
No user-visible behavior changes. Pull requests can pass the repository lint gate again.
Evidence
node scripts/run-vitest.mjs src/infra/state-migrations.web-push.test.ts— 23 passed./node_modules/.bin/oxlint src/infra/state-migrations.web-push.ts— passed./node_modules/.bin/oxfmt src/infra/state-migrations.web-push.ts— cleangit diff --check— passedAI-assisted: yes (Codex)