Skip to content

fix(ci): isolate orphan-recovery transcript tests#109826

Merged
steipete merged 1 commit into
mainfrom
fix/main-ci-resume-context-types-20260717
Jul 17, 2026
Merged

fix(ci): isolate orphan-recovery transcript tests#109826
steipete merged 1 commit into
mainfrom
fix/main-ci-resume-context-types-20260717

Conversation

@steipete

@steipete steipete commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

Current main fails checks-node-agentic-agents-core-subagents when the shared agents-core Vitest worker imports orphan recovery before its test-local transcript-reader module mock.

Why This Change Was Made

Inject the transcript reader through the existing orphan-recovery boundary so tests do not depend on module-cache import order, while production keeps the canonical reader.

User Impact

No runtime behavior change. Main CI can consistently validate interrupted subagent resume context.

Evidence

The independent check-test-types failure from that run was fixed separately on main by f656d96fc3e and is not part of this PR.

@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts agents Agent runtime and tooling size: XS maintainer Maintainer-authored PR labels Jul 17, 2026
@steipete
steipete force-pushed the fix/main-ci-resume-context-types-20260717 branch from 862a654 to a015350 Compare July 17, 2026 08:45
@openclaw-barnacle openclaw-barnacle Bot removed the scripts Repository scripts label Jul 17, 2026
@steipete steipete changed the title fix(ci): repair main test and script type checks fix(ci): isolate orphan-recovery transcript tests Jul 17, 2026
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels Jul 17, 2026
@clawsweeper

clawsweeper Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 17, 2026, 5:20 AM ET / 09:20 UTC.

Summary
Injects the transcript reader into orphan-recovery entry points and updates the tests to use an isolated reader mock instead of import-order-sensitive module mocking.

PR surface: Source +6, Tests +13. Total +19 across 2 files.

Reproducibility: yes. The linked main workflow failure demonstrates the shared-worker import-order problem, and the grouped orphan-recovery plus registry test command is the focused reproduction path.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P1] Finish the protected maintainer review and let exact-head CI gate the current SHA; no automated code repair is identified.

Security
Cleared: The patch adds no dependency, workflow, permission, secret, artifact-download, or supply-chain surface and preserves the canonical production transcript reader.

Review details

Best possible solution:

Land the injected reader seam once exact-head CI confirms the combined agents-core shard, keeping the canonical reader as the unchanged production default and the isolated mock confined to tests.

Do we have a high-confidence way to reproduce the issue?

Yes. The linked main workflow failure demonstrates the shared-worker import-order problem, and the grouped orphan-recovery plus registry test command is the focused reproduction path.

Is this the best way to solve the issue?

Yes. Dependency injection at the existing orphan-recovery boundary is narrower and more maintainable than preserving a module-cache mock or adding module resets, while leaving production composition unchanged.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 0471b293bb5c.

Label changes

Label justifications:

  • P3: This is a small, behavior-neutral test-isolation and CI reliability fix with no demonstrated user-facing runtime impact.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The protected maintainer PR changes test isolation and CI determinism without user-visible runtime behavior; focused test output and exact-head CI are the appropriate proof path.
Evidence reviewed

PR surface:

Source +6, Tests +13. Total +19 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 1 7 1 +6
Tests 1 24 11 +13
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 2 31 12 +19

What I checked:

Likely related people:

What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (3 earlier review cycles)
  • reviewed 2026-07-17T08:49:02.628Z sha a015350 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T08:56:37.011Z sha fd7d864 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-17T09:09:34.662Z sha 9b50fbd :: needs real behavior proof before merge. :: none

@steipete
steipete force-pushed the fix/main-ci-resume-context-types-20260717 branch 2 times, most recently from fd7d864 to 9b50fbd Compare July 17, 2026 09:05
@steipete
steipete force-pushed the fix/main-ci-resume-context-types-20260717 branch from 9b50fbd to 198b414 Compare July 17, 2026 09:16
@steipete
steipete merged commit 0890f7f into main Jul 17, 2026
116 checks passed
@steipete
steipete deleted the fix/main-ci-resume-context-types-20260717 branch July 17, 2026 09:33
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling maintainer Maintainer-authored PR P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant